From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 280EB2248B3 for ; Thu, 26 Feb 2026 04:05:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772078732; cv=none; b=XRVtSGdAen6tPJoxn/XTTo33MwHyLAQJSwCjJQYCm/3KC/glo7fpIJbzvKhEApZ3eb5gx20jSnHmWh76Z7U252+n8U/7dQmNz0aJ87MtRLNb9Y+sidYYNogADZKTiGltlpkvWAgQJpb4r5pPfrxoHZrgo37CJdWc9+goMJTxjyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772078732; c=relaxed/simple; bh=qRqQjB8ExFuOtCaYoLucMr/riVDLdU06uxQHzyIVsGY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GB5TRLeM+Txt5QaMrIas9C4CzZaWJyHmj/bAEu3CTXu3Tb2/p2ktxeGZNq0Q+iUuZzWbbztUgiItihv4lAKO3TecJP7rYBI1NE9QN2mynY8MWJXgiMfIxipc569X5bJBSsjVO4VF3v96vzOvFl1xyl+vI2zDC7u9cGp/L7jxNNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RyR4JdhK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S7vjCv1N; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RyR4JdhK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S7vjCv1N" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61PHa4JR3056486 for ; Thu, 26 Feb 2026 04:05:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=yH/WB+HwVrw7jUMbWcEH4YYI0VEemO5sUaG ca0nV7VQ=; b=RyR4JdhK88Fcpfgl7QWO8XCMAIBnuDlO00Y069sJz4NaV3+XqRl iCp2pVI6dvXmLaRCFKBujeSmHyX2M55sh1VNglo1lQGmoylwz0pDRDUU6UlCfcxD 7UofE5db52qmEeXnMlql0CGGYPVkDid52gYdWV49kzdzTx5guhWpoy1uGx90awuG 0UA4eVL9O8a6VDQhd+OFUmYwVn7GAcip6jsqK2+zu9YjAF7v/tsNsDlhBs0pYscI cTNQkJmgsS8tAWBwDy47RG8/PvAYISkVfT32Cves0IgNy0URWSGnnVyg9qj68pYm i4qEvZU6WhpkKIgwYM2Ex1d/qsNWVhccCXQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chx39k5gt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Feb 2026 04:05:30 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2aad3f8367bso4502565ad.0 for ; Wed, 25 Feb 2026 20:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772078730; x=1772683530; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yH/WB+HwVrw7jUMbWcEH4YYI0VEemO5sUaGca0nV7VQ=; b=S7vjCv1NxYoO8EJb0qFl73UA8nHSbt9N+CHv8c66AhIL/iehBz9WtZ/NssfLIMsNyZ ij4WyHtOFNLYeh52YwYBhNPVCKeKSRqanO30FOHBm8gNVAvTIie3Vrlt3m4jSsQzSjcA tJ6NFWZIrm7csWnH46Zm9xEtjkQTeokNblQW1BtZXy7WPg5UTL/tL6XkRjYntus4VQ4I cuea9F6hdhGee55ydVccR8JKZui9OZK3p2x4Vv9Ww3PEjBdgnI2cpKh8Z7PK2hqFu8po S2YtYhPU3TsMOdKqO9Nqcq15ep4uKLUDbI3+gYXt+wcJsaK/wOT6LpUSZSaB57t7dpbO LFFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772078730; x=1772683530; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yH/WB+HwVrw7jUMbWcEH4YYI0VEemO5sUaGca0nV7VQ=; b=UsHFMPgLqW+BqfV9nEExKy/a5pek8Cgarydep8W3DAVqdedWsdqyINv5rFzC5GTyH0 QH+GnLgoNte+mW/JMh7/ucaT0LC67mbaxUXXLD4Tl+CksUA/S8C59nkmWVzLOGFzt6bx y4ZyAhXougX8e35gR1zbuI1Rsxzr4Veokt8qvRMxys+AQR/yIL5Xs1eB1MqwJH2EFAW2 Xb4OlThURwfJ3D4Uy3KmH/d3T9m7bcS9/UTUi8aTVrJICImXky2Iq+/LrlNuhRGJaRuY UEDNDw5pvEceY79c2UhU+8RyF2uApAMUdDqXOhwZiSwykYNl2O4tR2jS2E9fWxAHA+a9 H/CA== X-Gm-Message-State: AOJu0Yy5gtmVieasclUsK39JHA4jL36dRtyXzUmR91M+wZtIErsQtCoF bNVmB1kVbO+CRamPs0T6jrAmGfpVkRkbzHsPmrlbkq5/5jr02BqDgMpUF+2JhR9MXp6hSQgSDNF snGdH3058YpN2BV2Jv1P+WImtaIkh6IHimIh6YKBmb4PGVtwWHVqRbMNCzlS8/HNGsKpoJA== X-Gm-Gg: ATEYQzzcNeRVwYOqPLE03geY+eabeSdhsP+4Azlo+GF0dD1U63s3s6onu6AQ4GSHS9E 2kJjzteuvIUMagIKa7Rs93/RGx/WvobyjYVXicqpZnrLx8OcuDcwRHxzfy78wCK9ilapaNBzZ3J OGOGmW7OymKu0BZ6szveh9I9CYOr5FM06r7ewg1yfiHEl2agLCwheLrqRhjOAAkfF2VNFZuzmId Sa4slh5N9sUJYTRzYl0Wc3dv7vStzwGmEn/HhkokHwE4GX6qsyQRR9vjeIB8DI9LPc8KaRFp5ri NzSqeVO7qnE50ngeIHasWqmqf1Cl/HSZ6p7spJWHw3VecxpwJV3Awzq6RUlzoWRrZsX64L1eqVo XOG3xJ/n7vMTDqOEsxHhmOeUyKBsQCpe34YxRCM7hQzK/rPqISpCiIoMlHGCtD/MgLc97ZBAMtT 0rO6khZJFHWIRA4/QgvLv9EGo+tkuaw62/5YPcQItPnQyz2w== X-Received: by 2002:a17:902:e5c8:b0:2ad:9a9b:e418 with SMTP id d9443c01a7336-2ade99d91cemr25645505ad.22.1772078729614; Wed, 25 Feb 2026 20:05:29 -0800 (PST) X-Received: by 2002:a17:902:e5c8:b0:2ad:9a9b:e418 with SMTP id d9443c01a7336-2ade99d91cemr25645105ad.22.1772078729127; Wed, 25 Feb 2026 20:05:29 -0800 (PST) Received: from hu-rrajkuma-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb69f9c2sm8189505ad.51.2026.02.25.20.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 20:05:28 -0800 (PST) From: Reshma Immaculate Rajkumar To: ath11k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Reshma Immaculate Rajkumar Subject: [PATCH ath-next] wifi: ath11k: Pass the correct value of each TID during a stop AMPDU session Date: Thu, 26 Feb 2026 09:35:23 +0530 Message-Id: <20260226040523.1496520-1-reshma.rajkumar@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI2MDAzMiBTYWx0ZWRfX5mKXScfyIJ/X mMVxUjJQQKJLnNMCxE/P88n3VVXUX7Mq9hoij1qX5woPmjJ/b81j0cr1QtboD2CUYqfZqceopa4 5l7prIIFZWRANqOM9Gl8oYnp3VQoiPHP6Tfl+03NOPD862Nn8qZe/G5lpV/m2F4A2sc4XOKTWdg gy5wSILZp/JOKl9DxWs/N1lfo4sQAKZyx+uX3T2UJj/2bDyUol/dk47y3dImhN6qgdJlw9DAmES zZiTAalrxATHqBsIfAzb1StggOMfjtcY7GCBQTJhBmJMCkO7N9oKGkFfzqBfoR5GztiOZ6u4ADl EcDJlmNLmY1k50wiDuXxaAm222ydBc2w8xIZDzXXgW3eXEpeogDJu7UAuJcN65CsfirtoPnfX4p pUKnE7vralIfUMRvA/9t1+NUH1EcvTgtSzF3jjSeKq10tcC55bGGNibkO27TuJeo8H+fqVgNGhn YukVm3VrghNOClGdczQ== X-Authority-Analysis: v=2.4 cv=FvoIPmrq c=1 sm=1 tr=0 ts=699fc68a cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=vkfXM0Oplov9zySb:21 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=_mytDIUbvz_f-yg6au4A:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: Z6jRR2sFFHM7olYGI2zp2f4p_-W7nigw X-Proofpoint-ORIG-GUID: Z6jRR2sFFHM7olYGI2zp2f4p_-W7nigw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_04,2026-02-25_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602260032 During ongoing traffic, a request to stop an AMPDU session for one TID could incorrectly affect other active sessions. This can happen because an incorrect TID reference would be passed when updating the BA session state, causing the wrong session to be stopped. As a result, the affected session would be reduced to a minimal BA size, leading to a noticeable throughput degradation. Fix this issue by passing the correct argument from ath11k_dp_rx_ampdu_stop() to ath11k_peer_rx_tid_reo_update() during a stop AMPDU session. Instead of passing peer->tx_tid, which is the base address of the array, corresponding to TID 0; pass the value of &peer->rx_tid[params->tid], where the different TID numbers are accounted for. Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.9.0.1-02146-QCAHKSWPL_SILICONZ-1 Fixes: d5c65159f2895 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Signed-off-by: Reshma Immaculate Rajkumar --- drivers/net/wireless/ath/ath11k/dp_rx.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index b9e976ddcbbf..d0a737995220 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -1110,9 +1110,8 @@ int ath11k_dp_rx_ampdu_stop(struct ath11k *ar, struct ath11k_base *ab = ar->ab; struct ath11k_peer *peer; struct ath11k_sta *arsta = ath11k_sta_to_arsta(params->sta); + struct dp_rx_tid *rx_tid; int vdev_id = arsta->arvif->vdev_id; - dma_addr_t paddr; - bool active; int ret; spin_lock_bh(&ab->base_lock); @@ -1124,15 +1123,14 @@ int ath11k_dp_rx_ampdu_stop(struct ath11k *ar, return -ENOENT; } - paddr = peer->rx_tid[params->tid].paddr; - active = peer->rx_tid[params->tid].active; + rx_tid = &peer->rx_tid[params->tid]; - if (!active) { + if (!rx_tid->active) { spin_unlock_bh(&ab->base_lock); return 0; } - ret = ath11k_peer_rx_tid_reo_update(ar, peer, peer->rx_tid, 1, 0, false); + ret = ath11k_peer_rx_tid_reo_update(ar, peer, rx_tid, 1, 0, false); spin_unlock_bh(&ab->base_lock); if (ret) { ath11k_warn(ab, "failed to update reo for rx tid %d: %d\n", @@ -1141,7 +1139,7 @@ int ath11k_dp_rx_ampdu_stop(struct ath11k *ar, } ret = ath11k_wmi_peer_rx_reorder_queue_setup(ar, vdev_id, - params->sta->addr, paddr, + params->sta->addr, rx_tid->paddr, params->tid, 1, 1); if (ret) ath11k_warn(ab, "failed to send wmi to delete rx tid %d\n", base-commit: 8bf22c33e7a172fbc72464f4cc484d23a6b412ba -- 2.34.1