From: kernel test robot <lkp@intel.com>
To: Miri Korenblit <miriam.rachel.korenblit@intel.com>,
linux-wireless@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH wireless-next] wifi: cfg80211: make cluster id an array
Date: Sun, 1 Mar 2026 22:26:08 +0800 [thread overview]
Message-ID: <202603012218.ucVoRBov-lkp@intel.com> (raw)
In-Reply-To: <20260301131848.b0085a6b4eb3.Ib16bf5cca55463d4c89e18099cf1dfe4de95d405@changeid>
Hi Miri,
kernel test robot noticed the following build warnings:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main linus/master v7.0-rc1 next-20260227]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Miri-Korenblit/wifi-cfg80211-make-cluster-id-an-array/20260301-192010
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20260301131848.b0085a6b4eb3.Ib16bf5cca55463d4c89e18099cf1dfe4de95d405%40changeid
patch subject: [PATCH wireless-next] wifi: cfg80211: make cluster id an array
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260301/202603012218.ucVoRBov-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260301/202603012218.ucVoRBov-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603012218.ucVoRBov-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/wireless/virtual/mac80211_hwsim.c: In function 'mac80211_hwsim_start_nan':
>> drivers/net/wireless/virtual/mac80211_hwsim.c:4081:13: warning: the comparison will always evaluate as 'true' for the address of 'cluster_id' will never be NULL [-Waddress]
4081 | if (conf->cluster_id && !is_zero_ether_addr(conf->cluster_id) &&
| ^~~~
In file included from include/net/mac80211.h:22,
from drivers/net/wireless/virtual/mac80211_hwsim.c:22:
include/net/cfg80211.h:4038:12: note: 'cluster_id' declared here
4038 | u8 cluster_id[ETH_ALEN] __aligned(2);
| ^~~~~~~~~~
vim +4081 drivers/net/wireless/virtual/mac80211_hwsim.c
a37a6f54439bf8 Ilan Peer 2025-09-08 4052
a37a6f54439bf8 Ilan Peer 2025-09-08 4053 static int mac80211_hwsim_start_nan(struct ieee80211_hw *hw,
a37a6f54439bf8 Ilan Peer 2025-09-08 4054 struct ieee80211_vif *vif,
a37a6f54439bf8 Ilan Peer 2025-09-08 4055 struct cfg80211_nan_conf *conf)
a37a6f54439bf8 Ilan Peer 2025-09-08 4056 {
a37a6f54439bf8 Ilan Peer 2025-09-08 4057 struct mac80211_hwsim_data *data = hw->priv;
a37a6f54439bf8 Ilan Peer 2025-09-08 4058 u64 tsf = mac80211_hwsim_get_tsf(hw, NULL);
a37a6f54439bf8 Ilan Peer 2025-09-08 4059 u32 dw_int = 512 * 1000;
a37a6f54439bf8 Ilan Peer 2025-09-08 4060 u64 until_dw = dw_int - do_div(tsf, dw_int);
a37a6f54439bf8 Ilan Peer 2025-09-08 4061 struct wireless_dev *wdev = ieee80211_vif_to_wdev(vif);
a37a6f54439bf8 Ilan Peer 2025-09-08 4062
a37a6f54439bf8 Ilan Peer 2025-09-08 4063 if (vif->type != NL80211_IFTYPE_NAN)
a37a6f54439bf8 Ilan Peer 2025-09-08 4064 return -EINVAL;
a37a6f54439bf8 Ilan Peer 2025-09-08 4065
a37a6f54439bf8 Ilan Peer 2025-09-08 4066 if (data->nan_device_vif)
a37a6f54439bf8 Ilan Peer 2025-09-08 4067 return -EALREADY;
a37a6f54439bf8 Ilan Peer 2025-09-08 4068
a37a6f54439bf8 Ilan Peer 2025-09-08 4069 /* set this before starting the timer, as preemption might occur */
a37a6f54439bf8 Ilan Peer 2025-09-08 4070 data->nan_device_vif = vif;
a37a6f54439bf8 Ilan Peer 2025-09-08 4071 data->nan_bands = conf->bands;
a37a6f54439bf8 Ilan Peer 2025-09-08 4072 data->nan_curr_dw_band = NL80211_BAND_2GHZ;
a37a6f54439bf8 Ilan Peer 2025-09-08 4073
a37a6f54439bf8 Ilan Peer 2025-09-08 4074 wiphy_debug(hw->wiphy, "nan_started, next_dw=%llu\n",
a37a6f54439bf8 Ilan Peer 2025-09-08 4075 until_dw);
a37a6f54439bf8 Ilan Peer 2025-09-08 4076
a37a6f54439bf8 Ilan Peer 2025-09-08 4077 hrtimer_start(&data->nan_timer,
a37a6f54439bf8 Ilan Peer 2025-09-08 4078 ns_to_ktime(until_dw * NSEC_PER_USEC),
a37a6f54439bf8 Ilan Peer 2025-09-08 4079 HRTIMER_MODE_REL_SOFT);
a37a6f54439bf8 Ilan Peer 2025-09-08 4080
a37a6f54439bf8 Ilan Peer 2025-09-08 @4081 if (conf->cluster_id && !is_zero_ether_addr(conf->cluster_id) &&
a37a6f54439bf8 Ilan Peer 2025-09-08 4082 is_zero_ether_addr(hwsim_nan_cluster_id)) {
a37a6f54439bf8 Ilan Peer 2025-09-08 4083 memcpy(hwsim_nan_cluster_id, conf->cluster_id, ETH_ALEN);
a37a6f54439bf8 Ilan Peer 2025-09-08 4084 } else if (is_zero_ether_addr(hwsim_nan_cluster_id)) {
a37a6f54439bf8 Ilan Peer 2025-09-08 4085 hwsim_nan_cluster_id[0] = 0x50;
a37a6f54439bf8 Ilan Peer 2025-09-08 4086 hwsim_nan_cluster_id[1] = 0x6f;
a37a6f54439bf8 Ilan Peer 2025-09-08 4087 hwsim_nan_cluster_id[2] = 0x9a;
a37a6f54439bf8 Ilan Peer 2025-09-08 4088 hwsim_nan_cluster_id[3] = 0x01;
a37a6f54439bf8 Ilan Peer 2025-09-08 4089 hwsim_nan_cluster_id[4] = get_random_u8();
a37a6f54439bf8 Ilan Peer 2025-09-08 4090 hwsim_nan_cluster_id[5] = get_random_u8();
a37a6f54439bf8 Ilan Peer 2025-09-08 4091 }
a37a6f54439bf8 Ilan Peer 2025-09-08 4092
a37a6f54439bf8 Ilan Peer 2025-09-08 4093 data->notify_dw = conf->enable_dw_notification;
a37a6f54439bf8 Ilan Peer 2025-09-08 4094
a37a6f54439bf8 Ilan Peer 2025-09-08 4095 cfg80211_nan_cluster_joined(wdev, hwsim_nan_cluster_id, true,
a37a6f54439bf8 Ilan Peer 2025-09-08 4096 GFP_KERNEL);
a37a6f54439bf8 Ilan Peer 2025-09-08 4097
a37a6f54439bf8 Ilan Peer 2025-09-08 4098 return 0;
a37a6f54439bf8 Ilan Peer 2025-09-08 4099 }
a37a6f54439bf8 Ilan Peer 2025-09-08 4100
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-03-01 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 11:18 [PATCH wireless-next] wifi: cfg80211: make cluster id an array Miri Korenblit
2026-03-01 14:26 ` kernel test robot [this message]
2026-03-01 15:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603012218.ucVoRBov-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox