From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 524A233066D for ; Sun, 1 Mar 2026 14:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772375175; cv=none; b=oDwoXO0ZM9dnYleXBM+1FV2hoZEiOvYKlwmBqSzaQtVHALt0CM35TD4GCiPDKuEVSeDUEkQzwibCJXDKW1AYKMrFzoPYUYXy+RyawuOKdllruG7mdzbVDRF2gd5jZOufcy7CvL93ltN6L7ZG04Rtt6d4phC3mEGOEosDqGAcOlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772375175; c=relaxed/simple; bh=iSY1TEV/Dty0aOkZfOwzkaHJETN+7met9Q3hzj+uxMI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I5cofiL/tTxlqjcwQGVWv24r0rH3ITtyJVg1AIgNeXSB5GJOuZwSXXfza7N4QQIXh0JbMNVUduyCbxjqdDv8fShv8HyzA9VmRq+IrRULUhMHm7rVvB7js6qRFJTjrJtCivDN7M2kupqeo/pKXgLEtYB6W+BPDBLMqX4hTUmdIo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JdKR0J/a; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JdKR0J/a" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772375173; x=1803911173; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iSY1TEV/Dty0aOkZfOwzkaHJETN+7met9Q3hzj+uxMI=; b=JdKR0J/a8tyhoigl5Y9t3Q0qJaMUl4JX6HogsOvQVE1LG3gAd2zleYGV W3j2zL4g54t7EnrOAke1v1QV7bgcSgqjE7mZM0/XjbJob97k4DDlBkiEY pb1Qba6R2p1nIUMIXAF2xAo3CfBRBT9eIVM/bqZH72t2wuR/0Hqs8wNLy hh0/hHv9ReEV9NcT8QPqsspaGQ+nuMnPI03P2vD9KEEq1p3aAIq/1Wv/6 LCrneiF+LkmhPRC4K+6+WqFopJzretJ0q3G5sSkPXdFKN2ZIfRX7KFwV7 TEd2yMhxELn58bU4sMdcgtj4bXay8uUOsCaIWaOEjlIO6Ky+6q9x933co A==; X-CSE-ConnectionGUID: PisZNV7NRy+hXPXANIE+rw== X-CSE-MsgGUID: VZzpVAr7T+2Qaru7Yxf9Ew== X-IronPort-AV: E=McAfee;i="6800,10657,11716"; a="98866525" X-IronPort-AV: E=Sophos;i="6.21,318,1763452800"; d="scan'208";a="98866525" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2026 06:26:13 -0800 X-CSE-ConnectionGUID: yEuqaFQ+QP+yExq8dvOJYg== X-CSE-MsgGUID: DwmRXGSZS+CsNfSJqZ89Tw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,318,1763452800"; d="scan'208";a="255219395" Received: from lkp-server01.sh.intel.com (HELO 59784f1c7b2a) ([10.239.97.150]) by orviesa001.jf.intel.com with ESMTP; 01 Mar 2026 06:26:12 -0800 Received: from kbuild by 59784f1c7b2a with local (Exim 4.98.2) (envelope-from ) id 1vwhkH-000000001VF-0rGI; Sun, 01 Mar 2026 14:26:09 +0000 Date: Sun, 1 Mar 2026 22:26:08 +0800 From: kernel test robot To: Miri Korenblit , linux-wireless@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev Subject: Re: [PATCH wireless-next] wifi: cfg80211: make cluster id an array Message-ID: <202603012218.ucVoRBov-lkp@intel.com> References: <20260301131848.b0085a6b4eb3.Ib16bf5cca55463d4c89e18099cf1dfe4de95d405@changeid> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260301131848.b0085a6b4eb3.Ib16bf5cca55463d4c89e18099cf1dfe4de95d405@changeid> Hi Miri, kernel test robot noticed the following build warnings: [auto build test WARNING on wireless-next/main] [also build test WARNING on wireless/main linus/master v7.0-rc1 next-20260227] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Miri-Korenblit/wifi-cfg80211-make-cluster-id-an-array/20260301-192010 base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main patch link: https://lore.kernel.org/r/20260301131848.b0085a6b4eb3.Ib16bf5cca55463d4c89e18099cf1dfe4de95d405%40changeid patch subject: [PATCH wireless-next] wifi: cfg80211: make cluster id an array config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260301/202603012218.ucVoRBov-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 15.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260301/202603012218.ucVoRBov-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202603012218.ucVoRBov-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/net/wireless/virtual/mac80211_hwsim.c: In function 'mac80211_hwsim_start_nan': >> drivers/net/wireless/virtual/mac80211_hwsim.c:4081:13: warning: the comparison will always evaluate as 'true' for the address of 'cluster_id' will never be NULL [-Waddress] 4081 | if (conf->cluster_id && !is_zero_ether_addr(conf->cluster_id) && | ^~~~ In file included from include/net/mac80211.h:22, from drivers/net/wireless/virtual/mac80211_hwsim.c:22: include/net/cfg80211.h:4038:12: note: 'cluster_id' declared here 4038 | u8 cluster_id[ETH_ALEN] __aligned(2); | ^~~~~~~~~~ vim +4081 drivers/net/wireless/virtual/mac80211_hwsim.c a37a6f54439bf8 Ilan Peer 2025-09-08 4052 a37a6f54439bf8 Ilan Peer 2025-09-08 4053 static int mac80211_hwsim_start_nan(struct ieee80211_hw *hw, a37a6f54439bf8 Ilan Peer 2025-09-08 4054 struct ieee80211_vif *vif, a37a6f54439bf8 Ilan Peer 2025-09-08 4055 struct cfg80211_nan_conf *conf) a37a6f54439bf8 Ilan Peer 2025-09-08 4056 { a37a6f54439bf8 Ilan Peer 2025-09-08 4057 struct mac80211_hwsim_data *data = hw->priv; a37a6f54439bf8 Ilan Peer 2025-09-08 4058 u64 tsf = mac80211_hwsim_get_tsf(hw, NULL); a37a6f54439bf8 Ilan Peer 2025-09-08 4059 u32 dw_int = 512 * 1000; a37a6f54439bf8 Ilan Peer 2025-09-08 4060 u64 until_dw = dw_int - do_div(tsf, dw_int); a37a6f54439bf8 Ilan Peer 2025-09-08 4061 struct wireless_dev *wdev = ieee80211_vif_to_wdev(vif); a37a6f54439bf8 Ilan Peer 2025-09-08 4062 a37a6f54439bf8 Ilan Peer 2025-09-08 4063 if (vif->type != NL80211_IFTYPE_NAN) a37a6f54439bf8 Ilan Peer 2025-09-08 4064 return -EINVAL; a37a6f54439bf8 Ilan Peer 2025-09-08 4065 a37a6f54439bf8 Ilan Peer 2025-09-08 4066 if (data->nan_device_vif) a37a6f54439bf8 Ilan Peer 2025-09-08 4067 return -EALREADY; a37a6f54439bf8 Ilan Peer 2025-09-08 4068 a37a6f54439bf8 Ilan Peer 2025-09-08 4069 /* set this before starting the timer, as preemption might occur */ a37a6f54439bf8 Ilan Peer 2025-09-08 4070 data->nan_device_vif = vif; a37a6f54439bf8 Ilan Peer 2025-09-08 4071 data->nan_bands = conf->bands; a37a6f54439bf8 Ilan Peer 2025-09-08 4072 data->nan_curr_dw_band = NL80211_BAND_2GHZ; a37a6f54439bf8 Ilan Peer 2025-09-08 4073 a37a6f54439bf8 Ilan Peer 2025-09-08 4074 wiphy_debug(hw->wiphy, "nan_started, next_dw=%llu\n", a37a6f54439bf8 Ilan Peer 2025-09-08 4075 until_dw); a37a6f54439bf8 Ilan Peer 2025-09-08 4076 a37a6f54439bf8 Ilan Peer 2025-09-08 4077 hrtimer_start(&data->nan_timer, a37a6f54439bf8 Ilan Peer 2025-09-08 4078 ns_to_ktime(until_dw * NSEC_PER_USEC), a37a6f54439bf8 Ilan Peer 2025-09-08 4079 HRTIMER_MODE_REL_SOFT); a37a6f54439bf8 Ilan Peer 2025-09-08 4080 a37a6f54439bf8 Ilan Peer 2025-09-08 @4081 if (conf->cluster_id && !is_zero_ether_addr(conf->cluster_id) && a37a6f54439bf8 Ilan Peer 2025-09-08 4082 is_zero_ether_addr(hwsim_nan_cluster_id)) { a37a6f54439bf8 Ilan Peer 2025-09-08 4083 memcpy(hwsim_nan_cluster_id, conf->cluster_id, ETH_ALEN); a37a6f54439bf8 Ilan Peer 2025-09-08 4084 } else if (is_zero_ether_addr(hwsim_nan_cluster_id)) { a37a6f54439bf8 Ilan Peer 2025-09-08 4085 hwsim_nan_cluster_id[0] = 0x50; a37a6f54439bf8 Ilan Peer 2025-09-08 4086 hwsim_nan_cluster_id[1] = 0x6f; a37a6f54439bf8 Ilan Peer 2025-09-08 4087 hwsim_nan_cluster_id[2] = 0x9a; a37a6f54439bf8 Ilan Peer 2025-09-08 4088 hwsim_nan_cluster_id[3] = 0x01; a37a6f54439bf8 Ilan Peer 2025-09-08 4089 hwsim_nan_cluster_id[4] = get_random_u8(); a37a6f54439bf8 Ilan Peer 2025-09-08 4090 hwsim_nan_cluster_id[5] = get_random_u8(); a37a6f54439bf8 Ilan Peer 2025-09-08 4091 } a37a6f54439bf8 Ilan Peer 2025-09-08 4092 a37a6f54439bf8 Ilan Peer 2025-09-08 4093 data->notify_dw = conf->enable_dw_notification; a37a6f54439bf8 Ilan Peer 2025-09-08 4094 a37a6f54439bf8 Ilan Peer 2025-09-08 4095 cfg80211_nan_cluster_joined(wdev, hwsim_nan_cluster_id, true, a37a6f54439bf8 Ilan Peer 2025-09-08 4096 GFP_KERNEL); a37a6f54439bf8 Ilan Peer 2025-09-08 4097 a37a6f54439bf8 Ilan Peer 2025-09-08 4098 return 0; a37a6f54439bf8 Ilan Peer 2025-09-08 4099 } a37a6f54439bf8 Ilan Peer 2025-09-08 4100 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki