public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: linux-wireless@vger.kernel.org
Cc: Brian Norris <briannorris@chromium.org>,
	Francesco Dolcini <francesco@dolcini.it>,
	Felix Fietkau <nbd@nbd.name>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Stanislaw Gruszka <stf_xl@wp.pl>,
	Hin-Tak Leung <hintak.leung@gmail.com>,
	Jes Sorensen <Jes.Sorensen@gmail.com>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan@kernel.org>
Subject: [PATCH 03/13] wifi: libertas_tf: drop redundant device reference
Date: Thu,  5 Mar 2026 12:07:03 +0100	[thread overview]
Message-ID: <20260305110713.17725-4-johan@kernel.org> (raw)
In-Reply-To: <20260305110713.17725-1-johan@kernel.org>

Driver core holds a reference to the USB interface and its parent USB
device while the interface is bound to a driver and there is no need to
take additional references unless the structures are needed after
disconnect.

Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/libertas_tf/if_usb.c b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
index f49151c18b79..07b38f2b8f58 100644
--- a/drivers/net/wireless/marvell/libertas_tf/if_usb.c
+++ b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
@@ -223,7 +223,6 @@ static int if_usb_probe(struct usb_interface *intf,
 	if (!priv)
 		goto dealloc;
 
-	usb_get_dev(udev);
 	usb_set_intfdata(intf, cardp);
 
 	return 0;
@@ -258,7 +257,6 @@ static void if_usb_disconnect(struct usb_interface *intf)
 	kfree(cardp);
 
 	usb_set_intfdata(intf, NULL);
-	usb_put_dev(interface_to_usbdev(intf));
 
 	lbtf_deb_leave(LBTF_DEB_MAIN);
 }
-- 
2.52.0


  parent reply	other threads:[~2026-03-05 11:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 11:07 [PATCH 00/13] wifi: drop redundant USB device references Johan Hovold
2026-03-05 11:07 ` [PATCH 01/13] wifi: at76c50x: drop redundant device reference Johan Hovold
2026-03-05 11:07 ` [PATCH 02/13] wifi: libertas: " Johan Hovold
2026-03-05 11:07 ` Johan Hovold [this message]
2026-03-05 11:07 ` [PATCH 04/13] wifi: mwifiex: " Johan Hovold
2026-03-06  9:46   ` Francesco Dolcini
2026-03-05 11:07 ` [PATCH 05/13] wifi: mt76: " Johan Hovold
2026-03-05 11:07 ` [PATCH 06/13] wifi: mt76x0u: " Johan Hovold
2026-03-05 11:07 ` [PATCH 07/13] wifi: mt76x2u: " Johan Hovold
2026-03-05 11:07 ` [PATCH 08/13] wifi: mt76: mt792xu: " Johan Hovold
2026-03-05 11:07 ` [PATCH 09/13] wifi: mt7601u: " Johan Hovold
2026-03-05 11:07 ` [PATCH 10/13] wifi: rt2x00: " Johan Hovold
2026-03-05 13:37   ` Stanislaw Gruszka
2026-03-05 14:15     ` Johan Hovold
2026-03-05 16:52   ` Stanislaw Gruszka
2026-03-05 11:07 ` [PATCH 11/13] wifi: rtl818x: " Johan Hovold
2026-03-05 11:07 ` [PATCH 12/13] wifi: rtl8xxxu: " Johan Hovold
2026-03-05 11:07 ` [PATCH 13/13] wifi: rtlwifi: usb: " Johan Hovold
2026-03-06  1:40 ` [PATCH 00/13] wifi: drop redundant USB device references Ping-Ke Shih
2026-03-06  8:09   ` Johan Hovold
2026-03-06  9:04     ` Ping-Ke Shih
2026-03-06  9:34       ` Johan Hovold
2026-03-06  9:36         ` Ping-Ke Shih
2026-03-06  9:49       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260305110713.17725-4-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=Jes.Sorensen@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=briannorris@chromium.org \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=francesco@dolcini.it \
    --cc=hintak.leung@gmail.com \
    --cc=kuba@kernel.org \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=nicolas.ferre@microchip.com \
    --cc=pkshih@realtek.com \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    --cc=stf_xl@wp.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox