public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: linux-wireless@vger.kernel.org
Cc: "Jeff Johnson" <jjohnson@kernel.org>,
	"Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Brian Norris" <briannorris@chromium.org>,
	"Francesco Dolcini" <francesco@dolcini.it>,
	"Felix Fietkau" <nbd@nbd.name>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Ryder Lee" <ryder.lee@mediatek.com>,
	"Shayne Chen" <shayne.chen@mediatek.com>,
	"Sean Wang" <sean.wang@mediatek.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Stanislaw Gruszka" <stf_xl@wp.pl>,
	"Hin-Tak Leung" <hintak.leung@gmail.com>,
	"Jes Sorensen" <Jes.Sorensen@gmail.com>,
	"Ping-Ke Shih" <pkshih@realtek.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Johan Hovold" <johan@kernel.org>
Subject: [PATCH v2 00/18] wifi: drop redundant USB device references
Date: Fri,  6 Mar 2026 09:51:26 +0100	[thread overview]
Message-ID: <20260306085144.12064-1-johan@kernel.org> (raw)

Driver core holds a reference to the USB interface and its parent USB
device while the interface is bound to a driver and there is no need to
take additional references unless the structures are needed after
disconnect.

Drop redundant device references to reduce cargo culting, make it easier
to spot drivers where an extra reference is needed, and reduce the risk
of memory leaks when drivers fail to release them.

Note that I sent an ath9k patch separately here:

	https://lore.kernel.org/all/20260305105803.17011-1-johan@kernel.org/

but I included it here in v2 for completeness.

Also note that Greg had already sent a fix for rtw88 which has been
picked up by Ping-Ke, but who asked me to send a replacement. If an
incremental patch is preferred I can instead send a follow up for that
one later.

Johan


Changes in v2:
 - include ath9k, previously submitted separately
 - include ath6kl and ath10k
 - rename the ath6kl and ath10k disconnect callbacks
 - fix a reference leak in rtw88 previously reported (and fixed
   differently) by Greg


Johan Hovold (18):
  wifi: ath6kl: drop redundant device reference
  wifi: ath6kl: rename disconnect callback
  wifi: ath9k: drop redundant device reference
  wifi: ath10k: drop redundant device reference
  wifi: ath10k: rename disconnect callback
  wifi: at76c50x: drop redundant device reference
  wifi: libertas: drop redundant device reference
  wifi: libertas_tf: drop redundant device reference
  wifi: mwifiex: drop redundant device reference
  wifi: mt76: drop redundant device reference
  wifi: mt76x0u: drop redundant device reference
  wifi: mt76x2u: drop redundant device reference
  wifi: mt76: mt792xu: drop redundant device reference
  wifi: mt7601u: drop redundant device reference
  wifi: rt2x00: drop redundant device reference
  wifi: rtl818x: drop redundant device reference
  wifi: rtl8xxxu: drop redundant device reference
  wifi: rtw88: fix device leak on probe failure

 drivers/net/wireless/ath/ath10k/usb.c            |  8 ++------
 drivers/net/wireless/ath/ath6kl/usb.c            | 16 ++++------------
 drivers/net/wireless/ath/ath9k/hif_usb.c         |  4 ----
 drivers/net/wireless/atmel/at76c50x-usb.c        | 12 ++++--------
 drivers/net/wireless/marvell/libertas/if_usb.c   |  3 ---
 .../net/wireless/marvell/libertas_tf/if_usb.c    |  2 --
 drivers/net/wireless/marvell/mwifiex/usb.c       |  4 ----
 drivers/net/wireless/mediatek/mt76/mt7615/usb.c  |  3 ---
 drivers/net/wireless/mediatek/mt76/mt76x0/usb.c  |  3 ---
 drivers/net/wireless/mediatek/mt76/mt76x2/usb.c  |  4 ----
 drivers/net/wireless/mediatek/mt76/mt7921/usb.c  |  2 --
 drivers/net/wireless/mediatek/mt76/mt7925/usb.c  |  2 --
 drivers/net/wireless/mediatek/mt76/mt792x_usb.c  |  1 -
 drivers/net/wireless/mediatek/mt7601u/usb.c      |  3 ---
 drivers/net/wireless/ralink/rt2x00/rt2x00usb.c   | 12 +-----------
 .../net/wireless/realtek/rtl818x/rtl8187/dev.c   |  4 ----
 drivers/net/wireless/realtek/rtl8xxxu/core.c     | 11 +++--------
 drivers/net/wireless/realtek/rtw88/usb.c         |  3 +--
 18 files changed, 15 insertions(+), 82 deletions(-)

-- 
2.52.0


             reply	other threads:[~2026-03-06  8:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06  8:51 Johan Hovold [this message]
2026-03-06  8:51 ` [PATCH v2 01/18] wifi: ath6kl: drop redundant device reference Johan Hovold
2026-03-06  8:51 ` [PATCH v2 02/18] wifi: ath6kl: rename disconnect callback Johan Hovold
2026-03-06  8:51 ` [PATCH v2 03/18] wifi: ath9k: drop redundant device reference Johan Hovold
2026-03-09 11:45   ` Toke Høiland-Jørgensen
2026-03-06  8:51 ` [PATCH v2 04/18] wifi: ath10k: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 05/18] wifi: ath10k: rename disconnect callback Johan Hovold
2026-03-06  8:51 ` [PATCH v2 06/18] wifi: at76c50x: drop redundant device reference Johan Hovold
2026-03-06  8:51 ` [PATCH v2 07/18] wifi: libertas: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 08/18] wifi: libertas_tf: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 09/18] wifi: mwifiex: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 10/18] wifi: mt76: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 11/18] wifi: mt76x0u: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 12/18] wifi: mt76x2u: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 13/18] wifi: mt76: mt792xu: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 14/18] wifi: mt7601u: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 15/18] wifi: rt2x00: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 16/18] wifi: rtl818x: " Johan Hovold
2026-03-16  6:02   ` Ping-Ke Shih
2026-03-06  8:51 ` [PATCH v2 17/18] wifi: rtl8xxxu: " Johan Hovold
2026-03-06  8:51 ` [PATCH v2 18/18] wifi: rtw88: fix device leak on probe failure Johan Hovold
2026-03-06 21:39 ` [PATCH v2 00/18] wifi: drop redundant USB device references Jeff Johnson
2026-03-09  6:27   ` Johannes Berg
2026-03-09 14:25     ` Jeff Johnson
2026-03-10 15:31 ` (subset) " Jeff Johnson
2026-03-24  8:31 ` Johan Hovold
2026-03-24  8:40   ` Ping-Ke Shih
2026-03-24  8:45     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260306085144.12064-1-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=Jes.Sorensen@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=briannorris@chromium.org \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=francesco@dolcini.it \
    --cc=gregkh@linuxfoundation.org \
    --cc=hintak.leung@gmail.com \
    --cc=jjohnson@kernel.org \
    --cc=kuba@kernel.org \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=nicolas.ferre@microchip.com \
    --cc=pkshih@realtek.com \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    --cc=stf_xl@wp.pl \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox