From: Johan Hovold <johan@kernel.org>
To: linux-wireless@vger.kernel.org
Cc: Ping-Ke Shih <pkshih@realtek.com>,
linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: [PATCH] wifi: rtw89: drop redundant device reference
Date: Fri, 6 Mar 2026 10:32:06 +0100 [thread overview]
Message-ID: <20260306093206.21081-1-johan@kernel.org> (raw)
Driver core holds a reference to the USB interface and its parent USB
device while the interface is bound to a driver and there is no need to
take additional references unless the structures are needed after
disconnect.
Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
Here's a follow-up to
https://lore.kernel.org/all/20260306085144.12064-1-johan@kernel.org/
which failed to include rtw89 despite Ping-Ke's explicit request (I
thought I had grepped for usb_get_dev in wireless before sending out
that series, but apparently not).
Johan
drivers/net/wireless/realtek/rtw89/usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/usb.c b/drivers/net/wireless/realtek/rtw89/usb.c
index da1b7ce8089e..64f0c0ec5ed4 100644
--- a/drivers/net/wireless/realtek/rtw89/usb.c
+++ b/drivers/net/wireless/realtek/rtw89/usb.c
@@ -935,7 +935,7 @@ static int rtw89_usb_intf_init(struct rtw89_dev *rtwdev,
if (!rtwusb->vendor_req_buf)
return -ENOMEM;
- rtwusb->udev = usb_get_dev(interface_to_usbdev(intf));
+ rtwusb->udev = interface_to_usbdev(intf);
usb_set_intfdata(intf, rtwdev->hw);
@@ -949,7 +949,6 @@ static void rtw89_usb_intf_deinit(struct rtw89_dev *rtwdev,
{
struct rtw89_usb *rtwusb = rtw89_usb_priv(rtwdev);
- usb_put_dev(rtwusb->udev);
kfree(rtwusb->vendor_req_buf);
usb_set_intfdata(intf, NULL);
}
--
2.52.0
next reply other threads:[~2026-03-06 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 9:32 Johan Hovold [this message]
2026-03-16 6:04 ` [PATCH] wifi: rtw89: drop redundant device reference Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306093206.21081-1-johan@kernel.org \
--to=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox