From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D3CC307494; Fri, 6 Mar 2026 09:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772790383; cv=none; b=F5blyFWkOnCzG1oVpZzKZQk1rO8IXN1FfsV9epi6ij4Xls6EB6R+IQ/rbc2JVaSo3ZZdOJ6vczWjIEepbwCGda2nlCJcQhD9fy9Fvq8j1zrZV4bZiQsTxYeotwkZqzmydSgUS4XhsW8qivLlMqlxrwAxrJQH50OKyR8Bo+GkLrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772790383; c=relaxed/simple; bh=p4/KWPmnqK2oC00dyUCTUQx38BPyb7n3SFjV7bzSle0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WMHO/Ka/q2d16JTfxqT23UhKo4U3Se5G3Hy5VPuJYu69/t0bwBvTSvh+gAMeWFKz4XZv4DJCEMw6CnAgF07imi5PDbRoZI3Th2EWdqouZZqaWESRwM1O83gahs4PSENW4wZ33TH2/Nq/F9dpcKScjr939gYAUl6RW5iwKoIk6Eo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=qU56ni2x; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="qU56ni2x" Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id E0F9622BA9; Fri, 6 Mar 2026 10:46:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1772790371; bh=fwHWaMTHGf2q55gryl1wYfenCSX2JOT+w45XCO6z0CE=; h=From:To:Subject; b=qU56ni2x27E3IMY/7kQHPt05dHq4vt9mkKv2vSu/KVAseYSdxOr8Y+GoWF8Hr0YJL 5U9GrXdQinJc1BNRBqY3XxKZCf6nmtbnXyc0N4LLXEZPzeknX9UqMJN/42Vs5Aowi9 DOtzmnUr1sOVdrUMkCbzlekT88xDo+LPwqh9YcDJKtgLt9hg4NCV4t9295S6bLWyP0 7f4b+dYio1wSGd6C4AUjKE5Pcrmp3LV8Pomt/cstyPpimNxZncbqJuObTi0puXP+po Oon+SgeNqp4tAtLLhDc6B9MkmaiHod0GpUgS504V42YdN+RXwptaZZo0cS9Ymb/Nzi 5vrg02lDx1DAg== Date: Fri, 6 Mar 2026 10:46:07 +0100 From: Francesco Dolcini To: Johan Hovold Cc: linux-wireless@vger.kernel.org, Brian Norris , Francesco Dolcini , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Jakub Kicinski , Stanislaw Gruszka , Hin-Tak Leung , Jes Sorensen , Ping-Ke Shih , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/13] wifi: mwifiex: drop redundant device reference Message-ID: <20260306094607.GA34779@francesco-nb> References: <20260305110713.17725-1-johan@kernel.org> <20260305110713.17725-5-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260305110713.17725-5-johan@kernel.org> On Thu, Mar 05, 2026 at 12:07:04PM +0100, Johan Hovold wrote: > Driver core holds a reference to the USB interface and its parent USB > device while the interface is bound to a driver and there is no need to > take additional references unless the structures are needed after > disconnect. > > Drop the redundant device reference to reduce cargo culting, make it > easier to spot drivers where an extra reference is needed, and reduce > the risk of memory leaks when drivers fail to release it. > > Signed-off-by: Johan Hovold Acked-by: Francesco Dolcini