From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89117428492 for ; Mon, 9 Mar 2026 23:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097565; cv=none; b=j6HTCrE7xY0cnloPELnFVHhUhT9Po+gp4ebnQhAOa1tCkyycDG2NHR79S4qlmyC88U9k5roSe2ws2ZLEXDNGAmFRDNubdJj7lGa9XouXIDep9ldfgAD+1OJUdbo8ZSRwK4HLCb3OqdM++43P4w8gBagCMbzsCvzoRU1gLDhot98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773097565; c=relaxed/simple; bh=gSGrdfWBD1PJQNA8FSE3vNlGaG4+Xx3EyKe0Xq77gxo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SCU52mFjh7Ljp+udEYgaesGAWoUsQAA1C0cx93M8MnPPs5LIDtzGjr/0mbEe4Inm7eDazgiVU/ZqD3PQue7CMqJI7LAqRW6aRgGFTG6RGBuYd9n597hQhzmRkUWIz2+kzhETKfZ3lbZSTwJ7DzWJ5pX+cNqGypg8sRkoGmOOcKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ifd7yez9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y1jsX6D6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ifd7yez9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y1jsX6D6" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HC46m2428014 for ; Mon, 9 Mar 2026 23:05:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=xPJuWGqmD+8 ZGPeNWjPXHXFYrZ4UhGUHfAbfp5Y2vtI=; b=ifd7yez9Im1NWd4QlgNWMkyW57W tVINyWDwUayU0ofvyVrNXpJlPZbi5BzPstvukcndCx8+sBUFqHybdIZIswuEEhzK zmFpSttCgyQIzDo0Uwgdl/0FaMmmN1EjgnaCA4AQmAxAFh50YkxYu49Gn997mxRc S575adbLb8WMzcm90Y2nFu6XMVgbx1fF0IPOGRUXNpT3vplyiumkPNTVWF65gXp6 n/mkmfTxImEfRtoCU5AyWCa8kx51DE8gFX6qwq2zP0hpXCvTgGH+HKqnmqVBKNzL PXY/qaHQigjhC7ZOOOfC0z4CflOArbZEHdbza4Mjlv/EpfwKbVd4mpZCysA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct1eks91p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:05:57 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd81506677so1046168485a.1 for ; Mon, 09 Mar 2026 16:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773097557; x=1773702357; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xPJuWGqmD+8ZGPeNWjPXHXFYrZ4UhGUHfAbfp5Y2vtI=; b=Y1jsX6D6D+gLOgPuFxjayg+3QDScUD1CtS26lwPEkmuoDWRju3/eG+yepQujaaYkbA SKahGwmiLonxF2bQ7PATwaJK19e3T+fazzoiRPThmJ0Y+f4cBgSjiTDp1mntehlQskZg i06XNupQTr5Jva01NbnYXbkNU1h+tebSH1FAgnf6hB9CdHzgIrz+gBAbE0bpDbcUrhlf xcwIblwVrRA6uFthIKoEsI5+NYTpoQ+hZlNliKiPqD2UuADgTRFXFXnAu+vfAjL5Velw nFa+bGAHZfybtW20rQbA3b5TKcCe2qzOWsupZ+PS6oHabzqZtPpo+KUZG5yNcxWKH7w5 iY0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773097557; x=1773702357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xPJuWGqmD+8ZGPeNWjPXHXFYrZ4UhGUHfAbfp5Y2vtI=; b=N1nR297+VihqoPJeRQ4NrWqkZ5hJRUqis936VeAY7H3aw+d4J3rwsBPMnYjHqOrVoj jBy7VvNqjBpq9aefsLFIt/JTjV2N4pTU8wHVuIDtpzGhwIAT9oHGGjkWaLuaig0zPVNu 9dALEPyjFv6Z6q6YcGrG8Xz/28PNws/PtOPTIiG5IYAzXEH9oE+S1PsKPF092TUiFozD PbJGOw7g4TUA36/EYzu7UTmVGSfPY3hXK8x7ISZeklKG7E6vdn4mtkJJER7LimRUAkxW OpizBDYIWO4vqtp6h2VJPQl8CuA24jtUe2DL0DiV6cCnqqYsv8wCXR9sUaFsgQpODdTm xLjw== X-Forwarded-Encrypted: i=1; AJvYcCV7RdU/rZ0fd9f/rx+05a1kMJonxPgoJj37UlaVvnefsoffDlc+AYCqLiJCgJ1Vnixteo+rGw7pC/5zDvccJg==@vger.kernel.org X-Gm-Message-State: AOJu0Yx/mjryQ3NpboTU2TRCi+yDnH173wjkQWvVRqeRMVGERU/vPE+I +hJ7Cl5dGvoqVFOzy6Mkdl35Ocgh1BqdrFs0GmXncqkoSlQKvWCOhwx1UMDla+aETHfYWfRmTyt xgzWhtBB0RDM7Hq8j1EtVfwJn+vPd6gln7ctmZvhwe2ANhTlofEECO8SwoR0gKBrcj3ATGQ== X-Gm-Gg: ATEYQzw7JbEdJM3J7xKfhwT0d/szDo6kYBUfAd2MjUs12jrRu09nbfj5mkaHcn9ZWvk +Zrm1xMDhPK66eamtKS0dqcxCz7LC+3EgSNu3q0G2DmZViC+1atuKT/t3pyHAN8zHX6j4EWR2xL GYgEmCJzxyJa1iO8A6vXgHX81ZMHBQUIopfyjEUigkeBUV5TwcwMRurZkVfq4W26lupK34lX44R qPBkqmBgKny6Y4Yhi07CIl1wrLtD8F1NHNEthCqe/RMW4aJbUQ8dvOcwibj3aCyRdgnKUEsgbG7 pIGfvjgxJF9X0QbJR72b7FOYOb/cGtH4nBVcpVKuoL8BE6ajKruig785xWNdp4GHg1dsqtL2rbg snU0LcigACwzas+gURgIuAQD0IlgMV6DHh2Upj8AJM25hhYtMZQ== X-Received: by 2002:a05:620a:444d:b0:8cd:8751:2b26 with SMTP id af79cd13be357-8cd87512fcfmr673414485a.58.1773097556810; Mon, 09 Mar 2026 16:05:56 -0700 (PDT) X-Received: by 2002:a05:620a:444d:b0:8cd:8751:2b26 with SMTP id af79cd13be357-8cd87512fcfmr673408485a.58.1773097555998; Mon, 09 Mar 2026 16:05:55 -0700 (PDT) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:ae20:597c:99b8:d161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae3d98asm33898478f8f.30.2026.03.09.16.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 16:05:55 -0700 (PDT) From: Daniel Lezcano To: konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org Subject: [PATCH v1 6/8] soc: qcom: pdr: Use the unified QMI service ID instead of defining it locally Date: Tue, 10 Mar 2026 00:03:35 +0100 Message-ID: <20260309230346.3584252-7-daniel.lezcano@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 3ZBu3QRD0vpYVJc9vfHGPzC9iCUm9Fp9 X-Proofpoint-ORIG-GUID: 3ZBu3QRD0vpYVJc9vfHGPzC9iCUm9Fp9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIwNCBTYWx0ZWRfX6mCg6BVT9LAM QpxJjoV4w7SCL4oF1/JUJD7QMPSmea2afFfSYJNCJ1111NAibfnNsbbhu/Au8mq6Y5YB4VJm2BA USzsfux9OHTfIHoODc70Zb369CjiXYPSaTNOf1MxqpZTTPvDs2sfeM4mWaMlYNZANjIq/xEns+5 aVLGpT+nnfg3RoutcHCusyQYCySr100ZAdj/pkKmGJ3rBsCG3iv+ZBdfBxc4SQc1vM+TLcC++sq DTxbSj6+9XZ7Rs14rp4ZOjhmnCQ8gYXJAHzOdJVb44QJEp6zX/LggWnmsqRL4jhGFe+j0UT//l4 jYE0i3gqtRFSKLWhv8CxLO24xfHiF+Lsna0bH7ttVqvW5NrNrU3+DK30hqk82hfYlU00dBHeUfF pm4vdvWZ9nVduK1+87rH8jjZOBfgBEwtRNRhaHv/rbRiPQkC6ltMggFiXTq+S82209SENf3uIjT ihP0Uqu/bKWPfEzFYHw== X-Authority-Analysis: v=2.4 cv=eIEeTXp1 c=1 sm=1 tr=0 ts=69af5255 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=P-X4VuwvMnWJEdMca_IA:9 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 malwarescore=0 clxscore=1011 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090204 Instead of defining a local macro with a custom name for the QMI service identifier, use the one provided in qmi.h and remove the locally defined macro. Signed-off-by: Daniel Lezcano --- drivers/soc/qcom/pdr_interface.c | 4 ++-- drivers/soc/qcom/pdr_internal.h | 3 --- drivers/soc/qcom/qcom_pd_mapper.c | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/soc/qcom/pdr_interface.c b/drivers/soc/qcom/pdr_interface.c index 72259f489075..6d879e1540b0 100644 --- a/drivers/soc/qcom/pdr_interface.c +++ b/drivers/soc/qcom/pdr_interface.c @@ -523,7 +523,7 @@ struct pdr_service *pdr_add_lookup(struct pdr_handle *pdr, if (!pds) return ERR_PTR(-ENOMEM); - pds->service = SERVREG_NOTIFIER_SERVICE; + pds->service = QMI_SERVICE_ID_SERVREG_NOTIF; strscpy(pds->service_name, service_name, sizeof(pds->service_name)); strscpy(pds->service_path, service_path, sizeof(pds->service_path)); pds->need_locator_lookup = true; @@ -678,7 +678,7 @@ struct pdr_handle *pdr_handle_alloc(void (*status)(int state, if (ret < 0) goto destroy_indack; - ret = qmi_add_lookup(&pdr->locator_hdl, SERVREG_LOCATOR_SERVICE, 1, 1); + ret = qmi_add_lookup(&pdr->locator_hdl, QMI_SERVICE_ID_SERVREG_LOC, 1, 1); if (ret < 0) goto release_qmi_handle; diff --git a/drivers/soc/qcom/pdr_internal.h b/drivers/soc/qcom/pdr_internal.h index 039508c1bbf7..6cd8cbe26822 100644 --- a/drivers/soc/qcom/pdr_internal.h +++ b/drivers/soc/qcom/pdr_internal.h @@ -4,9 +4,6 @@ #include -#define SERVREG_LOCATOR_SERVICE 0x40 -#define SERVREG_NOTIFIER_SERVICE 0x42 - #define SERVREG_REGISTER_LISTENER_REQ 0x20 #define SERVREG_GET_DOMAIN_LIST_REQ 0x21 #define SERVREG_STATE_UPDATED_IND_ID 0x22 diff --git a/drivers/soc/qcom/qcom_pd_mapper.c b/drivers/soc/qcom/qcom_pd_mapper.c index dc10bc859ff4..bb60b5c40554 100644 --- a/drivers/soc/qcom/qcom_pd_mapper.c +++ b/drivers/soc/qcom/qcom_pd_mapper.c @@ -656,7 +656,7 @@ static struct qcom_pdm_data *qcom_pdm_start(void) goto err_stop; } - ret = qmi_add_server(&data->handle, SERVREG_LOCATOR_SERVICE, + ret = qmi_add_server(&data->handle, QMI_SERVICE_ID_SERVREG_LOC, SERVREG_QMI_VERSION, SERVREG_QMI_INSTANCE); if (ret) { pr_err("PDM: error adding server %d\n", ret); -- 2.43.0