From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF9423B47F8 for ; Thu, 12 Mar 2026 09:58:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.244.123.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773309534; cv=none; b=KaR5YTnomZtoP5Z/duzXEomY9Ppv+PQbZT2YzRXET32eQf/xHnSBD496kMBeJYMbonNdBJLqNZJNZ3VTSDOWqDpMf1fwhJpP0dvUr1AGWzL/Vl/FRe6dXOGv7nzVdYI3FXmPmGDSpQLyM9r/+mZ3Gtb/CGob68Tlysdra41duZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773309534; c=relaxed/simple; bh=iZ/G+JLJ53Rtw97akSBHrYRVTBEPPne98gFSI0Vt00o=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eWF3XAI+9hIZQ7HH1EGnj8ktY+KCd37SGZfpZsQs+BPOrq43FsUeNY5NBi+vFs9Y9aYWXLNM4vS0gd6qG1NqPrqcsaeDxqBiNaCUWPC08sP0cTK21OuQyVQecAPi3J5Qf5fBD1ujw/0fyuYWqwcz7cZOspparbwiAinYPAX21Zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=OqefKu2j; arc=none smtp.client-ip=60.244.123.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="OqefKu2j" X-UUID: 0a25651a1dfa11f1a02d4725871ece0b-20260312 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=LGW1Q3DcXuGPmdrKZkdMgEGTb3Lki1aiU/Y6FbqrF6k=; b=OqefKu2jQ08eqv8/FNRQr6IQ8MHha+3xKmf92yx7vnYUS7h19kUn48Yh0WI5YJDYhdmG5C16GkD5XXt2WIm0nv5xLVmvlEX5StQk3ige1WE8IMX+DARyXLx4MGwSqp+DGh8WDr6sfvbP6S3Fzz6b5DMPck1FAQeCYpRBiuMDBaY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:d68a564b-59c2-4135-8716-b01e83299834,IP:0,U RL:0,TC:0,Content:0,EDM:-25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-25 X-CID-META: VersionHash:e7bac3a,CLOUDID:806ea4d4-060f-4ecc-9ee0-121eeeb4a682,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|836|888|898,TC:-5,Content: 0|15|50,EDM:2,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL:0,OSI: 0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 0a25651a1dfa11f1a02d4725871ece0b-20260312 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1879968139; Thu, 12 Mar 2026 17:58:37 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 12 Mar 2026 17:58:36 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Thu, 12 Mar 2026 17:58:36 +0800 From: Shayne Chen To: Felix Fietkau CC: linux-wireless , Lorenzo Bianconi , Ryder Lee , Evelyn Tsai , Money Wang , linux-mediatek , StanleyYP Wang , Shayne Chen Subject: [PATCH mt76 5/6] wifi: mt76: mt7996: fix the temporary buffer for calibration-free data Date: Thu, 12 Mar 2026 17:57:23 +0800 Message-ID: <20260312095724.2117448-5-shayne.chen@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260312095724.2117448-1-shayne.chen@mediatek.com> References: <20260312095724.2117448-1-shayne.chen@mediatek.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N From: StanleyYP Wang Move the declaration of buf[] outside the for loop. Fixes: 224c7c2be578 ("wifi: mt76: mt7996: apply calibration-free data from OTP") Signed-off-by: StanleyYP Wang Signed-off-by: Shayne Chen --- drivers/net/wireless/mediatek/mt76/mt7996/mcu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c index 2a9c59d15894..4c733f51a03e 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c @@ -4104,6 +4104,7 @@ mt7996_mcu_get_cal_free_data(struct mt7996_dev *dev) } for (band = 0; band < __MT_MAX_BAND; band++) { + u8 buf[MT7996_EEPROM_BLOCK_SIZE]; const struct cal_free_data *cal; u16 prev_block_idx = -1; u16 adie_base; @@ -4126,13 +4127,13 @@ mt7996_mcu_get_cal_free_data(struct mt7996_dev *dev) u16 eep_offset = cal[i].eep_offs; u16 block_idx = adie_offset / MT7996_EEPROM_BLOCK_SIZE; u16 offset = adie_offset % MT7996_EEPROM_BLOCK_SIZE; - u8 buf[MT7996_EEPROM_BLOCK_SIZE]; if (is_mt7996(&dev->mt76) && band == MT_BAND1 && dev->var.type == MT7996_VAR_TYPE_444) eep_offset -= MT_EE_7977BN_OFFSET; if (prev_block_idx != block_idx) { + memset(buf, 0, sizeof(buf)); ret = mt7996_mcu_get_eeprom(dev, adie_offset, buf, MT7996_EEPROM_BLOCK_SIZE, EEPROM_MODE_EFUSE); -- 2.51.0