From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 033B23FBEBC for ; Thu, 12 Mar 2026 17:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.129.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773334869; cv=none; b=Cgnahi8EmoLe/cwERETTSsz8YbSO7Nisg3ZL4YbxYIG3ac4eQn5RQ+YaJV7ceVksidojKC8gfdrJjoXz/kpJkIoEnWrdua8QBEtCohphDmj6cu2eiysj5Smg4IOsNCUaIhpkZBzpqvUU393Umq0qOL+M/dWKbIXfaEB8z8P4qTY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773334869; c=relaxed/simple; bh=VCaTw+3e5e9i/Vs/TIQN7VI6oLLEjVwiS3ZnSP7M4Qw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QjlWT8Boe98qsXvYbwY+obbYjg/v48KGzmZ7Ic7mQvIFyWwBJkm9W53UosHE7mGQNiIT3pAmDq6v4YW+nQ9SELsAci3ueEdI7GOEyb1kUQeFRJKWRj5aosjK6W5pcOeJzhUTB/lJjh+EBry0QRh24bY7uTf4jpZMaOI9VGYDw+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=candelatech.com; spf=pass smtp.mailfrom=candelatech.com; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b=pi4sX+d1; arc=none smtp.client-ip=148.163.129.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=candelatech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=candelatech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="pi4sX+d1" X-Virus-Scanned: Proofpoint Essentials engine Received: from mail3.candelatech.com (mail.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 80DE740008D for ; Thu, 12 Mar 2026 17:01:03 +0000 (UTC) Received: from ben-dt5.candelatech.com (firewall.candelatech.com [50.251.239.81]) by mail3.candelatech.com (Postfix) with ESMTP id DEBF313C2B1; Thu, 12 Mar 2026 10:01:00 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com DEBF313C2B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1773334861; bh=VCaTw+3e5e9i/Vs/TIQN7VI6oLLEjVwiS3ZnSP7M4Qw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pi4sX+d1FZz8DjHdEhTTd1JFf0kiplcFbB7IOCN/D4WTA9NKs8C/m9APT4CE/l8Rm 31LUy5NnDTgUDSWexuc7mOYYo6BJdAX6Dis/a/H2HNDHfgTePibSC7nN/69GKvMn3A PZU6FxHR7eVObbq8F6TfJegzrrZEaNjgpuhjv8PQ= From: greearb@candelatech.com To: linux-wireless@vger.kernel.org Cc: Ben Greear Subject: [PATCH wireless-next v2 13/28] wifi: iwlwifi: mld: Remove warning about BAID. Date: Thu, 12 Mar 2026 10:00:11 -0700 Message-ID: <20260312170026.285494-14-greearb@candelatech.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20260312170026.285494-1-greearb@candelatech.com> References: <20260312170026.285494-1-greearb@candelatech.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MDID: 1773334864-ByhRCRTGuIDD X-PPE-STACK: {"stack":"us5"} X-MDID-O: us5;ut7;1773334864;ByhRCRTGuIDD;;f7146c1849a4b08a52804beb1c1cdf45 X-PPE-TRUSTED: V=1;DIR=OUT; From: Ben Greear It seems to be expected behaviour, and is seen fairly often in testing in adverse conditions, so make it a one-line log message instead of WARN splat. Signed-off-by: Ben Greear --- drivers/net/wireless/intel/iwlwifi/mld/agg.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mld/agg.c b/drivers/net/wireless/intel/iwlwifi/mld/agg.c index a757077b0a7a..23d55374ef8a 100644 --- a/drivers/net/wireless/intel/iwlwifi/mld/agg.c +++ b/drivers/net/wireless/intel/iwlwifi/mld/agg.c @@ -216,10 +216,16 @@ iwl_mld_reorder(struct iwl_mld *mld, struct napi_struct *napi, if (baid == IWL_RX_REORDER_DATA_INVALID_BAID) return IWL_MLD_PASS_SKB; - /* no sta yet */ - if (WARN_ONCE(!sta, - "Got valid BAID without a valid station assigned\n")) + /* no sta yet. This happens fairly often, don't WARN_ON about it. */ + if (!sta) { + static bool done_once; + + if (!done_once) { + IWL_ERR(mld, "Got valid BAID without a valid station assigned, will not log again.\n"); + done_once = true; + } return IWL_MLD_PASS_SKB; + } mld_sta = iwl_mld_sta_from_mac80211(sta); -- 2.42.0