From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAA5B282F04 for ; Fri, 13 Mar 2026 07:25:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773386736; cv=none; b=qwQONEhSn1o2ex/Wmx30ljAR7KZE51BJ7qU2RSyX5EQIchwdKS2nu32WmjSUXqW04RDaG5NqPnLA6Pkd9PseUvJk+eAsxt0372OqwqQ9eDerlsMFL7IAsFfxUHZSf4sXORwRUz94IfdN4kgGiEtunV1BW9XO7sueADA5AhmfAMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773386736; c=relaxed/simple; bh=kAC+7sDl/a14Vs1h3KMyJ/VzJDy00VlQM9KN8bY9090=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=frpKTN6TUih8/wav7mrGh9XL+ulxzXe2WnsRWDHJikqL0aqTUUcv+mn0S29qZYAmIIQWpA+vuMGenmGfsTgvSbAHmapDVOXUHYUk02rh+rzCzzoBqrYddnWA846egQI0lsy5keYxrDrDwBEIRH415+whcdUdg2xUlmwEmhpb1E4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k2py5qeq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=io43G5+A; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k2py5qeq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="io43G5+A" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D5tbY1070446 for ; Fri, 13 Mar 2026 07:25:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AQVxrRpusczABSPSmpq/enYzVk4XVbwwzWAg5n9gicI=; b=k2py5qeqkjbrcfV1 2mnunJMwP5KQ2irw1tnZiSxInyns+9RXZ5bKO3tS4xWvGyt0S/TC0qSwv9KZKYBG A9SPxhWf6IYD/FwisccckfMUhRFys/bni/qTIL4PXFPh/LmwbkRFAzjUJHJ0ByGX vjzltokeXeH3J+Nj5ZB7h4gZND+YQqwTf8Go57jpzkdONdgQsQoaYE9vfrdjFKIy 79uBru/EcDIBtlm701q1xgylwwibTBp2o7mvlRvjyJuPCnLqfBiX0Fpboa1FtgYd Ay3buMI7BK0cuJi5s9YGesjfWXjLwcMmeapKL2ufkxXWTedIw9c7dXzO1ks9eQzm VJHuYg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4ymyxm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 07:25:08 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-359fe456655so1385749a91.3 for ; Fri, 13 Mar 2026 00:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773386707; x=1773991507; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=AQVxrRpusczABSPSmpq/enYzVk4XVbwwzWAg5n9gicI=; b=io43G5+A/mX448S4IkxwibX51zyj9rXdokCdK3CG0GDFOZYxQv2GpCsCwIB65c+Doj XbIEq+4hIRvrGxJ/sxmmBmm8bZ1To6XXW5PYdzobbjl2or4vztxBOe8HWlCzqRVeQlmY /IOT9gSOuIjMdIqlt3M/WVjK/boYjwYs/nA0ze9fPKXBzWGR9p7saJaxWBhqMNM7IyP4 SJq4p1BlfJWTYHoLHZU0blf8QARqlU89fOWQspzaSh+rVsts1Zcss9JTr2Biujk8euFn AU44J7vpxpAAO/fapfVUXB1u5ZuQVXw6dVawU7NFvFM4mh/cyhlIIgQcl7yrBrE+AqRr tW8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773386707; x=1773991507; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AQVxrRpusczABSPSmpq/enYzVk4XVbwwzWAg5n9gicI=; b=Sjiq7t748BkDT1Nc5jKSWD1PWlYeQZ5DDtxgXSUflBIsYTjq+CrKPa3/beSGdL8nyB m3TpeMXfKvAAn248I1Pals7LwV0xhm66uQO53GoXJo/7UjtbEDlKbL7uClxt2TaMmq5u 4nYe/cNLS5PnAlgpWOfSMHMAY7UHyPaw/Upnp91Ncj6WwLxwPpscdraWXaoywtk7lpxV s28j9IF2IBjqXzILT0XtG27ryEiX9LUEGW7iS8Ap7F8kN3S/0dq9we+XMi23I83Mjzhy 8PqchLGJ0fKjiuqmkT853h6PWxCMw25n8oNtwqZmFpJRGq8lJIlNX5EgOlbntKFSrvH0 Lh6g== X-Forwarded-Encrypted: i=1; AJvYcCWh42Kwb8luuvA5GWa3UKfKMfzNbvYJxgtMMhgAkCzKzI2ZpNF/JZZ5DEAVKlIlx1iRZ5RFdLYNYxR3oV0HRw==@vger.kernel.org X-Gm-Message-State: AOJu0YxrmqS1hxg3EIKNVtU4SKiLXiGCfGtX8NhwK5zmpjs3Tc5Wp+Tz gL7qiINA2GlL6Moem9Egl+ROkdFrIz9n1ZqXH3+SaNZxJHSCv/Bst71CkD3ku3gwHPOTWoslzQv MLTlJqBY4jbqld1DVWyaTlOIVNtLuL1NfTaSmUGw9h4dLr8ZQTfgJ0yKqG4ko5buayoQ6Vw== X-Gm-Gg: ATEYQzzNEo+ixJU6ZRQWDKfPzvVPr/We+jJgFQZ6XWvuCGzQX2f1riJDoOgRItCPfuz d3qK3Xt4ov/hXx6JaxV9ZtFfUzWm2TBLTU0jc7bax3nq2bvsZ57ZLpgYKUBc7d9gCKdmcIHF/W3 6ax7S5FdvkBzoM8IFF1D8RXhWwBLPKLTyXviHd9NCgN3UruuhI1y9/Xd6UCXRveMc+SV7Lo7Eay aXkQbbOo0tfkCq9SDqiokfu3XN6yYrwDGbxeUfmrLtwAPvfWFPqZ6DluCn9JbEeHsVMjzmq8QDa r1C3t3NBXsxwlwpm+wPLYh2mbkisiEZA1aGvVtSQW9Y/5nPTezOn0U3+5NvznaWD1DcLKha1oz/ 7cpYihDIfTER8+PfIr3jv+kOyCyvjG2StMXGxqc0YZa80YMdS X-Received: by 2002:a17:90b:4c0c:b0:359:9a87:85b5 with SMTP id 98e67ed59e1d1-35a22111a28mr2064446a91.29.1773386707178; Fri, 13 Mar 2026 00:25:07 -0700 (PDT) X-Received: by 2002:a17:90b:4c0c:b0:359:9a87:85b5 with SMTP id 98e67ed59e1d1-35a22111a28mr2064386a91.29.1773386706318; Fri, 13 Mar 2026 00:25:06 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35a07f0a365sm7143906a91.13.2026.03.13.00.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 00:25:05 -0700 (PDT) Date: Fri, 13 Mar 2026 12:54:50 +0530 From: Mukesh Ojha To: Sumit Garg Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg Subject: Re: [PATCH v2 02/15] firmware: qcom: Add a generic PAS service Message-ID: <20260313072450.sx7vqtvh62nflhff@hu-mojha-hyd.qualcomm.com> References: <20260312062756.694390-1-sumit.garg@kernel.org> <20260312062756.694390-3-sumit.garg@kernel.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260312062756.694390-3-sumit.garg@kernel.org> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA1OCBTYWx0ZWRfX8qtR/74omYfQ S78Z2p1sG2z6+q9SzlmRPyS/ambc7uy2lgWJZQoKnh6MZff5USjiLPYEW2uAFv6It0WI7CEh7oy WAno6fEE4MBkMULkFaTpg2kZT3P5+Ldd5Zd5jqwxTbh7/8AyIB1pK1yHyutEwLK0w1bBdlZtgTi l6Ex5cfSRZ9Jjvw6blTNovN2sAbint1IQ6sWW0wCh/fZw1tCiQMmecIRlM0oLeRle/+J//NLksk bIFRw84PrPE6eEN+hAto4uSH7XSdpUt7w0sFFboZUvOK46GkwKHdcT/DNiu2T+gykiTX+aAIiON z0ujavm2S8nH6sD7wMJuSUFdr4tPdt69JhDAuCyp1+w7SelSCxzTUBXJ6qBTF3+/Y3iHWfckU94 WhuxihVWPotzSvFU0puxd3iHlA2Csi6jtMC0BIXUO4/78cXqZ8IjaBEo2Cd274+PXd7u0VGOIsq hUkYUECj0HrWcrF2Deg== X-Proofpoint-ORIG-GUID: Efvxb3s_Fpl4fRLBc7kHL4YOAF0IEiOA X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b3bbd4 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=B9m6UvTZno2CEb395rQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: Efvxb3s_Fpl4fRLBc7kHL4YOAF0IEiOA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130058 On Thu, Mar 12, 2026 at 11:57:43AM +0530, Sumit Garg wrote: > From: Sumit Garg > > Qcom platforms has the legacy of using non-standard SCM calls > splintered over the various kernel drivers. These SCM calls aren't > compliant with the standard SMC calling conventions which is a > prerequisite to enable migration to the FF-A specifications from Arm. > > OP-TEE as an alternative trusted OS to Qualcomm TEE (QTEE) can't > support these non-standard SCM calls. And even for newer architectures > with S-EL2 and Hafnium support, QTEE won't be able to support SCM using S‑EL2 with Hafnium > calls either with FF-A requirements coming in. And with both OP-TEE > and QTEE drivers well integrated in the TEE subsystem, it makes further > sense to reuse the TEE bus client drivers infrastructure. > > The added benefit of TEE bus infrastructure is that there is support > for discoverable/enumerable services. With that client drivers don't > have to manually invoke a special SCM call to know the service status. > > So enable the generic Peripheral Authentication Service (PAS) provided > by the firmware. It acts as the common layer with different TZ > backends plugged in whether it's an SCM implementation or a proper > TEE bus based PAS service implementation. > > Signed-off-by: Sumit Garg > --- > drivers/firmware/qcom/Kconfig | 8 + > drivers/firmware/qcom/Makefile | 1 + > drivers/firmware/qcom/qcom_pas.c | 298 +++++++++++++++++++++++++ > drivers/firmware/qcom/qcom_pas.h | 53 +++++ > include/linux/firmware/qcom/qcom_pas.h | 41 ++++ > 5 files changed, 401 insertions(+) > create mode 100644 drivers/firmware/qcom/qcom_pas.c > create mode 100644 drivers/firmware/qcom/qcom_pas.h > create mode 100644 include/linux/firmware/qcom/qcom_pas.h > > diff --git a/drivers/firmware/qcom/Kconfig b/drivers/firmware/qcom/Kconfig > index b477d54b495a..8653639d06db 100644 > --- a/drivers/firmware/qcom/Kconfig > +++ b/drivers/firmware/qcom/Kconfig > @@ -6,6 +6,14 @@ > > menu "Qualcomm firmware drivers" > > +config QCOM_PAS > + tristate > + help > + Enable the generic Peripheral Authentication Service (PAS) provided > + by the firmware. It acts as the common layer with different TZ > + backends plugged in whether it's an SCM implementation or a proper > + TEE bus based PAS service implementation. > + > config QCOM_SCM > select QCOM_TZMEM > tristate > diff --git a/drivers/firmware/qcom/Makefile b/drivers/firmware/qcom/Makefile > index 0be40a1abc13..dc5ab45f906a 100644 > --- a/drivers/firmware/qcom/Makefile > +++ b/drivers/firmware/qcom/Makefile > @@ -8,3 +8,4 @@ qcom-scm-objs += qcom_scm.o qcom_scm-smc.o qcom_scm-legacy.o > obj-$(CONFIG_QCOM_TZMEM) += qcom_tzmem.o > obj-$(CONFIG_QCOM_QSEECOM) += qcom_qseecom.o > obj-$(CONFIG_QCOM_QSEECOM_UEFISECAPP) += qcom_qseecom_uefisecapp.o > +obj-$(CONFIG_QCOM_PAS) += qcom_pas.o > diff --git a/drivers/firmware/qcom/qcom_pas.c b/drivers/firmware/qcom/qcom_pas.c > new file mode 100644 > index 000000000000..beb1bae55546 > --- /dev/null > +++ b/drivers/firmware/qcom/qcom_pas.c > @@ -0,0 +1,298 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include > +#include > +#include > +#include > + > +#include "qcom_pas.h" > + > +struct qcom_pas_ops *ops_ptr; Should this be static ? > + > +/** > + * devm_qcom_pas_context_alloc() - Allocate peripheral authentication service > + * context for a given peripheral > + * > + * PAS context is device-resource managed, so the caller does not need > + * to worry about freeing the context memory. > + * > + * @dev: PAS firmware device > + * @pas_id: peripheral authentication service id > + * @mem_phys: Subsystem reserve memory start address > + * @mem_size: Subsystem reserve memory size > + * > + * Return: The new PAS context, or ERR_PTR() on failure. > + */ > +struct qcom_pas_context *devm_qcom_pas_context_alloc(struct device *dev, > + u32 pas_id, > + phys_addr_t mem_phys, > + size_t mem_size) > +{ > + struct qcom_pas_context *ctx; > + > + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return ERR_PTR(-ENOMEM); > + > + ctx->dev = dev; > + ctx->pas_id = pas_id; > + ctx->mem_phys = mem_phys; > + ctx->mem_size = mem_size; > + > + return ctx; > +} > +EXPORT_SYMBOL_GPL(devm_qcom_pas_context_alloc); > + > +/** > + * qcom_pas_init_image() - Initialize peripheral authentication service state > + * machine for a given peripheral, using the metadata > + * @pas_id: peripheral authentication service id > + * @metadata: pointer to memory containing ELF header, program header table > + * and optional blob of data used for authenticating the metadata > + * and the rest of the firmware > + * @size: size of the metadata > + * @ctx: optional pas context > + * > + * Return: 0 on success. > + * > + * Upon successful return, the PAS metadata context (@ctx) will be used to > + * track the metadata allocation, this needs to be released by invoking > + * qcom_pas_metadata_release() by the caller. > + */ > +int qcom_pas_init_image(u32 pas_id, const void *metadata, size_t size, > + struct qcom_pas_context *ctx) > +{ > + if (ops_ptr) > + return ops_ptr->init_image(ops_ptr->dev, pas_id, > + metadata, size, ctx); > + > + return -ENODEV; if (!ops_ptr) return -ENODEV; return ops_ptr->init_image(ops_ptr->dev, pas_id, metadata, size, ctx); > +} > +EXPORT_SYMBOL_GPL(qcom_pas_init_image); > + > +/** > + * qcom_pas_metadata_release() - release metadata context > + * @ctx: pas context > + */ > +void qcom_pas_metadata_release(struct qcom_pas_context *ctx) > +{ > + if (!ctx || !ctx->ptr) > + return; > + > + if (ops_ptr) > + ops_ptr->metadata_release(ops_ptr->dev, ctx); > +} > +EXPORT_SYMBOL_GPL(qcom_pas_metadata_release); > + > +/** > + * qcom_pas_mem_setup() - Prepare the memory related to a given peripheral > + * for firmware loading > + * @pas_id: peripheral authentication service id > + * @addr: start address of memory area to prepare > + * @size: size of the memory area to prepare > + * > + * Return: 0 on success. > + */ > +int qcom_pas_mem_setup(u32 pas_id, phys_addr_t addr, phys_addr_t size) > +{ > + if (ops_ptr) > + return ops_ptr->mem_setup(ops_ptr->dev, pas_id, addr, size); > + > + return -ENODEV; > +} > +EXPORT_SYMBOL_GPL(qcom_pas_mem_setup); > + > +/** > + * qcom_pas_get_rsc_table() - Retrieve the resource table in passed output buffer > + * for a given peripheral. > + * > + * Qualcomm remote processor may rely on both static and dynamic resources for > + * its functionality. Static resources typically refer to memory-mapped > + * addresses required by the subsystem and are often embedded within the > + * firmware binary and dynamic resources, such as shared memory in DDR etc., > + * are determined at runtime during the boot process. > + * > + * On Qualcomm Technologies devices, it's possible that static resources are > + * not embedded in the firmware binary and instead are provided by TrustZone. > + * However, dynamic resources are always expected to come from TrustZone. This > + * indicates that for Qualcomm devices, all resources (static and dynamic) will > + * be provided by TrustZone PAS service. > + * > + * If the remote processor firmware binary does contain static resources, they > + * should be passed in input_rt. These will be forwarded to TrustZone for > + * authentication. TrustZone will then append the dynamic resources and return > + * the complete resource table in output_rt_tzm. > + * > + * If the remote processor firmware binary does not include a resource table, > + * the caller of this function should set input_rt as NULL and input_rt_size > + * as zero respectively. > + * > + * More about documentation on resource table data structures can be found in > + * include/linux/remoteproc.h > + * > + * @ctx: PAS context > + * @pas_id: peripheral authentication service id > + * @input_rt: resource table buffer which is present in firmware binary > + * @input_rt_size: size of the resource table present in firmware binary > + * @output_rt_size: TrustZone expects caller should pass worst case size for > + * the output_rt_tzm. > + * > + * Return: > + * On success, returns a pointer to the allocated buffer containing the final > + * resource table and output_rt_size will have actual resource table size from > + * TrustZone. The caller is responsible for freeing the buffer. On failure, > + * returns ERR_PTR(-errno). > + */ > +struct resource_table *qcom_pas_get_rsc_table(struct qcom_pas_context *ctx, > + void *input_rt, > + size_t input_rt_size, > + size_t *output_rt_size) > +{ > + if (ops_ptr) > + return ops_ptr->get_rsc_table(ops_ptr->dev, ctx, input_rt, > + input_rt_size, output_rt_size); > + > + return ERR_PTR(-ENODEV); > +} > +EXPORT_SYMBOL_GPL(qcom_pas_get_rsc_table); > + > +/** > + * qcom_pas_auth_and_reset() - Authenticate the given peripheral firmware > + * and reset the remote processor > + * @pas_id: peripheral authentication service id > + * > + * Return: 0 on success. > + */ > +int qcom_pas_auth_and_reset(u32 pas_id) > +{ > + if (ops_ptr) > + return ops_ptr->auth_and_reset(ops_ptr->dev, pas_id); > + > + return -ENODEV; > +} > +EXPORT_SYMBOL_GPL(qcom_pas_auth_and_reset); > + > +/** > + * qcom_pas_prepare_and_auth_reset() - Prepare, authenticate, and reset the > + * remote processor > + * > + * @ctx: Context saved during call to qcom_scm_pas_context_init() > + * > + * This function performs the necessary steps to prepare a PAS subsystem, > + * authenticate it using the provided metadata, and initiate a reset sequence. > + * > + * It should be used when Linux is in control setting up the IOMMU hardware > + * for remote subsystem during secure firmware loading processes. The > + * preparation step sets up a shmbridge over the firmware memory before > + * TrustZone accesses the firmware memory region for authentication. The > + * authentication step verifies the integrity and authenticity of the firmware > + * or configuration using secure metadata. Finally, the reset step ensures the > + * subsystem starts in a clean and sane state. > + * > + * Return: 0 on success, negative errno on failure. > + */ > +int qcom_pas_prepare_and_auth_reset(struct qcom_pas_context *ctx) > +{ > + if (ops_ptr) > + return ops_ptr->prepare_and_auth_reset(ops_ptr->dev, ctx); > + > + return -ENODEV; > +} > +EXPORT_SYMBOL_GPL(qcom_pas_prepare_and_auth_reset); > + > +/** > + * qcom_pas_set_remote_state() - Set the remote processor state > + * @state: peripheral state > + * @pas_id: peripheral authentication service id > + * > + * Return: 0 on success. > + */ > +int qcom_pas_set_remote_state(u32 state, u32 pas_id) > +{ > + if (ops_ptr) > + return ops_ptr->set_remote_state(ops_ptr->dev, state, pas_id); > + > + return -ENODEV; > +} > +EXPORT_SYMBOL_GPL(qcom_pas_set_remote_state); > + > +/** > + * qcom_pas_shutdown() - Shut down the remote processor > + * @pas_id: peripheral authentication service id > + * > + * Return: 0 on success. > + */ > +int qcom_pas_shutdown(u32 pas_id) > +{ > + if (ops_ptr) > + return ops_ptr->shutdown(ops_ptr->dev, pas_id); > + > + return -ENODEV; > +} > +EXPORT_SYMBOL_GPL(qcom_pas_shutdown); > + > +/** > + * qcom_pas_supported() - Check if the peripheral authentication service is > + * available for the given peripheral > + * @pas_id: peripheral authentication service id > + * > + * Return: true if PAS is supported for this peripheral, otherwise false. > + */ > +bool qcom_pas_supported(u32 pas_id) > +{ > + if (ops_ptr) > + return ops_ptr->supported(ops_ptr->dev, pas_id); > + > + return false; > +} > +EXPORT_SYMBOL_GPL(qcom_pas_supported); > + > +/** > + * qcom_pas_is_available() - Check for PAS service > + * Name of the function is self sufficient, we can avoid for one liner documentation. > + * Return: true on success. > + */ > +bool qcom_pas_is_available(void) > +{ > + /* > + * The barrier for ops_ptr is intended to synchronize the data stores > + * for the ops data structure when client drivers are in parallel > + * checking for PAS service availability. > + * > + * Once the PAS backend becomes available, it is allowed for multiple > + * threads to enter TZ for parallel bringup of co-processors during > + * boot. > + */ > + return !!smp_load_acquire(&ops_ptr); > +} > +EXPORT_SYMBOL_GPL(qcom_pas_is_available); > + > +/** > + * qcom_pas_ops_register() - Register PAS service ops > + * @ops: PAS service ops pointer > + */ same here.. > +void qcom_pas_ops_register(struct qcom_pas_ops *ops) > +{ > + if (!qcom_pas_is_available()) > + /* Paired with smp_load_acquire() in qcom_pas_is_available() */ > + smp_store_release(&ops_ptr, ops); > + else > + pr_err("qcom_pas: ops already registered\n"); > +} > +EXPORT_SYMBOL_GPL(qcom_pas_ops_register); > + > +/** > + * qcom_pas_ops_unregister() - Unregister PAS service ops > + */ same here to avoid verbose.. > +void qcom_pas_ops_unregister(void) > +{ > + /* Paired with smp_load_acquire() in qcom_pas_is_available() */ > + smp_store_release(&ops_ptr, NULL); > +} > +EXPORT_SYMBOL_GPL(qcom_pas_ops_unregister); > + > +MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("Qualcomm common TZ PAS driver"); > diff --git a/drivers/firmware/qcom/qcom_pas.h b/drivers/firmware/qcom/qcom_pas.h > new file mode 100644 > index 000000000000..4ebed22178f8 > --- /dev/null > +++ b/drivers/firmware/qcom/qcom_pas.h > @@ -0,0 +1,53 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#ifndef __QCOM_PAS_INT_H > +#define __QCOM_PAS_INT_H > + > +struct device; > + > +/** > + * struct qcom_pas_ops - Qcom Peripheral Authentication Service (PAS) ops > + * @drv_name: PAS driver name. > + * @dev: PAS device pointer. > + * @supported: Peripheral supported callback. > + * @init_image: Peripheral image initialization callback. > + * @mem_setup: Peripheral memory setup callback. > + * @get_rsc_table: Peripheral get resource table callback. > + * @prepare_and_auth_reset: Peripheral prepare firmware authentication and > + * reset callback. > + * @auth_and_reset: Peripheral firmware authentication and reset > + * callback. > + * @set_remote_state: Peripheral set remote state callback. > + * @shutdown: Peripheral shutdown callback. > + * @metadata_release: Image metadata release callback. > + */ > +struct qcom_pas_ops { > + const char *drv_name; > + struct device *dev; > + bool (*supported)(struct device *dev, u32 pas_id); > + int (*init_image)(struct device *dev, u32 pas_id, > + const void *metadata, size_t size, > + struct qcom_pas_context *ctx); > + int (*mem_setup)(struct device *dev, u32 pas_id, > + phys_addr_t addr, phys_addr_t size); > + void *(*get_rsc_table)(struct device *dev, > + struct qcom_pas_context *ctx, > + void *input_rt, > + size_t input_rt_size, > + size_t *output_rt_size); > + int (*prepare_and_auth_reset)(struct device *dev, > + struct qcom_pas_context *ctx); > + int (*auth_and_reset)(struct device *dev, u32 pas_id); > + int (*set_remote_state)(struct device *dev, u32 state, u32 pas_id); > + int (*shutdown)(struct device *dev, u32 pas_id); > + void (*metadata_release)(struct device *dev, > + struct qcom_pas_context *ctx); I think, some of them can be unwrapped to look cleaner.. > +}; > + > +void qcom_pas_ops_register(struct qcom_pas_ops *ops); > +void qcom_pas_ops_unregister(void); > + > +#endif /* __QCOM_PAS_INT_H */ > diff --git a/include/linux/firmware/qcom/qcom_pas.h b/include/linux/firmware/qcom/qcom_pas.h > new file mode 100644 > index 000000000000..ef7328ecfa47 > --- /dev/null > +++ b/include/linux/firmware/qcom/qcom_pas.h > @@ -0,0 +1,41 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. Should this not carry all copyright coming from qcom_scm.h > + */ > + > +#ifndef __QCOM_PAS_H > +#define __QCOM_PAS_H > + > +#include > +#include > + > +struct qcom_pas_context { > + struct device *dev; > + u32 pas_id; > + phys_addr_t mem_phys; > + size_t mem_size; > + void *ptr; > + dma_addr_t phys; > + ssize_t size; > + bool use_tzmem; > +}; > + > +bool qcom_pas_is_available(void); > +struct qcom_pas_context *devm_qcom_pas_context_alloc(struct device *dev, > + u32 pas_id, > + phys_addr_t mem_phys, > + size_t mem_size); > +int qcom_pas_init_image(u32 pas_id, const void *metadata, size_t size, > + struct qcom_pas_context *ctx); > +struct resource_table *qcom_pas_get_rsc_table(struct qcom_pas_context *ctx, > + void *input_rt, size_t input_rt_size, > + size_t *output_rt_size); > +int qcom_pas_mem_setup(u32 pas_id, phys_addr_t addr, phys_addr_t size); > +int qcom_pas_auth_and_reset(u32 pas_id); > +int qcom_pas_prepare_and_auth_reset(struct qcom_pas_context *ctx); > +int qcom_pas_set_remote_state(u32 state, u32 pas_id); > +int qcom_pas_shutdown(u32 pas_id); > +bool qcom_pas_supported(u32 pas_id); > +void qcom_pas_metadata_release(struct qcom_pas_context *ctx); > + > +#endif /* __QCOM_PAS_H */ > -- > 2.51.0 > -- -Mukesh Ojha