From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F7FA371886 for ; Thu, 26 Mar 2026 12:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774528355; cv=none; b=hevrXNO8xJbZ7Jzp6Au61ezBN0jg+GiA0avXJqQ907BuZmYOo+sqPH2juqsWty3KlsE+wy8dEL+BHDz6YtEODCwFdwkyXHbRsMJg3PHqVD2lyraZZzXORYqMXc8J/uXERoYz4Iaiffc/smNwFMMyAp9Alr17SUOo2uzii5/7cy8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774528355; c=relaxed/simple; bh=KwQq7eyM0mQVqNtiIXpVpzQjQ6XV2ioWYBG3yYG4oHY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=l7K+bDVUnPnAOYPKV8XlJQrkIXZYj1x208Jj6uwn17aOAOyCZOBBf4ByT+PjkZuFX2ZphGyZArKGlIjJypodO2d6NEnBB6/EmCy2/Tg37aV7GwrtQi5muyu91vqWcQXBRItGYbfXDFt4PaDv+ppQ/7jn+BsiaP6nYSRe3nxGH8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=g52yV3Hs; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="g52yV3Hs" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-485345e2fdfso5270225e9.2 for ; Thu, 26 Mar 2026 05:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774528352; x=1775133152; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=44Rl4IuwAjVXDZrVO8Bc7181pdJEclCn1gduNsTGsBw=; b=g52yV3HsuZmXhXLr0i1orfxC2PFUp6xQNsLcFFLUBcB7xbZhq9fFing+SUs+qpJDHM Y+TQVYvC2BeAR5rvqG5WQBSjfpHB4GY/0O8fTS+KveaAvcqnJXKuDPLtt6ddClxPuJn7 IOQhtxiBpFDKRbnGIo/Uv9ppSbS/X/4ApV0ePlsUR+LAgz6HZaZ8HgiE4jKFFtXacGqC kUKrN7jAwtEFQdXrupWgXyDClPuTENt+i2Ra7f0UglAC0y1FcdhJ6GCfzKEYHKyEhH+M RSjqgmAJZVh4u4xCfhdYNLDL0AY2093BITU39TTHGYSBUdrIkQKRATlyJIoPisp9/eaw IEYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774528352; x=1775133152; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=44Rl4IuwAjVXDZrVO8Bc7181pdJEclCn1gduNsTGsBw=; b=omAN5m6fJSsxwevB5h3EXPMlYxSPp2xAtJjq2xcS1VxyzoEou9A5znUQEescJRVvuB 7vADrHKktOotCkNxzaYCJUcolKXIq0H/wPdEE+e65bcyqCdlQeyOVzieVU06W4lnPtK0 Hil7o6itLcBI/zrzQws34MDExHr7taVjap6B+5JWgde5UJUFqyNtqwYAl0YbRwdYd0vi jurOtMwxukTdoQbinEa9W7iquKePpN24+RSonIYrmf6KLzudmwbpPZA7qwsoMdqy9G6L 5YDtBBQWPEXBYhluR64UC2Z5fQjN08CNIp5aEgfZC7CRZTVtAq3FPqVjgxRE0cY054y1 AF3A== X-Forwarded-Encrypted: i=1; AJvYcCWl9UgNLb+T0PIMiQyif/dadocZkhYBnFzGMjjKAQhYtrcmuD5WGz+corOK8eaUD4YuB6WesQo4Yd1H46JxAg==@vger.kernel.org X-Gm-Message-State: AOJu0YyWYx+5YqRakgWjU1NIsBq1mv9XSjzNNwP7XhIkC9NyMMmrhupG bj1y9IPE6HmN3IpVrW4NOYKP/4qIWSPyT4aDY81YHA4tPBOgganKWhpZpDKXpqRUB5G7uoA2b8+ /tDnU3vZ97LuKRg== X-Received: from wmcq12.prod.google.com ([2002:a05:600c:c10c:b0:487:247f:cb9e]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:5296:b0:483:7783:537b with SMTP id 5b1f17b1804b1-4871605bde7mr108915255e9.24.1774528351509; Thu, 26 Mar 2026 05:32:31 -0700 (PDT) Date: Thu, 26 Mar 2026 12:31:58 +0000 In-Reply-To: <20260326-gfp64-v2-0-d916021cecdf@google.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260326-gfp64-v2-0-d916021cecdf@google.com> X-Mailer: b4 0.14.3 Message-ID: <20260326-gfp64-v2-2-d916021cecdf@google.com> Subject: [PATCH v2 2/4] iwlegacy: 3945-mac: Fixup allocation failure log From: Brendan Jackman To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Stanislaw Gruszka , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , Allison Henderson , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, Brendan Jackman Content-Type: text/plain; charset="utf-8" Fix 2 issues spotted by AI[0]: 1. Missing space after the full stop. 2. Wrong GFP flags are printed. And also switch to %pGg for the GFP flags. This produces nice readable output and decouples the format string from the size of gfp_t. [0] https://sashiko.dev/#/patchset/20260319-gfp64-v1-0-2c73b8d42b7f%40google.com Signed-off-by: Brendan Jackman --- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/wireless/intel/iwlegacy/3945-mac.c index c148654aa9533..88b31e0b9568c 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c @@ -1002,9 +1002,9 @@ il3945_rx_allocate(struct il_priv *il, gfp_t priority) D_INFO("Failed to allocate SKB buffer.\n"); if (rxq->free_count <= RX_LOW_WATERMARK && net_ratelimit()) - IL_ERR("Failed to allocate SKB buffer with %0x." + IL_ERR("Failed to allocate SKB buffer with %pGg. " "Only %u free buffers remaining.\n", - priority, rxq->free_count); + &gfp_mask, rxq->free_count); /* We don't reschedule replenish work here -- we will * call the restock method and if it still needs * more buffers it will schedule replenish */ -- 2.51.2