From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-a1-smtp.messagingengine.com (flow-a1-smtp.messagingengine.com [103.168.172.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BD5C78C9C; Thu, 26 Mar 2026 21:18:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.136 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774559894; cv=none; b=HbmQJaaQUQaWuU65LIsnsvCmd7sstqfpX/f+iUd5aDZMcANVm3jmUYPByYzxFxBMvFhhqirJlMvBsgt0+k852R7bK5MxUH5uxBpYT8mzzxY4Exsc3NkcTEjh3QBcv2mOGLO+GAuAOzvymyvHRhICDpUVCSt/dV9sRqYOHzIwIMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774559894; c=relaxed/simple; bh=DRLRvIU8ZWZkXRz1bJkCUDrO6OoViF8KWKqmafYFSQU=; h=Content-Type:MIME-Version:From:To:Date:Subject:Cc:In-Reply-To: References:Message-Id; b=HZZMSM1rR7hrksr/uYknrc0UAuyQPGAfjt63oJsBA1CcfyBV0O/ydv//IT8HUb/iwalm4F0/6IpZJ2Z5Fe2BFjtMhnzUuhonEReAiQ4Hc7b7Frl/byMN1eQxjMbquyHGvq1HhjvkmRkLs/lU2IVy2CB+ohxEf83ij9RJBZh2mko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=jetm.me; spf=pass smtp.mailfrom=jetm.me; dkim=pass (2048-bit key) header.d=jetm.me header.i=@jetm.me header.b=B1OozqUR; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=qoFAzsoV; arc=none smtp.client-ip=103.168.172.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=jetm.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jetm.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jetm.me header.i=@jetm.me header.b="B1OozqUR"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="qoFAzsoV" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailflow.phl.internal (Postfix) with ESMTP id 8DD59138014D; Thu, 26 Mar 2026 17:18:12 -0400 (EDT) Received: from phl-imap-07 ([10.202.2.97]) by phl-compute-02.internal (MEProxy); Thu, 26 Mar 2026 17:18:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetm.me; h=cc:cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1774559892; x=1774567092; bh=+tfmY/v2HtY5x2GcuRis244mDWronYR/iYKmIjptCQ8=; b= B1OozqUR9wU2oJhixwEKUomHLfraD83tHL6yHnbYQ4iOZjVUWhHp1Opo+ZccK+zV FWdShXollx6H1e6xnBK2cYid9K7YzIVspBRKkgWgRXa72nd47KX7dLHeyxf9WLnC kAlXEb/CTobWxTl8Uo7P3YwJCBv2PaPIEroGqCLYjuDUA6KMVChAji+d1fl//MM1 ZuZUI7eOGOR5IRNAXMPzPAItDe5pGIPPaC0KbCHX4tyNPwgpjP1xMlParGhF7cx6 1gdPlDif9EizP2iGILTuaTTS/7Qxq4dOB2QmIdk+WlWJxvJAvp65lBQUzX9Tu/F7 r099vtVAz+eRqGS1d5nEjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1774559892; x= 1774567092; bh=+tfmY/v2HtY5x2GcuRis244mDWronYR/iYKmIjptCQ8=; b=q oFAzsoVEYP8xIX3IfCmjayWsk3qcBb6ga+rm9ACMoeL8elZikkQNs3itFtbUWpFk K5rpwXTbvS1pSRVJ/sQx+yqQ2jjGGsFidxVDVtrDrq0MsLXf55A2vJltXiJhXzCY b6zLbpYQ4hCg8N1NwaTuLMdID0VAiF7WsBjgDbBlrntkYPtKWaggkg+uv7oz5U92 yujBFFG7fSUaX8afui+uu0hACmJ+Gy2GbQ9fxjPmMa+3qYB4hh4iCUmALtRh9q6c Gox/mZa9HMjeVPyLqaOzzvz7eNl1UMnV1dvklP/3I9p+oVj8juazJz0AkaMd7s9F D5W8nZhc/uRDVNKLJRRdQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdefvdekgeegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegopf hokfffucdluddtmdenucfjughrpefotggggffhvfffufevjghfsehtkedttdertdejnecu hfhrohhmpeflrghvihgvrhcuvfhirgcuoehflhhoshhssehjvghtmhdrmhgvqeenucggtf frrghtthgvrhhnpeektdffveejhfeffeevgfefhffhuedvvdfgfffhieetleefvefgfeek tedvffffgfenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepfhhlohhsshesjhgvthhmrdhmvgdp nhgspghrtghpthhtohepvdefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrnh hgvghlohhgihhorggttghhihhnohdruggvlhhrvghgnhhosegtohhllhgrsghorhgrrdgt ohhmpdhrtghpthhtohepfeduleefieefudesghhmrghilhdrtghomhdprhgtphhtthhope hlohhonhhgrddtgidttdesghhmrghilhdrtghomhdprhgtphhtthhopegrrhhivghlrdhr ohhsvghnfhgvlhgurdejhedtsehgmhgrihhlrdgtohhmpdhrtghpthhtoheptghhrghpuh hishgurghrihhogeesghhmrghilhdrtghomhdprhgtphhtthhopehgihhoshgrlheltdes ghhmrghilhdrtghomhdprhgtphhtthhopehmrghtthhhihgrshdrsghgghesghhmrghilh drtghomhdprhgtphhtthhopehrrgguohhirdgthhhrihhssehgmhgrihhlrdgtohhmpdhr tghpthhtohepshgrmhhurdhtohhljhgrmhhosehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i9dde48b3:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id C96EC1EA006B; Thu, 26 Mar 2026 17:18:11 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Javier Tia To: Sean Wang Date: Thu, 26 Mar 2026 15:09:40 -0600 Subject: Re: [PATCH v3 00/13] This series adds support for the MediaTek MT7927 (Filogic 380) combo Cc: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Ming Yen Hsieh , Deren Wu , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Marcin FM , Cristian-Florin Radoi , George Salukvadze , Evgeny Kapusta <3193631@gmail.com>, Samu Toljamo , Ariel Rosenfeld , Chapuis Dario , =?utf-8?q?Thibaut_Fran=C3=A7ois?= , =?utf-8?b?5byg5pet5ra1?= In-Reply-To: CAGp9Lzo1XPR7=Gwi_Qr9ZC=g4ec+zGg_eUdh8yBgUdi=qiHMag@mail.gmail.com References: 20260325-mt7927-wifi-support-v2-v3-0-5ca66c97a755@jetm.me CAGp9Lzo1XPR7=Gwi_Qr9ZC=g4ec+zGg_eUdh8yBgUdi=qiHMag@mail.gmail.com Message-Id: <20260326211811.C96EC1EA006B@mailuser.phl.internal> Hi Sean, On Wed, Mar 26, 2026 Sean Wang wrote: > This part patch 1-8 looks good overall. My only concern was a possible > regression on mt7925, but now that the incorrect mt7925 320 MHz > support has been fixed in the version, this should be fine. Thank you. Patch 5 also had a build error (is_320mhz_supported() called is_mt7927() before it was defined in patch 6). Fixed in v4 by using mt76_chip() directly. > I am still thinking a bit more about patches 9-11. My current > preference is to introduce the generic layer first, and then migrate > the mt7925 and mt7927-specific parts on top of it. > I will handle this part on my side, since I want to carefully compare > the vendor driver with your changes first, and make sure the mt7925 > side is solid before moving the mt7927-related changes forward. For > the mt7927-related work, I will make sure your contribution, as well > as the work from the other volunteers, is properly preserved when I > carry this forward. Understood. v4 drops patches 9-13 so you have full control over the DMA, HW init, band_idx, and PCI device ID enablement. Regarding your feedback on v3 patch 13 (CNM quirk) - you suggested folding the MT792x_FW_CAP_CNM force into mt792x_get_mac80211_ops() instead of the post-hoc memcpy. Since the PCI IDs patch is now part of your series, would you prefer to handle the CNM fix there as well, or should I send a standalone patch for it ahead of your DMA/init work? > Similar to the BT side, I would prefer to have a dedicated Linux > firmware for mt7927 WiFi. Noted. The driver currently requests mediatek/mt7927/ paths. Once a dedicated firmware is available we can adjust if needed. v4 sent with patches 1-8 + ASPM/PM disable (9 patches): https://lore.kernel.org/linux-wireless/20260326-mt7927-wifi-support-v4-v4-0-8ab465addcfe@jetm.me/T/#u Best, Javier