From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAC8839FCC4 for ; Mon, 6 Apr 2026 23:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775518995; cv=none; b=VHJzsejx4GIFW5oJzUkcUUXjMozE0LSCtwYolrZREbKz8i4SL/zRqG/78mJgaQsKMN5QVgT0syNglOKJCchyt9lpsuCMyNsJS3+9YEJSXhTnxosD6UuC+ouD2jK+ojmmfiJYmSnq+RUCkb6f082XLL4U3DC+nS2vSvXp9viuoRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775518995; c=relaxed/simple; bh=ES5Wx77hnfPJwf+p4gTlHwl/GrAofS3FOUzFe1CqPcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kDFuxl1T52lhDlH98HESLYbdtMH8Kt4buvVW5eaZbZ/ddh6M+yiwC3E/b7GfTZzTaZX6MGII1ObD+A/fB7IQIzZ0Lwfmvn8xbOxuNCPP3p1Z3SOwQTzb4HnEfR16Aa92i+WzF1AtVGfQNZr1fdNwrVjKLSLnO93Tlmplk0aGFvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cuIR1AHV; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cuIR1AHV" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-79ea87af213so79218067b3.0 for ; Mon, 06 Apr 2026 16:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775518992; x=1776123792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gKiu2zHNYp38GBjq5TVo1PRhtRMef2XaxqRl1STw6Cw=; b=cuIR1AHV7jlKoDPYpneaTLQVxL/7yusEX+r4MM3kixSEpq5wgjjQLsxr1W3JrvbrwO G5KG7vNVIbEsGsDgkBU4sst1EkOiwWck9QB37LRh28iI99P2eoh35Q5jzIEs05kjxJCD ORaIsRXMifN3nwdYGcvowX4ijuvgO2EPNbaHqlEt1Z6Z2mB5HsgmqJh8I6iAtpvBaSF1 wIqbuF8oxl1KGPP4vooHxl08G5//R5M1AHvjPhU70GBELcF0dG6ot2T7Skds5YS5gq7A dRhQVllNapnvjIBZVurVLts/MLHNp9fAT/KgIT1OY5Y3djZZcnt8UW0ovZRoJOtWgYxj 5NJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775518992; x=1776123792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gKiu2zHNYp38GBjq5TVo1PRhtRMef2XaxqRl1STw6Cw=; b=ZEz3y6kduUfEmztWK1lw3LGz9aPTam9CNbGGoFFUpUgSVXVl2g6OI4PymIjB8H5cqs pUppCOmlF+VE/aXygrxkWv2bGfSyaJCLYuychpgLAV8fyNgtmQwsa0lXPWVJxIIz0oXx 03iihJlrkgTH5E61XekBC4CdU4ubc/6kRqISMpMOl/2Ayy1NFfOQxfcAfGrpj2UMe429 /hBhL/+i2a/VBGD1sm/ILSq/PvEox4PJ55vwUxdflQOnTyTtFFR/kitRQExuP/MTx6q7 IqZ8IK1f6I78W4SKiku5g0MiQP8Ngs2W9BoWMEJ72QRXcT2HK1CbnXoqBi1FPJnIVVNO 3IqQ== X-Gm-Message-State: AOJu0YzT/woeT3un6w3M0tz3Zr5/HoZHU+MDTNym7gWEP3W9FmcQOOHq YnTpzSWPOO5Bhl8QqcpAezDXA67Kyf4lb6X7Jgpq/rnNXj9pitTLnKtTrVjg4Wvl X-Gm-Gg: AeBDievfmFneZKFsXJSmIOben/NY8cAuyWGLfbehN9QFkIhT3oxe+sEORM3R7fN1n5+ OnWvHQcXMrXKwDsTCOozvoPWygEj2wC9GxBWGA4vzSKaS5W4e8ggtIS7ydicdvZ/rD/BRXvK+HO um53AwwPrzw1AhrcNZF7p3c+6i/wZuWDXUrOzyCeqapo7vKOYtZiXOT3lLsRZRBnLa1Pvws6zYw w/coKIqbEvmf4/yJ5jr0DmmhFLwOrnDBMisI4FQMJNkB1uDlgaXP+GEl+1H302spelME3PhRjhh paTtciY+/1MLcSRyVnLmgW2l6R/vXPBd5nWNQLlZrhF1ZsD5vJslfjlGvrymEFuPvkrx32Z2BMF BlOwCJsDXkQstXqjpaSUUkTtuvTgU2GyU042v9cWNEcI5HVtRgrvxCF71XvflzjVEtbQKMIya1X mEbRauBWI/1+JhdPW0xlsTGv6MC6rnvx0Mf0C7mPAOWjdfSC+g86FmzEq8BsMe X-Received: by 2002:a05:690c:9c0a:b0:79a:b409:b5e0 with SMTP id 00721157ae682-7a3b8501632mr147407187b3.0.1775518991760; Mon, 06 Apr 2026 16:43:11 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a370df16aasm59144037b3.40.2026.04.06.16.43.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:43:11 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 2/2] wifi: mt76: mt7996: clear cipher state on key removal for WED offload Date: Mon, 6 Apr 2026 19:42:04 -0400 Message-ID: <20260406234205.29857-3-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234205.29857-1-joshuaklinesmith@gmail.com> References: <20260406234205.29857-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Same issue as mt7915: link->mt76.cipher is set on key installation but never cleared on removal. The WA firmware retains the stale cipher in BSS_INFO, sets the protection bit on WED-offloaded frames, and drops all plaintext traffic when encryption is switched to open/none. Reset link->mt76.cipher to zero and call mt7996_mcu_add_bss_info() when the last group key is removed. Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7996/main.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/main.c b/drivers/net/wireless/mediatek/mt76/mt7996/main.c index 84f731b387..bf5fda6925 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/main.c @@ -235,6 +235,21 @@ mt7996_set_hw_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, } else { if (idx == *wcid_keyidx) *wcid_keyidx = -1; + + if (!sta && link->mt76.cipher) { + struct ieee80211_bss_conf *lc; + + lc = link_conf_dereference_protected(vif, + link_id); + if (!lc) + lc = &vif->bss_conf; + + link->mt76.cipher = 0; + mt7996_mcu_add_bss_info(link->phy, vif, lc, + &link->mt76, + msta_link, true); + } + continue; } -- 2.43.0