From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82CEF3A257C for ; Mon, 6 Apr 2026 23:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519275; cv=none; b=KwOwN9ViyzUHp2Tb7nh7eCWvcvxyma2aoh7jgK/bcpdiZ/YE8tPh1E2XKhqFlwOdqqx0v3mzkECLHMzco7zel6E86w2I7cL0GGe3hCv5anKeQxi8bkdGRTZRxmeoDoTHh2LIj0bDJ2uXjHxBQrcubu3UBHONuD4nUI6kT/eZyfk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519275; c=relaxed/simple; bh=ypYe838aBMkoRP5LrhnDA0C7q+59eJdK7nUE9OS0I+c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZwL+rZuJ9TPTPFlTwrNQaQTznH0Tf9PBz2gU6GwMALEajK/1/JLANqvaxQbPDExQ4korHrxPGbAR3i49psUgVZfb3umwfMBxuEsZh/8m9ZyZD1yX84rJJ6aBcmMjqAsn4myov+9YgMDIF+YiD7aCY/YSVlrCpisySsL+/ZsTlAI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WIhHXCIk; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WIhHXCIk" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-7986e0553bdso42514657b3.2 for ; Mon, 06 Apr 2026 16:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775519273; x=1776124073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8KdrZYGFBLENkuuWfE8lxm9EDeQduu0FD0OZSAlkc/o=; b=WIhHXCIk2e7SGemfPLwSnwlbK46OFp561NMIx8VZunNfeHMvk7YzVnfXMQtfzkom1F c6DsqrNHVH0/w4wW9YdJauZNw7dMnu0LqgAxjVIr2yyji5t+xdrkjBg9dxdO2oLnWTMD vt+EAxE+VOCrCTLj8BAAG50e+8WMvZSY6o8+z2sudFs+PCPY517Wn88hUZ/mD3eA34xR VW55YMEv5msNz8LUP4dw6afKq7eHKpNb759AdOzwDMTxXsROzPDDLnGYlCxtA1vtHOgf uI+4nflQUbso8Xnrk2bHNPM0816a0US5gi3lOh3m444EWM6ohgGsvgmk75eTXXMiLe1e vY6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775519273; x=1776124073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8KdrZYGFBLENkuuWfE8lxm9EDeQduu0FD0OZSAlkc/o=; b=m9ZRjwptQwT/7mbFAhRetay0Lb4YnbHTolegW/sjJhBMkX3VBTMHcwKCpNUs36B07s BTKKXXCFHoUnIPnaxoiVbo1E8za7/Ce4ostQg52Z2ezHy9oS4MgvPNi3vHqYNlB789xK WJ11N7kF0Mi9g99t77TwfTb6jnKsUdgLJk8imd5BnhX0cZFxaSxaxe35Fefy5JGsq6UO W3s89gMGVe4T32hOLAF9TB488HmfgU0zb++2TOutMVX6MgMY1p/EEmtebCwN8QA9xFbn UINnxBGHG7oZF1ybcOWA8DBwaBbn+MUbUJt3/3DwggUaRi42MyKvi55lVpQ75x+YbXlW xl2Q== X-Gm-Message-State: AOJu0YxkJYvRyEXwn2dOijQiXgNzpBu5Ben8YKsrUlAXAKY0ClDgcGEl qeViC6zlgbYh+VCb6Sug0R2z7joj6bdsG/qpzBN8l8oj611kkDOVsLrewstJfBAH X-Gm-Gg: AeBDieualu3PCNCArH5CApZZclrPAGqf8qHOet8ufuSyr7HgMS5A/1ZBCE2+/3vbp6X FFF3apbnmuErMGV+UoJ2RYchQ1Mw4T2qTSttCsLbxBXgzgZUoYFpnO9ayHs+fSfsHnE91xYCmqt dJLJfonkQSOTJGcdMXc/v+BWCrViTdYwg9HLRfVHxyrfoaWyf/E6QT/uBqKKicG8rpVXKxPG8dr vK4Gl3v3Gs/Rc0SiMJnzAW6cmzu7fxk6wwuOJBgJBDoHFA+ESFXYuRMBy9UwW/lyPJ12bBrcY/s WHP+ygqLTX5sghboii94ymDekj9BG+07YctrHAo2VaqoE/2WVnSkpVZ2yXShfm4GP5T0josnItf enHHXiWx3+gqLhWQhlOVQPPo+OHrfixAYBkg8jaWvHrR7j45LgBi8J+9bXUCVxPHlcM0edOIklI kGSJFmx0S9MlZuLXHF/vZOKgTdNYTk2/Kj2H/I2Qhtk73M4TeAU6kbgL9qlJ/P X-Received: by 2002:a05:690c:e04f:b0:79a:c93f:4acb with SMTP id 00721157ae682-7a4d6449755mr121970347b3.54.1775519273502; Mon, 06 Apr 2026 16:47:53 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a36e42ff31sm59350177b3.6.2026.04.06.16.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:47:53 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 4/4] wifi: mt76: mt7925: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 19:47:39 -0400 Message-ID: <20260406234739.29926-5-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234739.29926-1-joshuaklinesmith@gmail.com> References: <20260406234739.29926-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt7925 chips") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7925/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mac.c b/drivers/net/wireless/mediatek/mt76/mt7925/mac.c index 6334019249..85e91ca84f 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mac.c @@ -144,7 +144,7 @@ static void mt7925_mac_sta_poll(struct mt792x_dev *dev) rssi[0] = to_rssi(GENMASK(7, 0), val); rssi[1] = to_rssi(GENMASK(15, 8), val); rssi[2] = to_rssi(GENMASK(23, 16), val); - rssi[3] = to_rssi(GENMASK(31, 14), val); + rssi[3] = to_rssi(GENMASK(31, 24), val); mlink->ack_signal = mt76_rx_signal(msta->vif->phy->mt76->antenna_mask, rssi); -- 2.43.0