Re: [PATCH 17/20] wifi: cfg80211: provide HT/VHT operation for AP beacon

Pablo MARTIN-GOMEZ
2026-04-15T15:22:37Z

On 15/04/2026 14:42, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> In addition to providing HE/EHT/UHR operation, also check
> and provide HT/VHT operation, so that drivers have it and
> can use it, e.g. to correctly calculate station bandwidth.
>
> Reviewed-by: Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> include/net/cfg80211.h | 4 ++++
> net/wireless/nl80211.c | 18 ++++++++++++++++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 7070e577342b..a40ab36b8edb 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -1398,6 +1398,8 @@ struct cfg80211_rnr_elems {
> * attribute is present in beacon data or not.
> * @ht_required: stations must support HT
> * @vht_required: stations must support VHT
> + * @ht_oper: HT operation element (or %NULL if HT isn't enabled)
Might be some nitpicking you can ignore, but HT operation element is optional when HT is enabled. With the current comment, someone might (wrongly) deduce that if `ht_oper` is NULL then HT is not enabled.
> + * @vht_oper: VHT operation element (or %NULL if VHT isn't enabled)
> * @he_oper: HE operation IE (or %NULL if HE isn't enabled)
> * @eht_oper: EHT operation IE (or %NULL if EHT isn't enabled)
> * @uhr_oper: UHR operation (or %NULL if UHR isn't enabled)
> @@ -1427,6 +1429,8 @@ struct cfg80211_beacon_data {
> bool he_bss_color_valid;
>
> bool ht_required, vht_required;
> + const struct ieee80211_ht_operation *ht_oper;
> + const struct ieee80211_vht_operation *vht_oper;
> const struct ieee80211_he_operation *he_oper;
> const struct ieee80211_eht_operation *eht_oper;
> const struct ieee80211_uhr_operation *uhr_oper;
[...]
Pablo MG