On Wed, 15 Apr 2026 13:54:31 +0200 Jonas Gorski wrote: > On Wed, Apr 15, 2026 at 1:44 PM Joshua Peisach wrote: > > It does appear to be similar - even the current brcm80211. So much so > > that I sometimes need to think about whether b43 is actually a > > duplicated driver. > > > > Since b43 is in an orphan state, I thought it would be a great place to > > start for kernel development. 5G doesn't work on that iMac, some of the > > PHYs, like the AC PHYs appear to be incomplete - it felt reasonable. > > > > Because I'm one of those "there's always room for improvement people", > > I was going to try to improve the driver, filling out TODOs, fixing > > hardcoded register numbers, etc. But if it's best left alone.. then I > > guess we can do that. > > > > That is, assuming b43 is actually supposed to be a separate driver, > > because if brcmsmac basically has the same code, then maybe we should > > focus to centralizing everything? But then there's b43legacy.. hm... > > It is/was intentionally a separate driver: Broadcom didn't want to > maintain support for obsolete chips (anything SSB, anything older than > BCM43224), so the decision was to have b43 support all the "legacy" > chips, while brcm80211 supports everything never. Since they were both > based on the same driver, they are (more or less) the same > architecture. > > But now that Broadcom has essentially abandoned the softmac part of > brcm80211 since several years, I don't think there would be many > objections on unifying it with b43. The hardest part in the b43 development always was not to break already working stuff. There are many different types and revisions of the hardware out there. Probably in the order of many dozens of variants. Please keep in mind that changing code means mostly testing. Which is hard, if you don't have the hardware variants and basically no users exist anymore. Just implementing random TODOs and missing pieces will break things. (e.g. not doing some HW calibration or workaround might be better than only partially doing it or doing it wrong). I would personally not touch this thing anymore, except for security fixes and such. But if you want to work on the code, long term, I would welcome that. We could even arrange that I ship you some hardware. But keep in mind, it's all almost 20 years old legacy stuff. -- Michael Büsch https://bues.ch/