On Wed, 15 Apr 2026 13:04:40 -0400 "Joshua Peisach" wrote: > Well, if the regression risk is that high, then I guess I'll let it be. > Sure. I might just make sure everything is using register definitions > instead of hardcoded values, but then leave it there. I mean, I don't want to discourage you from doing anything, but I just wanted to point out that this is a lot more work than just implement a TODO here and there. For most of the code we don't really know what it does exactly. That may change a bit, if you pull over some code from the newer drivers. But I don't think the situation will improve fundamentally. > So I guess this driver just sits here.. not quite pointless to be > removed from the main tree, but not quite worth the effort to bring it > up to speed. Well, it probably still works well on the (few) devices it worked well on, because it basically hasn't changed. There are many devices which were never supported at all or were never supported properly. It's not that just your device is missing to complete the perfect picture :-) There might be better uses of your time than working on this legacy stuff. For example working on the microcode reverse engineering and tools and get them updated for the current generation of devices is probably much more useful. And I think much more fun, too. Or something else altogether. -- Michael Büsch https://bues.ch/