From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D73631985D for ; Fri, 24 Apr 2026 21:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777066641; cv=none; b=auL2w0eBBm9F55x42QD1g0Xtts1K13FDjA2aoCvaEVFkBZas3zjx6L2YCSWWglH19ymhTn9dPsDcg93nbZOS0qKRphKso0QcEw0cwHcNwTw5ISnVSnv6mqoRhIicZG7IZxu9gfVkcUgkXUZmoIVzEhsQd5NMV/1+wFXNUYGMp94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777066641; c=relaxed/simple; bh=id1+Z0RiZnu9fcpdygHTv8Hyka13BoEKIX1ryJU4/AU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LWgOttN8iAyDeGUDxa9MRISTEd7NqL58aSZuB0VqJOu8HIZ8nfEGh6lssiedju0GXogdOiJRkMWHasn5XLANVHEfrQM1jd3jRZssUjWMH5aEr5GCK1zIALzfPdZCDoLP/crIO5twTxRfqIwqJC9OD3be7txlsT2xdU5+b5Be3K0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=elJ7JsCX; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="elJ7JsCX" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488a8ca4aadso113948075e9.3 for ; Fri, 24 Apr 2026 14:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777066639; x=1777671439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1ykeieCQiiUZi3J/2eeufITWyJmr5d8BX3l3RZUjInI=; b=elJ7JsCXqJWdvJle66uJiCMSLgrZivJZQPqvHT4akq6ynIrF3JAgq4mnxu4Uldqux4 o3I/nDQBUtCVvt/YtDSGFbETohJ2ZKIonzDsMw9xgSt8kO+SzM2fWx0LjlOUr3kIj2bI 4sVcyluttCkHiI0LgAq2e6JWRgrZOA7/u98ec6iic+yaYZo76QRDrYhwrNHAGgYj01pG oZ2caMsOXZdOic6AzK/dGarNuw2sMbil2PLjwEw/Jp05/QMgNPdjWS7mf9smswjbZ0z7 F7vNG3QDUs4jgo9/EXZWksIJO1YeqOJbBuBmr68UjYC5LQrSwPvwQ6I5lykr0uVEtJU/ RlOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777066639; x=1777671439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1ykeieCQiiUZi3J/2eeufITWyJmr5d8BX3l3RZUjInI=; b=evHBGtSYA0qkx/lp/uG4aY4x/8eOHqw1Y/BtlCKEjGlgY8/rOMxoWUlxybGqs8qg81 Yuipi0g2CVNsgUQ+k4XlP5foL/yb1ULrVmbIt1SYNQUQWOD8MumgTeKyD/dOQLK3zFey TKXFR+rpPSbhvkU34f0Y/Z8OrrTsPeJC41M08ShqJeZUfFuwhTA2NzNf7HDo32mBw9jv YM2PtAv45BJcEXoI4v24Tj74lxC2LRzK16nfcsRKJbdds9/TdUB30NXqdR6w0AizGmpV UomR1pTbt9PD90uXw3jP7TUs509UziofsneU9YcSJMUBps56FcVmM5rumt+fMSxaXWbU EI1g== X-Forwarded-Encrypted: i=1; AFNElJ+q8cPjfKFKyqIsGkGyRFepBiRgWvH5+Wl3g3pKcuS0mLTczG6pHRF3A5wtM+7soXD88gusCN1wAoHY4kH+7w==@vger.kernel.org X-Gm-Message-State: AOJu0YxVLIG08BJYScY3HT9C8UZceYe5WLYUun3QdWzktQvGSscM/axF v+hniKmShqibj2hX381eF89LjGq/jJktRgDrTFVGbbHL29xp/IvwkTsm X-Gm-Gg: AeBDieugR+UMobR3ncKMG0X7oNwlCv/zY0bBuVvw4yWMlbDtkzJC+Vj6TXJIdExVAZ8 Lrskn2HGAaHCQbdF/KWTi+MoFdVcc33uwDqR0lQgVF+mRoZFxF2SyPjJMwwx517jUjv/GRXiH7m HCFVasm0zilU1qT+aS5b0jXl+9GcV3JzXG4GDfIqKjU64wcHgWZfs9TPkHfXLxEuA1Aqr6FKiKH gba4Ka+/sOy6u+Q9kT54qeJCTywQnQD9bhDaT4t8Sn4xa/3pwIQAMf1ya9LY+k1RXimZ/hCfA33 pSE4ul3202tooNLZ80/20+2kDt2U97S1kS0kGX2wruNymnx8O15yPW3fZdp6mN6QoHIKaBartRw gYcBYLcg2qmNuqQJaqmJoxyWB+7ZJA7C3WI/jllebcQ1kSxC4HgBvU/IHzmm+46niv2mdpdr0FX rAEDESepDj/ZS7aN3NQ4e5YwQyUhPP1oTupO6ZNXaxu48qrguatZuAEd734TVoo2/HnsUoCjZjZ FM= X-Received: by 2002:a05:600c:37c4:b0:48a:5501:7995 with SMTP id 5b1f17b1804b1-48a55017b71mr283475335e9.18.1777066638544; Fri, 24 Apr 2026 14:37:18 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a5aa3ae83sm424493425e9.12.2026.04.24.14.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 14:37:18 -0700 (PDT) Date: Fri, 24 Apr 2026 22:37:15 +0100 From: David Laight To: Yury Norov Cc: Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH 1/9] bitfield: add FIELD_GET_SIGNED() Message-ID: <20260424223715.077288e8@pumpkin> In-Reply-To: References: <20260417173621.368914-1-ynorov@nvidia.com> <20260417173621.368914-2-ynorov@nvidia.com> <6170788fcab2ec835597e3d7411928d36850c20a.camel@sipsolutions.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 24 Apr 2026 12:35:51 -0400 Yury Norov wrote: ... > > Any chance it'd be simple to generate u32_get_bits_signed() etc.? Could > > be especially useful for le32_get_bits_signed() for example, to have the > > endian conversion built-in unlike FIELD_GET_SIGNED(). > > Maybe this: > > x = FIELD_GET_SIGNED(mask, le32_to_cpu(reg)) But if you are going to follow it by: x1 = FIELD_GET_SIGNED(mask1, le32_to_cpu(reg)) you really want to to the byteswap once, best as: reg = le32_to_cpu(struct->member); David > > Thanks, > Yury >