From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EEEC1B6CE9 for ; Sun, 3 May 2026 01:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777772369; cv=none; b=P+FzNkvebnYVE7YxR3TvRDIGP2SE2IJ/ihEjPk95n87ujCyQlCbH7OC74X2poMnYFR3RmoJlhPoKYNfMkj6gmO5/1SAGr4sQZQsPZH9K0lmAH8MGkKAnEB7EnTGHCPekGb9sSC2mSFBEtoKx78KfCI/iwL1BZZhoJr90eIn7iQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777772369; c=relaxed/simple; bh=YPGmyUudNSjw4eCk1z0v7TQxyamgkewkjdMSqZfW3uA=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=nVw2iRFk/D+SHjtpSJL9OiXVxfK5++xEftdtiNAmWZ7m+GfMZskB32gR+7zPmIT1wQ2oDvJH5zFZjfR5WJEXkkVr7Yc0QSiQHFAMJXdfbmpxOaqz7emCcsjgC6xU/2YTKuFeQLaCb9czk/h06qpFVzzR3d037kvn4Hx2qzIrPIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fSh9Ys5B; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fSh9Ys5B" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-bb962ce4dcfso482281766b.1 for ; Sat, 02 May 2026 18:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777772367; x=1778377167; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=5/hy9Op5MH/n5HzPINkQe6Hw6Gmq5KhiDMLcdOYjsuM=; b=fSh9Ys5BcgAl5CLabGjWPlQUp5rxxRCnk0okIi30Loi2w/rixHaaY+uXEVa28DksGk BNELSaImrzo9MXGK5UolmnFc6W61kv8lfJAaks/JlJeizh+k3vuEm1HfDFFwlh6I7gLg LaYYX+Sx1O2eSbQgt8iU8tYTNjF9v31ITGcDrYL+cZF1NKZxaQwrxulzRHOIRCVh16AL GvMoJ7LZx43il/5wDHpf6VCixBR+f1XoX76AkBxueI8Oo38gGWU9Y2U+sy/c2syiHyS3 z3ZglNEfFbaqV02JHSXqJmVKsBxdoALXGhUT7C4aQkue0TTxkGTXdwLoitxom4c7/djV SzjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777772367; x=1778377167; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5/hy9Op5MH/n5HzPINkQe6Hw6Gmq5KhiDMLcdOYjsuM=; b=kZGgZ7CqzH/LMZ3rur2yYFRKvS/oTCbCfj+X2Wh8ZBkgBOs8fHTlsZodzaMdo5hcKb t2/V5pr4nb6+uAVN14Ku4b2bVaVo/Zgkp6o8GTqkwb2P/Kieou5xkSNg5IxTDdJTjEjG EYeK64IDD88AzfdLSmFKllQQjTTh++3rAJePpOCt/EVoWqo/9zk6JLeGD2nKIWJwIVAD Hd3sjtLwS7nLvtgnUD+/NTh+wQDTmiR75qn2VNAEo4PVCD5oiA4Gf7nLI27GejX8yuNo Qb3HYzPVrU2TiKZ7GeLZPRbeDszymAH1wSvWvYDeGrYP5m8s5NFN6vgaO3RA0EDUq710 uujg== X-Gm-Message-State: AOJu0YziFuIdVvbhQy4/5EEfSZCZzbD8qoVN17Bu2ee5PlJWeTesTp0Y lCnqjWoc5c668bd1mn4g+0pgoF+uYelvND6F0RMGFrI11KXbadfk4ubY+Ji0KYh2 X-Gm-Gg: AeBDieu89sXJWPXryHtAKOhY7/EochmNUC6KCKM8bVUYOCdApy2cjS2ex32Q/FNJMA3 CRielTEQQMI8+GF4fZPq2vzIi1GgnfLgM+/8CI0kgjI/K+CzVBq9JG1sANoQs0sZtKXIvzJMe5d U3f9EVYR8iNWUV/fT3QrHF/tr1t/ujrBvhxAvX1Pjkj/LexZh+xZltbz42Ps6DBNqAlG7yd4yH0 j4GBFP34GPxWSXO23mVKz1HllnAv9RLJcY3du2seNwG/T7LBo3f9ZDzFGjdv98q9utGklbtJQZ3 rjL0U3uClJgY6GJ/2FE2huQBCekMAsIV9ky0QwSQn/rSNP/qmD6G43/ig155PSvlcU5w2jOkXJj WorHg2w/07SMv5XvdiHNYSlVU8I1/fEpDO3+cR9Y0rRUCPPu4NyKOth2KKhxppVdBGvtBxzXfEj PdqWdNFr7QNkeJrALt2UMlVVojFJcNty+osub62HhopwA7nVBs6OFhrTiSowExYvr1xWqeW83Yy EpmnEq/i8BZg6hN9JL/cHTdldmt37JHA/zWgFE= X-Received: by 2002:a17:906:9f87:b0:ba1:1181:b773 with SMTP id a640c23a62f3a-bbffa336011mr224803366b.10.1777772366373; Sat, 02 May 2026 18:39:26 -0700 (PDT) Received: from KURWA.angora-ide.ts.net (mm-39-71-126-178.vitebsk.dynamic.pppoe.byfly.by. [178.126.71.39]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bc1671c1d3esm24796466b.42.2026.05.02.18.39.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 May 2026 18:39:25 -0700 (PDT) From: ElXreno Subject: [PATCH 0/2] wifi: mt76: fix TDLS direct-link on MediaTek MT7925 Date: Sun, 03 May 2026 04:38:29 +0300 Message-Id: <20260503-mt7925-tdls-fixes-v1-0-dde847e21081@gmail.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIABWn9mkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDUwNj3dwSc0sjU92SlJxi3bTMitRiXcMUQ2NLcxMjA0sDAyWgvoKiVLA EUFt0LIRfXJqUlZpcAjJIqbYWAK4p9jx1AAAA X-Change-ID: 20260503-mt7925-tdls-fixes-1d1397420900 To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Soul Huang , Ming Yen Hsieh , Deren Wu Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org, ElXreno X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3364; i=elxreno@gmail.com; h=from:subject:message-id; bh=YPGmyUudNSjw4eCk1z0v7TQxyamgkewkjdMSqZfW3uA=; b=owJ4nJvAy8zAJXa0WDmKX5v/EeNptSSGzG/LfatSrcLPN15++MYthFUoRjl0P9uFBxs3mHG9s t3u1fv3xrmOUhYGMS4GWTFFFp5ze2tzltUtmVzPlQEzh5UJZAgDF6cATGRnEyPDqa45L/1ZclJ/ /9llq7hf+zqzQ2gHy6bMwgdSfMtWLRHdwfBXqCrhlfWsxyXsGw3No7YdPOWXz7twtWi41hQxt1u f7yUxAgBO/EcD X-Developer-Key: i=elxreno@gmail.com; a=openpgp; fpr=0CCEBD7D6CA67EA4937F0A68C573235A0F2B0FE2 This series fixes two TDLS-related issues on the MediaTek MT7925 (Connac3) Wi-Fi 6E chip, observed reproducibly with Samsung phones and other peers that auto-initiate TDLS direct links. Patch 1 works around a TDLS direct-link issue on MT7925: QoS Data frames whose destination WCID is a TDLS peer are silently dropped after submission to firmware via the HW_80211_ENCAP TX path. mt76 advertises WIPHY_FLAG_SUPPORTS_TDLS via the shared mt76_register_phy_helper(), but does not provide TDLS-aware firmware-facing peer setup -- no CONNECTION_TDLS constant in mt76_connac_mcu.h, no STA_REC_TDLS TLV, no TDLS bit in mt76_wcid_flags, no TDLS-specific handling in mt7925_mac_write_txwi_8023(); the proprietary out-of-tree MediaTek driver carries an explicit cfg80211_tdls.c with no in-tree equivalent. Whether the underlying gap is in the firmware HW_ENCAP path or in mt76's missing TDLS-aware setup is unclear from the kernel side; the software-encap path sidesteps it either way. This patch stops advertising SUPPORTS_TX_ENCAP_OFFLOAD and SUPPORTS_RX_DECAP_OFFLOAD in mt792x_init_wiphy(); mac80211 then takes the software 802.11 encap path, which submits already-formed 802.11 frames via a different firmware path that handles all WCIDs correctly. Verified on mt7925e at 5 GHz HE 80 MHz and 2.4 GHz 802.11n; TDLS direct link sustains ~750 Mbit/s and ~130 Mbit/s respectively. The disable is applied to the shared mt792x_init_wiphy() and so also covers the Connac2 family (mt7921/22/20/02), which uses the same firmware HW_ENCAP path; if Connac2 is later confirmed unaffected, the disable can be narrowed with is_mt7925(). Patch 2 fixes a regression introduced by the MLO refactor in commit 3878b4333602 ("wifi: mt76: mt7925: update mt7925_mac_link_sta_[add, assoc, remove] for MLO"): the cleanup loop in mt7925_mac_sta_remove_links() unconditionally calls mt7925_mcu_add_bss_info(..., enable=false) for every link of the station being removed, including TDLS peers on a STATION vif which share the AP's bss_conf -- wiping the AP-side rate-control context on every TDLS teardown and collapsing rx bitrate to 6 Mbit/s for tens of seconds. --- To: Felix Fietkau To: Lorenzo Bianconi To: Ryder Lee To: Shayne Chen To: Sean Wang To: Matthias Brugger To: AngeloGioacchino Del Regno To: Soul Huang To: Ming Yen Hsieh To: Deren Wu Cc: linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org base-commit: 7baf5857e15d722776898510a10546d6b2f18645 --- ElXreno (2): wifi: mt76: mt792x: disable HW TX/RX encap offload to fix TDLS direct-link wifi: mt76: mt7925: don't disable AP BSS when removing TDLS peer drivers/net/wireless/mediatek/mt76/mt7925/main.c | 10 ++++++++++ drivers/net/wireless/mediatek/mt76/mt792x_core.c | 10 ++++++++-- 2 files changed, 18 insertions(+), 2 deletions(-) --- base-commit: 7baf5857e15d722776898510a10546d6b2f18645 change-id: 20260503-mt7925-tdls-fixes-1d1397420900 Best regards, -- ElXreno