Linux wireless drivers development
 help / color / mirror / Atom feed
From: Minxi Hou <houminxi@gmail.com>
To: cole@unwrap.rs
Cc: linux-wireless@vger.kernel.org, greearb@candelatech.com,
	miriam.rachel.korenblit@intel.com, johannes@sipsolutions.net,
	Minxi Hou <houminxi@gmail.com>
Subject: Re: [PATCH v3 3/3] wifi: iwlwifi: mld: skip TX when firmware is dead
Date: Wed,  6 May 2026 18:39:07 +0800	[thread overview]
Message-ID: <20260506103907.1783441-1-houminxi@gmail.com> (raw)
In-Reply-To: <20260420174406.128254-4-cole@unwrap.rs>

On Mon, 20 Apr 2026 10:44:06 -0700, Cole Leavitt wrote:
> When firmware encounters an error, STATUS_FW_ERROR is set but the
> mac80211 TX path continues pulling frames from TXQs. Each frame
> fails at iwl_trans_tx() which checks STATUS_FW_ERROR and returns
> -EIO, but iwl_mld_tx_from_txq() keeps looping over every queued
> frame. This burns CPU in a tight loop on dead firmware and can
> cause soft lockups during firmware error recovery.

I can confirm this on BE200 with a tproxy VPN daemon that keeps many
concurrent TCP flows open.  A firmware NMI causes 22-30 second
system-wide soft lockups affecting 11-34 CPUs.

Setup:
  Intel BE200 Wi-Fi 7 [8086:272b] rev 1a
  Firmware 101.6e695a70.0 (gl-c0-fm-c0-c101.ucode)
  Kernel 6.19.12-200.fc43.x86_64 (Fedora 43)
  Driver: iwlmld
  Workload: tproxy daemon (Go, ~50 goroutines doing TCP write())

Reproducer:
  echo 1 > /sys/kernel/debug/ieee80211/phy0/iwlwifi/iwlmld/fw_nmi

The call trace consistently shows goroutines spinning in:

  write() -> tcp_sendmsg -> __dev_queue_xmit -> ... ->
  iwl_mld_tx_from_txq -> iwl_mld_tx_skb

carrier stays 1 throughout the entire crash, so mac80211 never
stops queuing frames.  The lockup resolves only after iwlwifi
completes the firmware SW reset (~22-30s).  Firmware occasionally
crashes again within 15 seconds of restart, causing cascading
lockups.

This matches exactly what your patch addresses.

Regards,
Minxi Hou

      reply	other threads:[~2026-05-06 10:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 17:44 [PATCH v3 0/3] wifi: iwlwifi: mld: stability fixes around firmware error recovery Cole Leavitt
2026-04-20 17:44 ` [PATCH v3 1/3] wifi: iwlwifi: add STATUS_FW_ERROR guards to NAPI/TX-notif paths Cole Leavitt
2026-04-20 17:44 ` [PATCH v3 2/3] wifi: iwlwifi: mld: fix TSO segmentation when AMSDU is disabled Cole Leavitt
2026-04-20 17:44 ` [PATCH v3 3/3] wifi: iwlwifi: mld: skip TX when firmware is dead Cole Leavitt
2026-05-06 10:39   ` Minxi Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260506103907.1783441-1-houminxi@gmail.com \
    --to=houminxi@gmail.com \
    --cc=cole@unwrap.rs \
    --cc=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox