From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx4.wp.pl (mx4.wp.pl [212.77.101.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 250AA3DDDC3 for ; Mon, 18 May 2026 07:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.77.101.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779090066; cv=none; b=l9hRrkZTA0cXS2sM5ltngCYA/r79vFgUtklNUT/GyDWyrfQusE7F7oCVBtOyznLq4BJtQPjVG3Tkc7GvLpaMfDm1Czavz2QdfK9TY8dyVFGfcfiqFPC0B+G7m806LJhdvolYQKSO/DucZLs+zKyxTGh2RHIP9KT6UxOwTQpAGKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779090066; c=relaxed/simple; bh=+t7eCfHcu99uc/1gojh87pyUWrkEoYqEbDEsnP8cOTA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eNsRo8Yr5FpAYhMvWuYP5S6J6sJ3m/EwdkaB+1AyRc0Ky/opZU24UUz8v9jgJpWVS7ODKBzd3V6Ju/eKv6Y5LhZ+mPYXftBIlK3BQPlDeNtGDvO5OId7K4DToa5oda4MbnTLnv/3ciBGE9oaU8J2ZCMpM5ssCznoz6a4B5RGA+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl; spf=pass smtp.mailfrom=wp.pl; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b=EEWov21j; arc=none smtp.client-ip=212.77.101.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wp.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b="EEWov21j" Received: (wp-smtpd smtp.wp.pl 30207 invoked from network); 18 May 2026 09:40:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=20241105; t=1779090055; bh=HYgurHUU4+knRgMSE8vU6X7ApzfW3qHKdUoHfCKhVRs=; h=From:To:Cc:Subject; b=EEWov21jQZeVL0UYxkkUkyEaIK9CJBW5PhGMRGLejvAMFMx9tJO2+r1M7jsxokQDm hJuJcTmhxsMmizt4YeliIr0kylCUoEbWWKK/+U0MvmFnwsTNDh55kwnhTvq8Y4hdaR 8n7YXlECR0PR4KnE30Hzaw52W/4mQKe/rm+0TlRRAl0XS+7B9ETEQ2Ik3oH0wPWFw/ oBbimc7HJf7VtGjONGLpFZQSJv3SNF6CeJ7G5EBSEZ5GsJWzaPOlc68itLJc8mUDqd MHFCeIna2uwJIIuMhN8jl/dtJdcBYAhcE3ykfeFTApWY3BC+YR/1WIhmiCMXEIx7Gv w+/m3G0oL79BA== Received: from 77-236-5-199.static.play.pl (HELO localhost) (stf_xl@wp.pl@[77.236.5.199]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with TLS_AES_256_GCM_SHA384 encrypted SMTP for ; 18 May 2026 09:40:55 +0200 Date: Mon, 18 May 2026 09:40:54 +0200 From: Stanislaw Gruszka To: Rosen Penev Cc: linux-wireless@vger.kernel.org, open list Subject: Re: [PATCH wireless-next] wifi: rt2x00: Allocate LED names dynamically Message-ID: <20260518074054.GA20466@wp.pl> References: <20260517231759.56638-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260517231759.56638-1-rosenp@gmail.com> X-WP-MailID: ac132383b09a213990f7798b1bab3ac7 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [MaMx] Hi, On Sun, May 17, 2026 at 04:17:59PM -0700, Rosen Penev wrote: > The rt2x00 LED registration path builds LED class names from the > driver and wiphy names. A fixed stack buffer can truncate those names > before they are passed to the LED core. To properly justify the change you'll need to provide real world example when the size is not sufficient. > Allocate each LED name with kasprintf(), check allocation failures, and > release the stored name when the LED is unregistered. > > Assisted-by: Codex:GPT-5.5 > Signed-off-by: Rosen Penev > --- > .../net/wireless/ralink/rt2x00/rt2x00leds.c | 30 ++++++++++++++----- > 1 file changed, 23 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00leds.c b/drivers/net/wireless/ralink/rt2x00/rt2x00leds.c > index f5361d582d4e..8818e0b2447b 100644 > --- a/drivers/net/wireless/ralink/rt2x00/rt2x00leds.c > +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00leds.c > @@ -100,6 +100,8 @@ static int rt2x00leds_register_led(struct rt2x00_dev *rt2x00dev, > > retval = led_classdev_register(device, &led->led_dev); > if (retval) { > + kfree(name); > + led->led_dev.name = NULL; > rt2x00_err(rt2x00dev, "Failed to register led handler\n"); > return retval; > } > @@ -111,15 +113,19 @@ static int rt2x00leds_register_led(struct rt2x00_dev *rt2x00dev, > > void rt2x00leds_register(struct rt2x00_dev *rt2x00dev) > { > - char name[36]; > + char *name; > int retval; > unsigned long on_period; > unsigned long off_period; > const char *phy_name = wiphy_name(rt2x00dev->hw->wiphy); > > if (rt2x00dev->led_radio.flags & LED_INITIALIZED) { > - snprintf(name, sizeof(name), "%s-%s::radio", > - rt2x00dev->ops->name, phy_name); > + name = kasprintf(GFP_KERNEL, "%s-%s::radio", > + rt2x00dev->ops->name, phy_name); > + if (!name) { > + retval = -ENOMEM; > + goto exit_fail; > + } This is overengineering. If needed, the name size can be increased. Regards Stanislaw > > retval = rt2x00leds_register_led(rt2x00dev, > &rt2x00dev->led_radio, > @@ -129,8 +135,12 @@ void rt2x00leds_register(struct rt2x00_dev *rt2x00dev) > } > > if (rt2x00dev->led_assoc.flags & LED_INITIALIZED) { > - snprintf(name, sizeof(name), "%s-%s::assoc", > - rt2x00dev->ops->name, phy_name); > + name = kasprintf(GFP_KERNEL, "%s-%s::assoc", > + rt2x00dev->ops->name, phy_name); > + if (!name) { > + retval = -ENOMEM; > + goto exit_fail; > + } > > retval = rt2x00leds_register_led(rt2x00dev, > &rt2x00dev->led_assoc, > @@ -140,8 +150,12 @@ void rt2x00leds_register(struct rt2x00_dev *rt2x00dev) > } > > if (rt2x00dev->led_qual.flags & LED_INITIALIZED) { > - snprintf(name, sizeof(name), "%s-%s::quality", > - rt2x00dev->ops->name, phy_name); > + name = kasprintf(GFP_KERNEL, "%s-%s::quality", > + rt2x00dev->ops->name, phy_name); > + if (!name) { > + retval = -ENOMEM; > + goto exit_fail; > + } > > retval = rt2x00leds_register_led(rt2x00dev, > &rt2x00dev->led_qual, > @@ -182,6 +196,8 @@ static void rt2x00leds_unregister_led(struct rt2x00_led *led) > led->led_dev.brightness_set(&led->led_dev, LED_OFF); > > led->flags &= ~LED_REGISTERED; > + kfree(led->led_dev.name); > + led->led_dev.name = NULL; > } > > void rt2x00leds_unregister(struct rt2x00_dev *rt2x00dev) > -- > 2.54.0 >