From: Miri Korenblit <miriam.rachel.korenblit@intel.com>
To: linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: [PATCH v3 iwlwifi-next 01/15] wifi: iwlwifi: mld: don't flush async_handlers_wk when canceling notifications
Date: Tue, 19 May 2026 09:39:56 +0300 [thread overview]
Message-ID: <20260519064010.549003-2-miriam.rachel.korenblit@intel.com> (raw)
In-Reply-To: <20260519064010.549003-1-miriam.rachel.korenblit@intel.com>
iwl_mld_cancel_async_notifications does 2 things: it purges the list of
notifications and flushes the async_handlers_wk.
We call iwl_mld_cancel_async_notifications after we stopped or suspended
the fw. So in that stage we don't expect any new notification coming,
and if erroneously there are new notifications coming, the work will be
queued again anyway, so the flush is pretty much pointless.
iwl_mld_cancel_async_notifications will need to be called in a context
w/o the wiphy lock held, and the only reason why this function requires
the lock being held is for flushing the work.
Remove the flush.
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Link: https://patch.msgid.link/20260517100550.70dddca96191.I06d3c6433ec22f81f2fb3fb2ee43881e662c5212@changeid
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
---
drivers/net/wireless/intel/iwlwifi/mld/notif.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mld/notif.c b/drivers/net/wireless/intel/iwlwifi/mld/notif.c
index d7383022a0ed..7574689e4088 100644
--- a/drivers/net/wireless/intel/iwlwifi/mld/notif.c
+++ b/drivers/net/wireless/intel/iwlwifi/mld/notif.c
@@ -694,10 +694,6 @@ void iwl_mld_cancel_async_notifications(struct iwl_mld *mld)
{
struct iwl_async_handler_entry *entry, *tmp;
- lockdep_assert_wiphy(mld->wiphy);
-
- wiphy_work_cancel(mld->wiphy, &mld->async_handlers_wk);
-
spin_lock_bh(&mld->async_handlers_lock);
list_for_each_entry_safe(entry, tmp, &mld->async_handlers_list, list) {
iwl_mld_log_async_handler_op(mld, "Purged", &entry->rxb);
--
2.34.1
next prev parent reply other threads:[~2026-05-19 6:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 6:39 [PATCH v3 iwlwifi-next 00/15] wifi: iwlwifi: updates - 2026-05-16 Miri Korenblit
2026-05-19 6:39 ` Miri Korenblit [this message]
2026-05-19 6:39 ` [PATCH v3 iwlwifi-next 02/15] wifi: iwlwifi: mld: purge async notifications upon nic error Miri Korenblit
2026-05-19 6:39 ` [PATCH v3 iwlwifi-next 03/15] wifi: iwlwifi: bump maximum core version for BZ/SC/DR to 105 Miri Korenblit
2026-05-19 6:39 ` [PATCH v3 iwlwifi-next 04/15] wifi: iwlwifi: mld: skip MLO scan trigger when AP has no QBSS Load IE Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 05/15] wifi: iwlwifi: mld: keep healthy link on EMLSR missed beacon exit Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 06/15] wifi: iwlwifi: move pcie content to pcie internal transport Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 07/15] wifi: iwlwifi: move iwl_trans_activate_nic to iwl-trans.c Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 08/15] wifi: iwlwifi: Add names for Killer BE1735x and BE1730x Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 09/15] wifi: iwlwifi: clean up location format/BW encoding Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 10/15] wifi: iwlwifi: fw: move struct iwl_fw_ini_dump_entry to dbg.c Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 11/15] wifi: iwlwifi: fw: separate ini dump allocation Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 12/15] wifi: iwlwifi: fw: dbg: always use non-tracing PRPH access Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 13/15] wifi: iwlwifi: fw: separate out old-style dump code Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 14/15] wifi: iwlwifi: dbg: remove unused 'range_len' arg from dump Miri Korenblit
2026-05-19 6:40 ` [PATCH v3 iwlwifi-next 15/15] wifi: iwlwifi: transport: add memory read under NIC access Miri Korenblit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519064010.549003-2-miriam.rachel.korenblit@intel.com \
--to=miriam.rachel.korenblit@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox