Linux wireless drivers development
 help / color / mirror / Atom feed
From: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
To: helgaas@kernel.org
Cc: Ryder.Lee@mediatek.com, alex@shazbot.org, bhelgaas@google.com,
	jtornosm@redhat.com, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org,
	lorenzo@kernel.org, nbd@nbd.name, sean.wang@mediatek.com,
	shayne.chen@mediatek.com
Subject: Re: [PATCH v3] PCI: Disable broken FLR on MediaTek MT7925
Date: Fri, 22 May 2026 08:48:53 +0200	[thread overview]
Message-ID: <20260522064854.201976-1-jtornosm@redhat.com> (raw)
In-Reply-To: <20260521161932.GA167656@bhelgaas>

Hello Bjorn,

Thank you for the feedback.

> How do we know the device is an "undefined state"?  Does it just not
> respond to config accesses?  Is there something in dmesg that shows
> the problem?
> I suppose it's similar to 81f64e925c29 ("PCI: Avoid FLR for Mediatek
> MT7922 WiFi")?
> I guess I'm just looking for some text more specific than "undefined
> state".
You're right, "undefined state" is too vague.
I can prepare v4 with what I've seen is happening . The
symptoms are similar to MT7922 but not identical:
  **First VM start (works fine):**
    mt7925e 0000:08:00.0: ASIC revision: 79250000
    mt7925e 0000:08:00.0: WM Firmware Version: ____000000, Build Time: 20260106153120
  **After force reset/VM crash (FLR attempted, firmware communication broken):**
    mt7925e 0000:08:00.0: ASIC revision: 79250000
    mt7925e 0000:08:00.0: Message 00000010 (seq 1) timeout
    mt7925e 0000:08:00.0: Failed to get patch semaphore
    (Repeats 10 times with increasing seq numbers)
    mt7925e 0000:08:00.0: hardware init failed
Unlike MT7922 which shows config read failures, MT7925e config reads work
correctly after FLR (lspci shows all capabilities). However, firmware
communication is broken - the driver cannot acquire the patch semaphore
needed for firmware initialization. The device remains broken until
physical power cycle.
Secondary Bus Reset (fallback after quirk_no_flr) successfully resets the
device and allows reinitialization.

> Can we get any of the MediaTek folks to comment on this:
> https://sashiko.dev/#/patchset/20260508145153.717641-1-jtornosm@redhat.com?part=1
>
> Sashiko suggested that Device ID 0x0717 might have the same FLR
> problem.
I don't have that device to confirm the same behavior. I'll wait for
MediaTek maintainers (now CC'd) to confirm whether 0x0717 exhibits the
same FLR issue. If confirmed, I can add it in a follow-up patch or the
next version.

Thanks

Best regards
José Ignacio


      reply	other threads:[~2026-05-22  6:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  6:12 [PATCH v3] PCI: Disable broken FLR on MediaTek MT7925 Jose Ignacio Tornos Martinez
2026-05-21 16:19 ` Bjorn Helgaas
2026-05-22  6:48   ` Jose Ignacio Tornos Martinez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260522064854.201976-1-jtornosm@redhat.com \
    --to=jtornosm@redhat.com \
    --cc=Ryder.Lee@mediatek.com \
    --cc=alex@shazbot.org \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=sean.wang@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox