Linux wireless drivers development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, driver-core@lists.linux.dev,
	johannes@sipsolutions.net, wenjie.tsai@realtek.com,
	mh_chen@realtek.com, charlesl@valvesoftware.com,
	sabae@valvesoftware.com
Subject: Re: [PATCH v2 rtw-next 1/2] wifi: rtw89: add dev_id_quirks to driver_info for per-device quirk control
Date: Mon, 25 May 2026 21:31:43 +0200	[thread overview]
Message-ID: <2026052558-handclasp-garden-b472@gregkh> (raw)
In-Reply-To: <20260525085148.35180-2-pkshih@realtek.com>

On Mon, May 25, 2026 at 04:51:47PM +0800, Ping-Ke Shih wrote:
> --- a/drivers/net/wireless/realtek/rtw89/rtw8851be.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8851be.c
> @@ -73,6 +73,7 @@ static const struct rtw89_driver_info rtw89_8851be_info = {
>  	.chip = &rtw8851b_chip_info,
>  	.variant = NULL,
>  	.quirks = NULL,
> +	.dev_id_quirks = 0,

Why are you manually adding a "= 0" for these when that's the default?
No need to do so, only do it when it is set to something, right?

thanks,

greg k-h

  reply	other threads:[~2026-05-25 19:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25  8:51 [PATCH v2 rtw-next 0/2] wifi: rtw89: usb: read serial_number and uuid via sysfs Ping-Ke Shih
2026-05-25  8:51 ` [PATCH v2 rtw-next 1/2] wifi: rtw89: add dev_id_quirks to driver_info for per-device quirk control Ping-Ke Shih
2026-05-25 19:31   ` Greg KH [this message]
2026-05-26  1:09     ` Ping-Ke Shih
2026-05-27 11:48       ` Johnson Tsai
2026-05-25  8:51 ` [PATCH v2 rtw-next 2/2] wifi: rtw89: usb: add serial_number and uuid sysfs attributes for 0x28de:0x2432 Ping-Ke Shih
2026-05-25 19:32   ` Greg KH
2026-05-27 11:46     ` Johnson Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026052558-handclasp-garden-b472@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=charlesl@valvesoftware.com \
    --cc=driver-core@lists.linux.dev \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mh_chen@realtek.com \
    --cc=pkshih@realtek.com \
    --cc=sabae@valvesoftware.com \
    --cc=wenjie.tsai@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox