Linux wireless drivers development
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Miroslav Lichvar <mlichvar@redhat.com>,
	John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Frederic Weisbecker <frederic@kernel.org>,
	thomas.weissschuh@linutronix.de,
	Arthur Kiyanovski <akiyano@amazon.com>,
	Rodolfo Giometti <giometti@enneenne.com>,
	Vincent Donnefort <vdonnefort@google.com>,
	Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	kvmarm@lists.linux.dev, Oliver Upton <oupton@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	netdev@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
	Miri Korenblit <miriam.rachel.korenblit@intel.com>,
	Johannes Berg <johannes.berg@intel.com>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Peter Hilber <peter.hilber@oss.qualcomm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	virtualization@lists.linux.dev, linux-wireless@vger.kernel.org,
	linux-sound@vger.kernel.org, David Woodhouse <dwmw@amazon.co.uk>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: [patch V2 14/25] igc: Use provided clock ID for history snapshot
Date: Fri, 29 May 2026 22:00:44 +0200	[thread overview]
Message-ID: <20260529195557.637381831@kernel.org> (raw)
In-Reply-To: 20260529193435.921555544@kernel.org

From: Thomas Gleixner <tglx@kernel.org>

The PTP core indicates in system_device_crosststamp::clock_id the clock ID
for which the system time stamp should be taken. That allows to utilize
hardware timestamps with e.g. AUX clocks.

Save the provided clock ID and use it in igc_phc_get_syncdevicetime() for
taking the history snapshot.

No functional change.

Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Tested-by: Arthur Kiyanovski <akiyano@amazon.com>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
---
 drivers/net/ethernet/intel/igc/igc.h     |    1 +
 drivers/net/ethernet/intel/igc/igc_ptp.c |    4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)
--- a/drivers/net/ethernet/intel/igc/igc.h
+++ b/drivers/net/ethernet/intel/igc/igc.h
@@ -326,6 +326,7 @@ struct igc_adapter {
 	struct timespec64 prev_ptp_time; /* Pre-reset PTP clock */
 	ktime_t ptp_reset_start; /* Reset time in clock mono */
 	struct system_time_snapshot snapshot;
+	clockid_t snapshot_clock_id;
 	struct mutex ptm_lock; /* Only allow one PTM transaction at a time */
 
 	char fw_version[32];
--- a/drivers/net/ethernet/intel/igc/igc_ptp.c
+++ b/drivers/net/ethernet/intel/igc/igc_ptp.c
@@ -1049,7 +1049,7 @@ static int igc_phc_get_syncdevicetime(kt
 	 */
 	do {
 		/* Get a snapshot of system clocks to use as historic value. */
-		ktime_get_snapshot(&adapter->snapshot);
+		ktime_get_snapshot_id(adapter->snapshot_clock_id, &adapter->snapshot);
 
 		igc_ptm_trigger(hw);
 
@@ -1103,6 +1103,8 @@ static int igc_ptp_getcrosststamp(struct
 	/* This blocks until any in progress PTM transactions complete */
 	mutex_lock(&adapter->ptm_lock);
 
+	adapter->snapshot_clock_id = cts->clock_id;
+
 	ret = get_device_system_crosststamp(igc_phc_get_syncdevicetime,
 					    adapter, &adapter->snapshot, cts);
 	mutex_unlock(&adapter->ptm_lock);


  parent reply	other threads:[~2026-05-29 20:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 19:59 [patch V2 00/25] timekeeping/ptp: Expand snapshot functionality Thomas Gleixner
2026-05-29 19:59 ` [patch V2 01/25] timekeeping: Provide ktime_get_snapshot_id() Thomas Gleixner
2026-05-29 19:59 ` [patch V2 02/25] timekeeping: Use system_time_snapshot::systime/monoraw instead of ::real/raw Thomas Gleixner
2026-05-29 19:59 ` [patch V2 03/25] pps: generators: Use ktime_get_real_ts64() instead of ktime_get_snapshot() Thomas Gleixner
2026-05-29 20:00 ` [patch V2 04/25] pps: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-05-29 20:00 ` [patch V2 05/25] KVM: arm64: Use ktime_get_snapshot_id() to retrieve CLOCK_BOOTTIME Thomas Gleixner
2026-05-29 20:00 ` [patch V2 06/25] KVM: arm64: Use ktime_get_snapshot_id() to snapshot CLOCK_REALTIME Thomas Gleixner
2026-05-29 20:00 ` [patch V2 07/25] ptp: ptp_vmclock: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-05-29 20:00 ` [patch V2 08/25] timekeeping: Remove system_time_snapshot::real/boot/raw Thomas Gleixner
2026-05-29 20:00 ` [patch V2 09/25] timekeeping: Add CLOCK_AUX support for ktime_get_snapshot_id() Thomas Gleixner
2026-05-29 20:00 ` [patch V2 10/25] timekeeping: Add system_counterval_t to struct system_device_crosststamp Thomas Gleixner
2026-05-29 20:00 ` [patch V2 11/25] timekeeping: Add CLOCK ID to system_device_crosststamp Thomas Gleixner
2026-05-29 20:00 ` [patch V2 12/25] wifi: iwlwifi: Adopt PTP cross timestamps to core changes Thomas Gleixner
2026-05-29 20:00 ` [patch V2 13/25] ice/ptp: Use provided clock ID for history snapshot Thomas Gleixner
2026-05-29 20:00 ` Thomas Gleixner [this message]
2026-05-29 20:00 ` [patch V2 15/25] net/mlx5: " Thomas Gleixner
2026-05-29 20:00 ` [patch V2 16/25] virtio_rtc: " Thomas Gleixner
2026-05-29 20:00 ` [patch V2 17/25] timekeeping: Remove ktime_get_snapshot() Thomas Gleixner
2026-05-29 20:01 ` [patch V2 18/25] timekeeping: Prepare for cross timestamps on arbitrary clock IDs Thomas Gleixner
2026-05-29 20:01 ` [patch V2 19/25] ptp: Use system_device_crosststamp::sys_systime Thomas Gleixner
2026-05-29 20:01 ` [patch V2 20/25] wifi: iwlwifi: " Thomas Gleixner
2026-05-29 20:01 ` [patch V2 21/25] ALSA: hda/common: " Thomas Gleixner
2026-05-29 20:01 ` [patch V2 22/25] timekeeping: Remove system_device_crosststamp::sys_realtime Thomas Gleixner
2026-05-29 20:01 ` [patch V2 23/25] timekeeping: Add support for AUX clock cross timestamping Thomas Gleixner
2026-05-29 20:01 ` [patch V2 24/25] ptp: Switch to ktime_get_snapshot_id() for pre/post timestamps Thomas Gleixner
2026-05-29 20:01 ` [patch V2 25/25] timekeeping: Add clocksource read_snapshot() method and hw_cycles to snapshot Thomas Gleixner
2026-05-29 20:33 ` [patch V2 00/25] timekeeping/ptp: Expand snapshot functionality Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260529195557.637381831@kernel.org \
    --to=tglx@kernel.org \
    --cc=akiyano@amazon.com \
    --cc=anna-maria@linutronix.de \
    --cc=anthony.l.nguyen@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=dwmw@amazon.co.uk \
    --cc=frederic@kernel.org \
    --cc=giometti@enneenne.com \
    --cc=jacob.e.keller@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=jstultz@google.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=mlichvar@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=oupton@kernel.org \
    --cc=peter.hilber@oss.qualcomm.com \
    --cc=richardcochran@gmail.com \
    --cc=saeedm@nvidia.com \
    --cc=sboyd@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=tiwai@suse.com \
    --cc=vadim.fedorenko@linux.dev \
    --cc=vdonnefort@google.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox