Linux wireless drivers development
 help / color / mirror / Atom feed
From: Jeeva Anandh <anandhjeeva215@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org,
	Jeeva Anandh <anandhjeeva215@gmail.com>
Subject: [PATCH] b43legacy: remove redundant mask bit set
Date: Wed,  3 Jun 2026 12:53:31 +0000	[thread overview]
Message-ID: <20260603125331.6310-1-anandhjeeva215@gmail.com> (raw)

mask is initialized to 0x0000001F, which already contains
the 0x0010 bit. Therefore the conditional OR operation is
redundant and can be removed.

Signed-off-by: Jeeva Anandh <anandhjeeva215@gmail.com>
---
 drivers/net/wireless/broadcom/b43legacy/main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c
index 6b3e0b2bbca7..d32bffa6f009 100644
--- a/drivers/net/wireless/broadcom/b43legacy/main.c
+++ b/drivers/net/wireless/broadcom/b43legacy/main.c
@@ -1904,8 +1904,6 @@ static int b43legacy_gpio_init(struct b43legacy_wldev *dev)
 		mask |= 0x0200;
 		set |= 0x0200;
 	}
-	if (dev->dev->id.revision >= 2)
-		mask  |= 0x0010; /* FIXME: This is redundant. */
 
 #ifdef CONFIG_SSB_DRIVER_PCICORE
 	pcidev = bus->pcicore.dev;
-- 
2.43.0


             reply	other threads:[~2026-06-03 12:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 12:53 Jeeva Anandh [this message]
2026-06-03 15:56 ` [PATCH] b43legacy: remove redundant mask bit set Michael Büsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260603125331.6310-1-anandhjeeva215@gmail.com \
    --to=anandhjeeva215@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox