Re: [PATCH] wifi: brcmfmac: add DPP support and fix fw-supplicant/P2P interop

[kernel test robot <lkp@intel.com>]

Hi Jason,

kernel test robot noticed the following build warnings:

[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main linus/master v7.1-rc6 next-20260602]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jason-Huang/wifi-brcmfmac-add-DPP-support-and-fix-fw-supplicant-P2P-interop/20260603-115824
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link:    https://lore.kernel.org/r/20260603035722.145894-1-Jason.Huang2%40infineon.com
patch subject: [PATCH] wifi: brcmfmac: add DPP support and fix fw-supplicant/P2P interop
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20260603/202606031541.hOnf0Qnq-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260603/202606031541.hOnf0Qnq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606031541.hOnf0Qnq-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c: In function 'brcmf_p2p_tx_action_frame':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1593:13: warning: variable 'action_frame_len' set but not used [-Wunused-but-set-variable]
    1593 |         u16 action_frame_len;
         |             ^~~~~~~~~~~~~~~~


vim +/action_frame_len +1593 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c

  1570	
  1571	
  1572	/**
  1573	 * brcmf_p2p_tx_action_frame() - send action frame over fil.
  1574	 *
  1575	 * @ifp: interface to transmit on.
  1576	 * @p2p: p2p info struct for vif.
  1577	 * @af_params: action frame data/info.
  1578	 * @vif: vif to send
  1579	 *
  1580	 * Send an action frame immediately without doing channel synchronization.
  1581	 *
  1582	 * This function waits for a completion event before returning.
  1583	 * The WLC_E_ACTION_FRAME_COMPLETE event will be received when the action
  1584	 * frame is transmitted.
  1585	 */
  1586	static s32 brcmf_p2p_tx_action_frame(struct brcmf_if *ifp,
  1587					     struct brcmf_p2p_info *p2p,
  1588					     struct brcmf_fil_af_params_le *af_params)
  1589	{
  1590		struct brcmf_pub *drvr = p2p->cfg->pub;
  1591		s32 err = 0;
  1592		struct brcmf_fil_action_frame_le *action_frame;
> 1593		u16 action_frame_len;
  1594	
  1595		action_frame = &af_params->action_frame;
  1596		action_frame_len = le16_to_cpu(action_frame->len);
  1597	
  1598		brcmf_dbg(TRACE, "Enter\n");
  1599	
  1600		reinit_completion(&p2p->send_af_done);
  1601		clear_bit(BRCMF_P2P_STATUS_ACTION_TX_COMPLETED, &p2p->status);
  1602		clear_bit(BRCMF_P2P_STATUS_ACTION_TX_NOACK, &p2p->status);
  1603	
  1604		err = brcmf_fil_bsscfg_data_set(ifp, "actframe", af_params,
  1605						sizeof(*af_params));
  1606		if (err) {
  1607			bphy_err(drvr, " sending action frame has failed\n");
  1608			goto exit;
  1609		}
  1610	
  1611		p2p->af_sent_channel = le32_to_cpu(af_params->channel);
  1612		p2p->af_tx_sent_jiffies = jiffies;
  1613	
  1614		if (test_bit(BRCMF_P2P_STATUS_DISCOVER_LISTEN, &p2p->status) &&
  1615		    p2p->af_sent_channel ==
  1616		    ieee80211_frequency_to_channel(p2p->remain_on_channel.center_freq))
  1617			p2p->wait_for_offchan_complete = false;
  1618		else
  1619			p2p->wait_for_offchan_complete = true;
  1620	
  1621		brcmf_dbg(TRACE, "Waiting for %s tx completion event\n",
  1622			  (p2p->wait_for_offchan_complete) ?
  1623			   "off-channel" : "on-channel");
  1624	
  1625		wait_for_completion_timeout(&p2p->send_af_done, P2P_AF_MAX_WAIT_TIME);
  1626	
  1627		if (test_bit(BRCMF_P2P_STATUS_ACTION_TX_COMPLETED, &p2p->status)) {
  1628			brcmf_dbg(TRACE, "TX action frame operation is success\n");
  1629		} else {
  1630			err = -EIO;
  1631			brcmf_dbg(TRACE, "TX action frame operation has failed\n");
  1632		}
  1633		/* clear status bit for action tx */
  1634		clear_bit(BRCMF_P2P_STATUS_ACTION_TX_COMPLETED, &p2p->status);
  1635		clear_bit(BRCMF_P2P_STATUS_ACTION_TX_NOACK, &p2p->status);
  1636	
  1637	exit:
  1638		return err;
  1639	}
  1640	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki