From: Zenm Chen <zenmchen@gmail.com>
To: pkshih@realtek.com
Cc: linux-wireless@vger.kernel.org, rtl8821cerfe2@gmail.com,
zenmchen@gmail.com
Subject: RE: [PATCH rtw-next v2 1/5] wifi: rtw89: 8831bu: Add support for ELECOM WD{B,C}-X600DU2M-B
Date: Thu, 4 Jun 2026 01:05:19 +0800 [thread overview]
Message-ID: <20260603170521.3886-1-zenmchen@gmail.com> (raw)
In-Reply-To: <4779f2efe03a44f9973e3ebd9c853331@realtek.com>
Ping-Ke Shih <pkshih@realtek.com> 於 2026年6月1日週一 下午2:10寫道:
>
> Zenm Chen <zenmchen@gmail.com> wrote:
> > Add the ids 056e:4027 and 056e:4028 into the device table to support
> > ELECOM WD{B,C}-X600DU2M-B, two new 8831bu-based adapters.
> >
> > Compile tested only.
> >
> > Link: https://github.com/morrownr/rtw89/commit/9e2db2834b37c6adfc4b872a9ef56c927df22bea
>
> As I saw surface of this Link ".../commit/...", I'd ask you to remove
> the Link, because a github commit isn't so important to be a commit message.
>
> Look deeper.... The Link's content (the comment part) is to indicate where
> you got these USB devices ID, right?
> If so, maybe you can just mention that you collected these ID from [1].
>
> (change to this style instead of formal Link)
> [1] https://github.com/morrownr/rtw89/commit/9e2db2834b37c6adfc4b872a9ef56c927df22bea
>
> Then, if a reviewer wants to save himself time, he can just ignore the link.
>
> Please apply it to this patchset. Thanks.
>
> Ping-Ke
>
Okay, will fix in the next version, thanks!
prev parent reply other threads:[~2026-06-03 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 23:29 [PATCH rtw-next v2 1/5] wifi: rtw89: 8831bu: Add support for ELECOM WD{B,C}-X600DU2M-B Zenm Chen
2026-05-31 23:29 ` [PATCH rtw-next v2 2/5] wifi: rtw89: 8832au: Support two additional devices Zenm Chen
2026-05-31 23:29 ` [PATCH rtw-next v2 3/5] wifi: rtw89: 8832bu: Add support for I-O DATA WN-DAX1200U Zenm Chen
2026-05-31 23:29 ` [PATCH rtw-next v2 4/5] wifi: rtw89: 8832cu: Add support for Mercusys MA86XH Zenm Chen
2026-05-31 23:29 ` [PATCH rtw-next v2 5/5] wifi: rtw89: 8912au: Add support for Mercusys MA37BEH Zenm Chen
2026-06-01 6:10 ` [PATCH rtw-next v2 1/5] wifi: rtw89: 8831bu: Add support for ELECOM WD{B,C}-X600DU2M-B Ping-Ke Shih
2026-06-03 17:05 ` Zenm Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603170521.3886-1-zenmchen@gmail.com \
--to=zenmchen@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox