Re: [PATCH] wifi: wlcore: Add support for IGTK key

[Andreas Kemnade <andreas@kemnade.info>]

On Fri, 8 May 2026 15:55:07 +0200 (CEST)
Peter Åstrand <astrand@lysator.liu.se> wrote:

> On Fri, 8 May 2026, Andreas Kemnade wrote:
> 
> > Hi,
> > 
> > On Fri, 16 Jan 2026 18:58:58 +0100 (CET)
> > Peter Åstrand <astrand@lysator.liu.se> wrote:
> >   
> > > This change re-applies commit 2b7aadd3b9e1 ("wlcore: Adding suppoprt for IGTK key in
> > > wlcore driver") (sic), but only enables WLAN_CIPHER_SUITE_AES_CMAC with modern
> > > firmware. This patch is required to support WPA3 connections.
> > >   
> > 
> > I have seen this after this patch:
> > [  484.113311] wlcore: WARNING could not set keys
> > [  484.117828] wlcore: ERROR Could not add or replace key
> > [  484.123016] wlan0: failed to set key (5, ff:ff:ff:ff:ff:ff) to hardware (-5)
> > [  484.123046] wlcore: Hardware recovery in progress. FW ver: Rev 7.3.10.0.142
> > [  484.139923] wlcore: pc: 0x0, hint_sts: 0x00000048 count: 1
> > [  484.145721] wlcore: down
> > [  484.148986] ieee80211 phy0: Hardware restart was requested
> > [  484.610473] wlcore: firmware booted (Rev 7.3.10.0.142)
> > [  484.633758] wlcore: Association completed.
> > [  484.690490] wlcore: ERROR command execute failure 14
> > [  484.690490] ------------[ cut here ]------------
> > [  484.700195] WARNING: drivers/net/wireless/ti/wlcore/main.c:872 at wl12xx_queue_recovery_work+0x64/0x74 [wlcore], CPU#0: kworker/0:0/892
> > 
> > This repeats endlessly.
> > As soon as I set pmf to 1 in wpa_supplciant, once per second. Reverting this patch helps. Seen this
> > on the Epson Moverio BT-200.  
> 
> Thanks for this feedback. From the firmware version, I assume that this is 
> not wl18xx but probably wl12xx? Unfortunately I have no experience with 
> that module. So, while my patch is an improvement over the original patch 
> because it checks firmware version, it did not consider non-wl18xx 
> modules. 
> 
> I guess we need to throw in something like:
> 
> strcmp(pdev_data->family->name, "wl18xx")
> 
> ...in the if statement. 
> 
btw: if the firmware is started for a second time, it will also decrement again.
So after some reboots we end up without any cipher.
And afaik the firmware ups at any ifup.

Regards,
Andreas