From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC1364D8DB9 for ; Fri, 5 Jun 2026 11:33:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.244.123.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780659204; cv=none; b=NCY6LrRnl8YBC1+lC/FnEAw92rYk7hzdCDE9NmFGmEWW9hkcAmbemsIhPU2/N/DJ1+iphU9rBA4wCQu630N2Ns619j3gL7gXRD7FwkSj8uVx8nHKBFNepF7KDNeEsqEE8zvec10PqnOsF2JPzFWV4vevNpJOljg9uwPlGVbmc6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780659204; c=relaxed/simple; bh=6hNejuJKNFxOne9eCwHsnrwL0w/rpFbEx1fY4BuWSmc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GQG8JqDeBOLiycOAHaZyVbHb8N25WKdMp7NwXBb+4UMgs7Fy95RtsoWnEs2FwVgLU1L4ezlg7Yw9TC4IiFXSzkWlAKcGToUrZC9OBs7x3FSata+hUGrqrfmxen2zLnuXuTeUmgUcpj+hf2+jv3NurMad/SVcbevUmthZzNYLIf8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=gnNQpgMw; arc=none smtp.client-ip=60.244.123.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="gnNQpgMw" X-UUID: 578d07fc60d211f1b1788b6acf885367-20260605 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=/j9usojQrhGiMjx2wHcS8MnUEj9C4dvTS2jU4SvxVis=; b=gnNQpgMwJnEgH5VWXLuFoL9x6GYLlfYsgRLJ0rJ6Q5A/5dnHCbrookk6z4UTimxWZhwpxKmb5Z6Egtz5blXOLZzvOU767O63u2/QDs9c7/JTpn7wFkhuNqJ0HO4JF69yeEGx02yMMNpt4FVasKs/TAf5AQD1H8ibRHaQxOcvdrQ=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.15,REQID:9dd118d5-67dd-4a07-9ce4-417bb76f93e9,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:e276073,CLOUDID:ee106820-87a8-421b-982c-f5939dba7cba,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|836|865|888|898,TC:-5,Cont ent:0|15|50,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL:0 ,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 578d07fc60d211f1b1788b6acf885367-20260605 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 631933204; Fri, 05 Jun 2026 19:33:15 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 5 Jun 2026 19:33:14 +0800 Received: from mussdccf250.eus.mediatek.inc (10.73.250.250) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Fri, 5 Jun 2026 19:33:13 +0800 From: Ryder Lee To: Felix Fietkau CC: , , Shayne Chen , Ryder Lee Subject: [PATCH 2/4] wifi: mt76: mt7921: fix potential tx_retries underflow Date: Fri, 5 Jun 2026 04:33:04 -0700 Message-ID: <20260605113306.3485554-2-ryder.lee@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260605113306.3485554-1-ryder.lee@mediatek.com> References: <20260605113306.3485554-1-ryder.lee@mediatek.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N When FIELD_GET returns 0 for the retry count, subtracting 1 causes an unsigned integer underflow, resulting in tx_retries becoming a very large value (0xFFFFFFFF for u32). Fix by checking if count is non-zero before subtracting 1. Fixes: 9aecfa754c7f ("wifi: mt76: mt7921e: report tx retries/failed counts in tx free event") Signed-off-by: Ryder Lee --- drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c index 03b4960db..668bfa195 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c @@ -530,8 +530,9 @@ static void mt7921_mac_tx_free(struct mt792x_dev *dev, void *data, int len) stat = FIELD_GET(MT_TX_FREE_STATUS, info); if (wcid) { - wcid->stats.tx_retries += - FIELD_GET(MT_TX_FREE_COUNT, info) - 1; + u32 count = FIELD_GET(MT_TX_FREE_COUNT, info); + + wcid->stats.tx_retries += count ? count - 1 : 0; wcid->stats.tx_failed += !!stat; } -- 2.45.2