From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a1-smtp.messagingengine.com (fout-a1-smtp.messagingengine.com [103.168.172.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABFE8481AAD; Tue, 9 Jun 2026 16:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.144 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781023468; cv=none; b=t7kBfG3qjyCVf9u2El/gloExV9EPHTJgAmcPMJyKdkerABknH4J9iE7i/W007Y6SI6cdPMInYDyRNTMCWxlfXmjCpzerbDZLuZ/QcGNTHtViylFVulK5ESIMNNPa9l0KkLLJjTyf0XH1oO6sLNQ1VB1Fm7xAOw6jMRqYcW/xqJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781023468; c=relaxed/simple; bh=I6CesmfoIlfOdot1WU2Sgz7jy9kVlptUq6uVqJoEokE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=piblot62XRlARWhBYOYNXxdmiUFZlXgDM3r0cf9Lp7YCNjS5sGQ6EYKIbbIWdxpBUHtK6wlYN8LteN6bkLuCqMdOZND7b1Q0fZX+kyHCKQX7cdYS9g4OdxvfmJYg4hsraPLwRwsVcGL8Ty3KH2fFEZ5CgWF7rKqmQi5eI9xWnVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org; spf=pass smtp.mailfrom=shazbot.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b=ZxnRPF2L; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=K1jznXHS; arc=none smtp.client-ip=103.168.172.144 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shazbot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b="ZxnRPF2L"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="K1jznXHS" Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id CC922EC0112; Tue, 9 Jun 2026 12:44:24 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Tue, 09 Jun 2026 12:44:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1781023464; x=1781109864; bh=ZvpGOg0McmFFQ0JmTAfnzIXcmaEu3YPVXxWgHR7A9Ks=; b= ZxnRPF2L17v/Dqu7N++8AdvVHdCSK1wdxl9F4d8xRO++wcMOMuDO0XXKYxtjuRXn 5tpeZHvhuH123wT4BUCOaxOXq4NOCIzr6ol4te1AUHT/dzObm3+eykp4cMOzkdLs qflJGDc3CueMJzNVl2FPzG8Ri45V36qs1fJoi+gLVaoYjGY80VC6ZLqt8JUsJfaC X7Wyx8SnQ3CEQ1aoWr5c4jQkABw3pM+W+bX8npn6sQ9id+gw1BTJIT1Mh0Fos6bc eZin1NM9cuiSEzXg03fTIkbMlL+cHB/97hXBnprriWn02IVu5INCYg2jfqVYsm0f 8xwq31c6H7D4xenVJMsuQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1781023464; x= 1781109864; bh=ZvpGOg0McmFFQ0JmTAfnzIXcmaEu3YPVXxWgHR7A9Ks=; b=K 1jznXHShtA5II0txNCpN51TNboW05+Iq2er7ALudNxujAJrr42fx8vKhRgzvj2ru rygw7iSl1znk0O9oPMjtP97OeaRGB+sa/A0YPftuCamnVOpgnVVRP7Ff0H2IWZre rZfJHWSa9i+BGXpuodPLBDQqmh7t2y/JBk/EDsKyhVrxUnXhXor+6CfnZc/CfjxY vdGuKx0OmsepCHML4vBJmYmPqULS2YDXoNo/w5YXEArEpHdiGssiZ8ScLGD1IVb0 fAjU9sr5+/R62C/FNRuj3hINDkaNQxIEmDFNrWm4hdTVZNWhcjl4YWBTNtoW5hF+ TrWSvYXhWm/6CyFl84YWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGknTG+NctqFLBA1TpgQfMpv0S7zWjXCtRugjLVg39zSEs5ow92+YqXpIC4OvYOJx lA27PNvLOzkb92cL9V4gUoy5SIrj5uIZg1fEBX91/++cdnzfOnrCS9STL8qCbVksB1cPJn JzxPCVH27I7O5MbzARzArrub8la5CVxNts2uVvPxtwIfg1L7HHajiPaN3pzbEusZ2a0lqR 2BKiYqg42mwwReIuv3BCfwTUYK/h407l6BW1j7itXLTUDNJ8eRtsMIMxCl2oovM+i2N6A9 CVrM/92xI4N1ZVhaXHMR4+CuwwVQBYeYbzDHIqciVHHB/TjTFoLdxacQTvD47tjrBlcKmX brmje2APsyFdBULj/i15mj3w0PvNU86TjOwtbxQiG4rUHouiWVGkMkv4UXdJE6kf7PFJ7u 4Ozq39yp0TaaVhSJasPUyL68wJkA2XJvVtME90tl2DIsMbjysMQp10iM9NLWpl2+KW63uv oJgmI3ds77KpQptXJ1hKsJ2G8zxNCUNIJGDWAIDGwOGxcAZp7ZecozlE1iMo4uubtMARU0 ztP0TEoZPaXidEm/IaqhMTeUv3ndeQCd9zMqomumLmplD7cjSZWs9Pyl1YDYLqfXpM+OLs fEI0jvndXsp+BzMl+2i8exbhyUye8AjuSfbNhXmxlr4nhKMJurJ3uG26N7Hw X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 Jun 2026 12:44:23 -0400 (EDT) Date: Tue, 9 Jun 2026 10:44:22 -0600 From: Alex Williamson To: Jose Ignacio Tornos Martinez Cc: helgaas@kernel.org, bhelgaas@google.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org, lorenzo@kernel.org, nbd@nbd.name, sean.wang@mediatek.com, shayne.chen@mediatek.com, alex@shazbot.org Subject: Re: [PATCH v4] PCI: Disable broken FLR on MediaTek MT7925 Message-ID: <20260609104422.19c9580d@shazbot.org> In-Reply-To: <20260609153333.70991-1-jtornosm@redhat.com> References: <20260609144532.GA104629@bhelgaas> <20260609153333.70991-1-jtornosm@redhat.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 9 Jun 2026 17:33:33 +0200 Jose Ignacio Tornos Martinez wrote: > Hello Bjorn, > > > > Alex, are you OK with this? The v2 conversation talks about SBR also > > being broken, but maybe that turned out to be a red herring? > > > > https://lore.kernel.org/linux-pci/20260508145153.717641-1-jtornosm@redhat.com/t/#u > Alex can answer better, but to clarify: SBR works correctly for MT7925e. > The confusion in v2 was because I initially grouped MT7925e together with > Qualcomm devices (WCN6855, WCN7850, SDX modems) to try to fix their reset > issues. Alex suggested testing SBR for all of them, which revealed they > have different issues: > - MT7925e: FLR advertised but broken, SBR works fine (this patch - quirk_no_flr) > - Qualcomm devices: No FLR capability, SBR is broken (separate series with > quirk_no_bus_reset + device-specific reset) > So I split them into separate patches since the root causes are different. > This fix for MT7925e (quirk_no_flr) removes the broken FLR and allows the > working SBR to be used. Yes, this patch follows our standard practice of quirking out known broken reset mechanisms and the qcom devices are now handled in a different series. I'm ok with this. Thanks, Alex