From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b6-smtp.messagingengine.com (fout-b6-smtp.messagingengine.com [202.12.124.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DFE536897C; Wed, 10 Jun 2026 19:15:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781118923; cv=none; b=tupxjq5pepwETEs94G4yIV5edHSQ2qYHyU1UO/lCgs3JV7yi7LDi9ke6d2I+Kiz0HgUm8/rCShbBKtQauALIUkrYOFfT2pBhd6qIf8SZKuf1D4qgRctFvgfM9SfltCLn5kZqXfA3tZX8h63QYO3oia7XDISzhdlP0qKRSYnMMLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781118923; c=relaxed/simple; bh=cYvkeDUtRmvAaKCdk9MF8yO3KaSVOMG+MKxosmL8KW0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JuoqOqyTig0LHevhct+MlhyDoIrLFHRhsE2Kl0+oitrHu73SkmX13GzdSEvXD6iQRph0cVn04zfCYdA3ywoudWha5Pm1zChD9JpWiH0OdALl4StHt5xDJyzomEAorodSVNxe4H0Su/3BKR9DmwWro2kO9CwbOcxAq9D3Wj/QZkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org; spf=pass smtp.mailfrom=shazbot.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b=Gm/6IVI9; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Iifd/wVM; arc=none smtp.client-ip=202.12.124.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shazbot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b="Gm/6IVI9"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Iifd/wVM" Received: from phl-compute-08.internal (phl-compute-08.internal [10.202.2.48]) by mailfout.stl.internal (Postfix) with ESMTP id F053B1D00018; Wed, 10 Jun 2026 15:15:19 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Wed, 10 Jun 2026 15:15:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1781118919; x=1781205319; bh=CVy2JmiDScr+o6xC3nZ1IUbCbzhQKrbZ7/aFWDNXxFI=; b= Gm/6IVI91Zc/JG+ombwZiuLgrzMLHSXnGDVtABxnArwqn2nqlpSpTvBsKRbNZGZG Yz/ja+ig/TO+rmJ7JJKBhfrYFtaC4ofneMI/yvB+3z6b7nLbDhR9pa3AI1KZjSvU yHWaCewWvPZd/PQ+bC7xujhGabuonupj8JpJZ3IrAcjuStlMYugUgBztyNmgKzFr TJBwTt8ysks0dPxvaJjh5xnH8NfINUmYuAfQCZtrsaK1HOLHIZANBmDoefmVh4xS Jo/3KiDTZGOD3WSrjQXvdISj7PuqGhvLZ412yVN71GF+sC9KULPppXj0VEUJlWfU RUEsSH27bYhJ3Q7yCwC7gg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1781118919; x= 1781205319; bh=CVy2JmiDScr+o6xC3nZ1IUbCbzhQKrbZ7/aFWDNXxFI=; b=I ifd/wVMXad4h+Q+pRYOcuwKq6qlgm69ZyqmzpfHc8XBIyRrZnoM126Mgw0yX7M2D o6x4oLZCROgqXnweQETTEI8aTcIw+cM3sRsbiAKVpqLdomJX9AO+BfHL2oFfhubP o1LMx18aELOdNp+AVitRcFFSz/OwQ8yszvQkOdy/qiwaB68kfHiPOin9hjl61CI6 86SkAjx0fQj3AfsuSGB+kML6strk6b9lWoPfIwLYqUxzkkna+ULOg4qX1ItJ5ZPm sjoUSAvhZrLh7MQFh8WcAJ4cAcxXnOOgaxXr6ZzQJVQXH0Cc3N3cIyiNbCbljMcz TOwoN5IB4al4NaR+1GlDQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTENsJBpTOZ6YX/UOOE51y07s8b8SVjd2U/sBvvG7WPM7QaG22AiPLgsvtwA9p430B CnyEyxsm53+lIa6P5muTNjBXD+k9Z0UKK24ENec4OWuaR2h6Gn82lHTTfWSwkTT0tPhJuq ePnbvDc2uHk3EE/CYJwaWAqhqruRcaf3AljRIz9dOjW8IiRfzXdwjXVOnUelFUBRldRAWc KG+E6MQwx4gzKpzX5cFwfw0C0WFNel+9bPdNpXfAqlkfk/jbeK9Gp4vy4wcwjHhFsgx2BL r6c+YYwN+dNSmt5vAENm7R37LycxdRcYO0TJnwoMRyAdHY1cyDYZKN6I4obp+/ZUKD9BoQ 1OWbIEI5qNFY7/J8J/wCRGPCa/RHaO3N6uzzYmULgc9qZEbB2R8N/PMp9CEEere4niCwbR DJNQ3Tx7bQ0wyvewZVWlkSVvS8I1JajyqV7MDE3S8f1HtwrtA5IiMzri12xaU44bebLJNT sasMe59kizUEJHRDyMaNtk4k8pBfAYZ76odlyuszWW1sybZJPd84gAVgacXA9OGYjhU6Xc bZ9PSl5+D48NmOP3fKV/7c/kGfd7x/ifeWosHGrmtqmeLpWOoxD2Bf5LIDM9ZsnOAJTTSo mkNG3lH07rPbW73TpBRdz7TFZV53XkhVbHGDH973/iJ2DH5Lb0SgO/93cj5Q X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 Jun 2026 15:15:18 -0400 (EDT) Date: Wed, 10 Jun 2026 13:15:17 -0600 From: Alex Williamson To: Jose Ignacio Tornos Martinez Cc: ath11k@lists.infradead.org, ath12k@lists.infradead.org, bhelgaas@google.com, jjohnson@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org, mani@kernel.org, mhi@lists.linux.dev, alex@shazbot.org Subject: Re: [PATCH v8 2/3] PCI: Add device-specific reset for Qualcomm devices Message-ID: <20260610131517.6d7bd63a@shazbot.org> In-Reply-To: <20260610100059.19235-1-jtornosm@redhat.com> References: <20260609115352.32acb6fe@shazbot.org> <20260610100059.19235-1-jtornosm@redhat.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 10 Jun 2026 12:00:59 +0200 Jose Ignacio Tornos Martinez wrote: > Hi Alex, > > > My only complaint is that this is positioned a bit generically... > Ok, I'll make the comment of the function more specific for these Qualcomm > devices. > > > Has each of these devices been tested on a platform where D3cold is > > actually achieved through this method? > No, I don't have access to platforms with _PR3 support. All testing was on > M.2 adapters (D3hot fallback only). Since D3hot works reliably and D3cold > is a stronger reset mechanism, the approach should work - but I cannot > confirm the D3cold path through testing. This seems to suggest that the D3cold reset method is also untested... I'd suggest dropping the D3cold throughout, unless you can get someone to volunteer to test it. It seems like you really just want this quirk to do a D3hot regardless of NoSoftRst+ with a select set of devices where it appears to do more than nothing, where doing nothing is effectively what's left after the other reset methods are being quirked off for being worse than nothing. Thanks, Alex