Linux wireless drivers development
 help / color / mirror / Atom feed
From: Petr Wozniak <petr.wozniak@gmail.com>
To: Felix Fietkau <nbd@nbd.name>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>
Cc: Shayne Chen <shayne.chen@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	linux-wireless@vger.kernel.org,
	Petr Wozniak <petr.wozniak@gmail.com>
Subject: [PATCH 0/2] wifi: mt76: fix per-band LEDs under single-wiphy MLO
Date: Sun, 28 Jun 2026 11:53:11 +0200	[thread overview]
Message-ID: <20260628095313.7790-1-petr.wozniak@gmail.com> (raw)

On MT7996 (and other single-wiphy MLO mt76 devices) only the 2.4 GHz LED
was ever usable: the 5/6 GHz band LEDs stayed dark and a WARN_ON() was hit
during probe.

Two issues are involved:

1. mt76_led_init() calls ieee80211_create_tpt_led_trigger() for every band,
   but that helper supports only one trigger per ieee80211_hw and
   WARN_ON()s + returns NULL on the second call, so the secondary bands got
   a NULL default trigger.

2. mt7996 assigned the LED brightness_set/blink_set callbacks only to the
   primary PHY, so mt76_led_init() bailed out early for the 5/6 GHz bands
   and never registered their LED classdevs.

Patch 1 shares the throughput trigger across all bands; patch 2 registers a
LED classdev for every band. With both applied, all three band LEDs
(mt76-phy0/1/2) come up and blink on their band's traffic.

Tested on a BPI-R4 (MT7996/BE14): all three per-band LEDs register at boot
with no WARN_ON(), and each blinks on its own band's activity (verified
with single-band and MLO clients).

Petr Wozniak (2):
  wifi: mt76: share the throughput LED trigger across bands
  wifi: mt76: mt7996: register a LED classdev for every band

 drivers/net/wireless/mediatek/mt76/mac80211.c  | 18 +++++++++++++-----
 .../net/wireless/mediatek/mt76/mt7996/init.c   | 18 ++++++++++++------
 2 files changed, 25 insertions(+), 11 deletions(-)

-- 
2.51.0


             reply	other threads:[~2026-06-28  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-28  9:53 Petr Wozniak [this message]
2026-06-28  9:53 ` [PATCH 1/2] wifi: mt76: share the throughput LED trigger across bands Petr Wozniak
2026-06-28  9:53 ` [PATCH 2/2] wifi: mt76: mt7996: register a LED classdev for every band Petr Wozniak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260628095313.7790-1-petr.wozniak@gmail.com \
    --to=petr.wozniak@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox