From: Hojun Choi <ghwns6743@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Deepak Karn <dkarn@redhat.com>,
syzbot+ca7a2759caaa6cd4e3db@syzkaller.appspotmail.com,
Hojun Choi <ghwns6743@gmail.com>
Subject: Re: [PATCH wireless] wifi: mac80211: clear beaconing state in ieee80211_do_stop()
Date: Sun, 28 Jun 2026 23:13:11 +0900 [thread overview]
Message-ID: <20260628141311.12488-1-ghwns6743@gmail.com> (raw)
In-Reply-To: <20260628130802.7698-1-ghwns6743@gmail.com>
Following up with the concrete path, since the question is whether
cfg80211_leave() already covers this. It does not for AP start failure:
ieee80211_start_ap() sets enable_beacon before its fail-able steps, but
its error path (cfg.c:1930) only releases the channel, never clearing it
(unlike the IBSS/mesh paths), while cfg80211 leaves ap.beacon_interval at
0. A later interface-down then makes ___cfg80211_stop_ap() short-circuit
(-ENOENT, net/wireless/ap.c:30) and skip the stop_ap clear, so
ieee80211_do_stop() runs with enable_beacon still set. I could not get a
driver to fail start_ap() there, so this is by inspection, not a
reproducer.
I can fold this into the commit message in a v2, or instead fix the
producer by clearing enable_beacon on the start_ap() error path
(mirroring IBSS/mesh) - whichever you prefer. I used do_stop() since
you suggested it might need to clear that bit.
Thanks,
Hojun
prev parent reply other threads:[~2026-06-28 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 13:08 [PATCH wireless] wifi: mac80211: clear beaconing state in ieee80211_do_stop() Hojun Choi
2026-06-28 14:13 ` Hojun Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260628141311.12488-1-ghwns6743@gmail.com \
--to=ghwns6743@gmail.com \
--cc=dkarn@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=syzbot+ca7a2759caaa6cd4e3db@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox