From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A079285068 for ; Sat, 11 Jul 2026 15:06:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782375; cv=none; b=l5UefldB+5oe9Qexy6rNg8gMDapLPlNmMjwlwdwkFi9zYvRUDg4PDkeNQSmCp5CxaOkOcdb3CqimU6bNTXiwiEbet8KWrOgSX/ETRQV1x1M95PzacuqbJvijqSIx+/g6AyWoaecWUQEqxQ7ZLEFCU4eYzfHq29x7RLL9uuGaXBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782375; c=relaxed/simple; bh=S4tnd3gU6E0U7OZ4HKFPKwlMp4QR6VJmRDUS5NtF2D8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e4UgxqUD+GVUQA6j2ZrqKKYoFltnOwR/kGDuRjKxWAvu1nFliXMLsIyXehhblgy0obKEemaP6e3G157U77zQCclO71VsIb6V44C4IxW8XD+qg25GXQbch5VLY/64j5NSyn69HX2CFsiqqm25wJKP8+nmP273/AKuHawNMYDfumo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IaIB+0pZ; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IaIB+0pZ" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-92e6391b114so128460585a.3 for ; Sat, 11 Jul 2026 08:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783782373; x=1784387173; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=/GKREJqWw2SSprYGaRAlQGLw7OTwwGCr4lR4AMIblRM=; b=IaIB+0pZtIMq3YKkGd0S+QkIuAOPdidHFry21OP5ESYPHMH7gu/kXtHD5te/fBI78t prey7qedh2k9DUhZzTWJVQvmyQoX9RtoR7hCIWq2eba09EPg+1C2Wvs9+T5xc5xXFVYi nBpf9LG6TuZ4jkXfA5xkLOMhdRMSCVEmhhkIlBy+o9RKG1uQ4t8Kj3cLtdvU8jPwqL3M 2kUZHcgIpuHgElt3VoREgDNCdEG/iiP0IoGDvEHpXV7TyHiXXrtYwUEd/8PKZRKcD6dZ XkK4Ae4KP8QBmBs/oYN6h52VzH9verACr65WuA0CsAA8TDrgIIjdanfYDxJxIyBMnMZr oRmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783782373; x=1784387173; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/GKREJqWw2SSprYGaRAlQGLw7OTwwGCr4lR4AMIblRM=; b=RK3ZXmZT7h6iZdRruUf0hvy0QlCF5Riy8WuvK+Uv2Ul2Bi/aCwEWYU01BNhnaeWvOd kGxDikoQaXpRD4lMR6ym1dW80hWfVx2LOo+UI4fBUpsBlvUQvn3sQlpt7z5cJTA8+AAT BkkBr9loy5by4oskOIzz7y+uhBBh3iH6C48GwXIieQYwIalF5/kVOF04mzxyGDTCe/WJ uHA9BrvR0Vg81kpgR2CHhRQBOdQydi9shrLk3Mtk6QHv6vhVlXPP/TOxBar0NA2rwfYa 23g1lWrLsiyMasI3i42MCczSMlks22uzb4wpom4hiiAnT0V2dn3I38GUuZv7Onl+v2qM tBWg== X-Forwarded-Encrypted: i=1; AHgh+Rp33Yuk3Q5nza1e5x43ZlQ92dn+ewo/zez9OfaEo/LbNUcXsBC65ECCiWjpWKJjMzu48mgZ6RNtZvgScAdbAA==@vger.kernel.org X-Gm-Message-State: AOJu0Yyspdbd+NCKsBp+mbDDAK27GdQ63njNGkspL06aq0aOmMnzIwyr ROSHVoha00Ogs5khpkIHDh1pJoqYbQDSNUyMMoEu2EYTUPTXQXtxsxhM X-Gm-Gg: AfdE7cksy9TeTFPrXD/KWrivqDXJmL7fSqn56EF6Yz1fHKnP+Tq28zkTJVK54nR94rR dqeS0ZnRQVVXVfGng/ORNu4iC29EOUcNJaiiK0qmbGHoMnwZk7DxWsEmvVTFcS9tFi2ThJk8k6q GfehwQnGnuoQOPVkIbNWeIGMWnPGESV/gVLOTjyJgz/iG9BbWqACx5XTniXcN8P0QjsE1czxRLb Kco8yryfaD26kvejgeefPe2D9eQ1/yLdhx840/z7PFx2rih29DL7FxfRWzbcTzX1Vbd3gGX+RFh mEcpGOowAhOQWIStN7/oYTYpdZFCyYayLN7E6rX4CCCaw/CUi+89HlW5410cbl7sa+6SG/uwhJF f8ypTiMb89LqzdIdgo+t48FaFSU3zNng2B1KozPzJNWN9BFzg4vSMrsXqL9CdyqE1eDPrfMNijG AGMEgFcDeNtsKZnLFqzsnqjcv4YK1AcQjLVVy6v2ihszH9i5+/dKxS8PftVqlLykWJ2cBRbh/L0 CbZ6MYNlA== X-Received: by 2002:a05:620a:3941:b0:92e:6864:b83 with SMTP id af79cd13be357-92ef2c131fcmr396322685a.69.1783782373374; Sat, 11 Jul 2026 08:06:13 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5d68e5fsm464578285a.43.2026.07.11.08.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 08:06:12 -0700 (PDT) From: Michael Bommarito To: Miri Korenblit , Johannes Berg Cc: Emmanuel Grumbach , Benjamin Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 0/2] wifi: iwlwifi: mvm: bound BA-window station ID Date: Sat, 11 Jul 2026 11:06:09 -0400 Message-ID: <20260711150611.2913332-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit iwl_mvm_window_status_notif() extracts a 5-bit station ID from the firmware's BA-window status notification (values up to 31) and indexes mvm->fw_id_to_mac_id[] with it without first checking it against the firmware's station capacity. A firmware/backend notification carrying an out-of-range ID reads past the station map. Patch 1 validates the station ID against mvm->fw->ucode_capa.num_stations before the lookup, matching the existing MVM station-lookup helpers. Patch 2 adds KUnit coverage: the malformed out-of-range ID and a valid-ID/ null-station control that must still pass. Reproduced with the KUnit test under UBSAN bounds: the malformed case reports an array-index-out-of-bounds splat on stock and passes after the fix; the valid-ID control passes on both. Cc: stable@vger.kernel.org Michael Bommarito (2): wifi: iwlwifi: mvm: check BA-window station ID before lookup wifi: iwlwifi: mvm: add KUnit coverage for BA-window station ID bounds drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 4 + .../wireless/intel/iwlwifi/mvm/tests/Makefile | 2 +- .../intel/iwlwifi/mvm/tests/window-status.c | 77 +++++++++++++++++++ 3 files changed, 82 insertions(+), 1 deletion(-) create mode 100644 drivers/net/wireless/intel/iwlwifi/mvm/tests/window-status.c -- 2.53.0