From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 499A22641CA for ; Mon, 13 Jul 2026 01:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783907995; cv=none; b=QVAAfBDIVKxAiDU4ODsRadWXn9PCBahI0c7hQfZFCGQstppOR5p8l0a4wdbjEaFw9/CrjzEOoeFnBebOqSeRHNiaaC6qb+1Zmy/1SRALsWygbNGYByeq9cXTD9CFOv/y9yw2PEGGlet/0HnBh8tpf6PDeHQfPgRSi+sBbFIwNmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783907995; c=relaxed/simple; bh=+11yWNOdd8cBhzP4+Mwsu4bHfxAH2qECK88s/cKMByY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KGCh3hHoKkdKQKSMLoHzy3uclWOBDcViKYwdq0torXt7OhHvjuM3Vg651+Dzsm6dY2Ztuf8MxkIL78P8rNcpiCcaL7VEwG3QXzd1hNFRn6ouhtra8LXDoM/3UEQTjYkYxKtViaztRZDws6tn4U5w3+AIC/5Sn/m0lf2rGVe7Avo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WkPV+UQt; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WkPV+UQt" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-385ea3ce80dso2922368a91.2 for ; Sun, 12 Jul 2026 18:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783907994; x=1784512794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=g6ZY0A81ZwFH7zPrXD3IEMLtteDysZZzXtDeInBjqMg=; b=WkPV+UQtRkYbHAtVc3mieuguqORhZmP33obXxziiE3hUOUk014tGZ4LUW/Py9RhiSC s1QLNG1DLB2b956AHPNYlcTJpVbKo9EODsTL9CxYDNFivKzZWG/2utpGJ2vQd/EvEJZT h0YIlKFoHRTGGaEQbdGoWwtB5usGIN1PHNHMvZYU8XW63/KLD95pWA5q44DFStDE2X9C GjxglQzmK0O7f4NgxfEwKzEjT3ua0jixg7KxKXuQ+8xgv8g0+piqBCsPyuTLlPN6KhTt xq/S0PLy7UOYBbSuaq7hzLZc1qHA4iQvbuHIxor/LVTo5O6Vpg1CSfQBEwkUJo61X9p/ KMtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783907994; x=1784512794; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=g6ZY0A81ZwFH7zPrXD3IEMLtteDysZZzXtDeInBjqMg=; b=LJmobruTjvt/NfB8upARpXsRqq1S/Ybm8mOTwfMUs1687Bgd5J4GmYvSv4kpgLu9EZ bIy9kSOZME5vWrVoqXky4N2v76ZyxyDoj99OhBmdl5yrJOgmQOX44gmg+o5qxlYmiOnJ QuWQaydXRSrfHSX2F4lDvF8sUD05VWEof7FZRGTdPYydeDMEnRiDMvVsQ4DkthQtNlr1 Q6d8BW9s14Rv4ySbuucNO9XB3PK6yeg8uJGXm/qs3inncmcVSsHGHOzyDJKyRMyjIBFk PpzNprzWCRBv2BrdkRBbgtyl43hRAkxz4GTpMlFw8+F2XMvFAriTjiG/oomDX2V8SSd6 4QsA== X-Gm-Message-State: AOJu0Ywois/LKJUjRtwL/TbcptPAc1YwCpV4GH1KVhinlK10jAYo2dBQ 7uao+DCCkpY16RmoaUy5nyjbYOy9OnnZmjTh4SUWzcsPi/0jzHRLEP9e9oTAfg== X-Gm-Gg: AfdE7cneYucE3+aG3u1UerpTQgAoPnrVHMXpJhVuNaIKxy/PU7ug0cJZrXXLbjvM0PK Dxsw/VHhUWpSyIQiu0GIRQYMO4jm4ECeRRIOP/7+ydvFShZ5lnCKSavmZJ3YolfOYc/Gt5jtQqS TH0t50klAbHc8UwyUGl+19oWtDvgVjwTYuOK9vKAsqbVSAk21tTJo8yXsvm+m8bc0FepWhOsVqf 1nyV/G7ha2+jcMSCFwi+rosY5jIxJwTie5DwcT5OGbGQ1bjcA/RChCsOjX51bOZvpd0GAJ3MCZf Boqt4nj64FxI/arAJ5Nb2dNZiCgLgTCgPfyq5dfXYKyVWfD8nUbwAu/gsL3YHg8tI2VjA96MgC8 Sid5bXgwEZetr+b5yE3JSGsCgfHtOUqP+KZuGMiNWT7vWXDaF9dLY7GV1O+rracvfQBf8UnSuUQ 9FDJ9MGoMoq8YvvyQeggi11g+wraUOCoI2KdyUo4iSvPRMj4LYmMuT1ZYVFvCQhuKSY7mQNyhY5 BMh1co= X-Received: by 2002:a17:90b:5883:b0:37f:9cdf:f0af with SMTP id 98e67ed59e1d1-38dc780f6c9mr6851162a91.30.1783907993608; Sun, 12 Jul 2026 18:59:53 -0700 (PDT) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:383f:6251:ecfe:10d4:faf8]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174ac14f2sm68369573eec.27.2026.07.12.18.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 18:59:52 -0700 (PDT) From: Deepanshu Kartikey To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+b6ce23950fd636e6efb6@syzkaller.appspotmail.com Subject: [PATCH] mac80211: don't encrypt pre-auth (ETH_P_PREAUTH) frames Date: Mon, 13 Jul 2026 07:29:46 +0530 Message-ID: <20260713015946.44636-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pre-authentication frames (ETH_P_PREAUTH, 0x88C7) are sent before the authentication handshake completes with the target AP, so no encryption key exists for them yet. Unlike normal EAPOL frames (ETH_P_8021X, 0x888E) which are registered as the control port protocol, pre-auth frames are not recognized as control port frames, causing the kernel to incorrectly assign the current AP's key and attempt encryption, resulting in a WARN_ON in ieee80211_encrypt_tx_skb when the cipher is not handled. Fix this by setting IEEE80211_TX_INTFL_DONT_ENCRYPT for pre-auth frames in ieee80211_tx_h_check_control_port_protocol(), so that key selection skips them and they are sent unencrypted as intended. Reported-by: syzbot+b6ce23950fd636e6efb6@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=b6ce23950fd636e6efb6 Signed-off-by: Deepanshu Kartikey --- net/mac80211/tx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index c13b209fad47..b3acfd69380f 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c @@ -557,6 +557,9 @@ ieee80211_tx_h_check_control_port_protocol(struct ieee80211_tx_data *tx) info->flags |= IEEE80211_TX_CTL_USE_MINRATE; } + if (tx->skb->protocol == htons(ETH_P_PREAUTH)) + info->flags |= IEEE80211_TX_INTFL_DONT_ENCRYPT; + return TX_CONTINUE; } -- 2.43.0