Linux wireless drivers development
 help / color / mirror / Atom feed
From: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
To: hujy652@gmail.com
Cc: ath11k@lists.infradead.org, ath12k@lists.infradead.org,
	jjohnson@kernel.org, jtornosm@redhat.com,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] wifi: ath11k: implement custom wake_tx_queue with flow control
Date: Tue, 14 Jul 2026 18:02:38 +0200	[thread overview]
Message-ID: <20260714160238.664089-1-jtornosm@redhat.com> (raw)
In-Reply-To: <CAHGaMk_FbjCShGw++0m9UT+sK+w23okwvx1vkqid6n9M=WScxQ@mail.gmail.com>

Hi Zhi-Jun,


> While you are reworking it would you mind looking at the previous attempt?
>
> It tried to follow the behaviour in ath10k but lacks throttling mechanism.
>
> https://lore.kernel.org/linux-wireless/20230501130725.7171-1-quic_tamizhr@quicinc.com/

Thanks for the pointer. 

I have looked at Tamizh's patch and the main difference with this approach
is that the ring free space check is done before dequeuing, so the skb is
never consumed when the ring is full. This avoids frame drops and the
-ENOMEM errors we were seeing.

I think no additional push mechanism from TX completions is needed since
wake_tx_queue is called frequently enough under traffic to resume dequeuing
when ring space becomes available.

Best regards,
Jose Ignacio


  reply	other threads:[~2026-07-14 16:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 15:54 [PATCH 0/2] ath11k/ath12k: implement TX flow control Jose Ignacio Tornos Martinez
2026-07-10 15:54 ` [PATCH 1/2] wifi: ath11k: implement custom wake_tx_queue with " Jose Ignacio Tornos Martinez
2026-07-11 15:33   ` Zhi-Jun You
2026-07-13 15:01     ` Jose Ignacio Tornos Martinez
2026-07-14  2:38       ` Zhi-Jun You
2026-07-14 16:02         ` Jose Ignacio Tornos Martinez [this message]
2026-07-10 15:54 ` [PATCH 2/2] wifi: ath12k: " Jose Ignacio Tornos Martinez
2026-07-13 16:27   ` Jeff Johnson
2026-07-14 15:59     ` Jose Ignacio Tornos Martinez
2026-07-13 17:05   ` Tamizh Raja
2026-07-14 16:01     ` Jose Ignacio Tornos Martinez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260714160238.664089-1-jtornosm@redhat.com \
    --to=jtornosm@redhat.com \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=hujy652@gmail.com \
    --cc=jjohnson@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox