From: Francesco Dolcini <francesco@dolcini.it>
To: Georgi Valkov <gvalkov@gmail.com>
Cc: briannorris@chromium.org, francesco@dolcini.it,
johannes.berg@intel.com, bhelgaas@google.com, error27@gmail.com,
s.kerkmann@pengutronix.de, kees@kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: replace one-element arrays with flexible array members
Date: Wed, 15 Jul 2026 18:14:07 +0200 [thread overview]
Message-ID: <20260715161407.GH56330@francesco-nb> (raw)
In-Reply-To: <20260712222334.7134-1-gvalkov@gmail.com>
On Mon, Jul 13, 2026 at 01:23:34AM +0300, Georgi Valkov wrote:
> Replace deprecated one-element arrays with flexible array members.
> CONFIG_FORTIFY_SOURCE reports the following warning when
> one-element arrays are used as variable-length buffers:
>
> sta_cmd.c:1033 mwifiex_sta_prepare_cmd
> memcpy: detected field-spanning write (size 84) of single field
> "domain->triplet" at .../marvell/mwifiex/sta_cmd.c:1033 (size 3)
>
> Convert affected structs to use flexible array members.
> - Preserve existing wire layouts.
> - Replace affected uses of sizeof(member) with sizeof(type).
> - Replace unions containing one-element arrays with
> u8 flexible arrays, and document the stored parameter-set type.
>
> Tested-on: WRT3200ACM, OpenWrt
> Signed-off-by: Georgi Valkov <gvalkov@gmail.com>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
next prev parent reply other threads:[~2026-07-15 16:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 22:23 [PATCH] wifi: mwifiex: replace one-element arrays with flexible array members Georgi Valkov
2026-07-15 16:14 ` Francesco Dolcini [this message]
2026-07-15 16:35 ` Kees Cook
2026-07-15 22:59 ` George Valkov
2026-07-16 0:17 ` [PATCH v3] " Georgi Valkov
2026-07-16 6:16 ` Francesco Dolcini
2026-07-16 6:27 ` Dan Carpenter
2026-07-16 6:32 ` Francesco Dolcini
2026-07-16 6:55 ` Dan Carpenter
2026-07-16 8:09 ` George Valkov
2026-07-16 6:42 ` George Valkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715161407.GH56330@francesco-nb \
--to=francesco@dolcini.it \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=error27@gmail.com \
--cc=gvalkov@gmail.com \
--cc=johannes.berg@intel.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.kerkmann@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox