From: Francesco Dolcini <francesco@dolcini.it>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Rosen Penev <rosenp@gmail.com>,
linux-wireless@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:KERNEL HARDENING (not covered by other
areas):Keyword:\\b__counted_by(_le|_be|_ptr)?\\b"
<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH wireless-next] wifi: mwifiex: Use flexible array for RX reorder table
Date: Thu, 23 Jul 2026 16:55:55 +0200 [thread overview]
Message-ID: <20260723145555.GA238048@francesco-nb> (raw)
In-Reply-To: <1e77da9180ee82bf1b0d122f0ddf137949d4278e.camel@sipsolutions.net>
Hello Johannes,
On Tue, May 19, 2026 at 08:47:00AM +0200, Johannes Berg wrote:
> On Mon, 2026-05-18 at 14:18 -0700, Rosen Penev wrote:
> > Embed the RX reorder pointer array in struct mwifiex_rx_reorder_tbl
> > instead of allocating it separately.
>
> Others might disagree, but personally, I think you should stop doing
> this. Sure, it *might* (I've been bitten too much by __counted_by) be a
> border-line improvement, but it's not _really_ all that useful,
> especially on these older drivers.
>
> Did you even test it at all?
>
...
> If you _really_ want to help, please help review changes rather than
> producing more noise. Maybe even take over maintenance of some specific
> driver that you can test.
I also do not see any specific reason to take this, as of now I have not
enough brain cycles available to properly review this, and if this is
not even tested we should just reject it.
Francesco
prev parent reply other threads:[~2026-07-23 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 21:18 [PATCH wireless-next] wifi: mwifiex: Use flexible array for RX reorder table Rosen Penev
2026-05-19 6:47 ` Johannes Berg
2026-07-23 14:55 ` Francesco Dolcini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723145555.GA238048@francesco-nb \
--to=francesco@dolcini.it \
--cc=briannorris@chromium.org \
--cc=gustavoars@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox