From: Krzysztof Kozlowski <krzk@kernel.org>
To: Georgi Valkov <gvalkov@gmail.com>
Cc: briannorris@chromium.org, johannes@sipsolutions.net,
andrew@lunn.ch, krzk+dt@kernel.org, francesco@dolcini.it,
johannes.berg@intel.com, kees@kernel.org,
miriam.rachel.korenblit@intel.com, wenst@chromium.org,
rafael.beims@toradex.com, avraham.stern@intel.com,
error27@gmail.com, s.kerkmann@pengutronix.de,
gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
robh@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com,
chunfan.chen@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v5 1/3] dt-bindings: net: wireless: add flag marvell,ignore-regulatory-hint
Date: Wed, 19 Aug 2026 11:42:23 +0200 [thread overview]
Message-ID: <20260819-generous-nickel-dalmatian-b6bb08@quoll> (raw)
In-Reply-To: <20260817215428.84740-1-gvalkov@gmail.com>
On Tue, Aug 18, 2026 at 12:54:26AM +0300, Georgi Valkov wrote:
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml b/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml
> index 930b700b73d0..5f235cb9f3e5 100644
> --- a/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/marvell,sd8787.yaml
> @@ -59,6 +59,12 @@ properties:
> description: Calibration data for sub-band 3 in the 5GHz band.
> maxItems: 502
>
> + marvell,ignore-regulatory-hint:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Ignore an incorrect regulatory hint from ROM,
> + so userspace can set the correct regulatory domain.
> +
Same comments, so you just ignored entire feedback?
Again: you need to describe the hardware, in commit msg, in property
name and in description. You cannot tell SW what to do, that's not the
purpose of bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-19 9:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 10:35 [PATCH] wifi: mwifiex: ignore ROM regulatory hint on WRT3200ACM/WRT32x Georgi Valkov
2026-07-30 2:16 ` Jeff Chen
2026-07-30 3:06 ` George Valkov
2026-07-30 3:24 ` George Valkov
2026-07-30 7:47 ` Jeff Chen
2026-07-31 6:31 ` [PATCH v2] " Georgi Valkov
2026-08-07 8:26 ` Jeff Chen
2026-08-07 18:21 ` [PATCH v3 1/2] " Georgi Valkov
2026-08-07 18:21 ` [PATCH v3 2/2] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint Georgi Valkov
2026-08-07 18:39 ` [PATCH v3 1/2] wifi: mwifiex: ignore ROM regulatory hint on WRT3200ACM/WRT32x Johannes Berg
2026-08-07 19:49 ` George Valkov
2026-08-10 18:30 ` Brian Norris
2026-08-14 12:50 ` [PATCH 1/3] dt-bindings: net: wireless: add flag marvell,ignore-regulatory-hint Georgi Valkov
2026-08-14 12:50 ` [PATCH 2/3] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint Georgi Valkov
2026-08-14 12:50 ` [PATCH 3/3] wifi: mwifiex: add dt flag to ignore incorrect ROM regulatory hint Georgi Valkov
2026-08-17 8:54 ` [PATCH 1/3] dt-bindings: net: wireless: add flag marvell,ignore-regulatory-hint Krzysztof Kozlowski
2026-08-17 10:43 ` George Valkov
2026-08-17 11:06 ` Krzysztof Kozlowski
2026-08-17 13:20 ` George Valkov
2026-08-17 13:24 ` Krzysztof Kozlowski
2026-08-17 13:48 ` George Valkov
2026-08-17 21:54 ` [PATCH v5 " Georgi Valkov
2026-08-17 21:54 ` [PATCH v5 2/3] ARM: dts: armada: WRT3200ACM: add marvell,ignore-regulatory-hint Georgi Valkov
2026-08-17 21:54 ` [PATCH v5 3/3] wifi: mwifiex: add dt flag to ignore incorrect ROM regulatory hint Georgi Valkov
2026-08-18 0:53 ` [PATCH v5 1/3] dt-bindings: net: wireless: add flag marvell,ignore-regulatory-hint Andrew Lunn
2026-08-18 9:58 ` George Valkov
2026-08-19 9:40 ` Krzysztof Kozlowski
2026-08-19 9:42 ` Krzysztof Kozlowski [this message]
2026-08-19 11:42 ` George Valkov
2026-08-19 12:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819-generous-nickel-dalmatian-b6bb08@quoll \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=andrew@lunn.ch \
--cc=avraham.stern@intel.com \
--cc=briannorris@chromium.org \
--cc=chunfan.chen@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=error27@gmail.com \
--cc=francesco@dolcini.it \
--cc=gregory.clement@bootlin.com \
--cc=gvalkov@gmail.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=rafael.beims@toradex.com \
--cc=robh@kernel.org \
--cc=s.kerkmann@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox