From: Devin Wittmayer <lucid_duck@justthetip.ca>
To: Benjamin Berg <benjamin@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
Jeff Johnson <jjohnson@kernel.org>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Ryder Lee <ryder.lee@mediatek.com>,
Ping-Ke Shih <pkshih@realtek.com>,
Johannes Berg <johannes@sipsolutions.net>,
Benjamin Berg <benjamin.berg@intel.com>,
ath11k@lists.infradead.org, ath12k@lists.infradead.org
Subject: Re: [PATCH wireless-next v3 2/8] wifi: mac80211: change public RX API to use link stations
Date: Thu, 20 Aug 2026 09:12:07 -0700 [thread overview]
Message-ID: <20260820161207.125743-1-lucid_duck@justthetip.ca> (raw)
In-Reply-To: <20260819155703.af6d319e6b61.I4a2d45609e94b52654b10ec572e59a45d09c41f4@changeid>
On Wed, Aug 19, 2026 at 03:57:06PM +0200, Benjamin Berg wrote:
> - *sta = wcid_to_sta(mstat.wcid);
This moves inside the wcid check, so it no longer happens for every frame.
mt76 uses one variable for a whole receive batch, so a frame with no wcid
keeps the previous frame's station instead of being cleared.
Frames with no wcid are normal rather than rare. On an MT7922 they were
about 98% of everything received, and 16 frames out of roughly 4000 ended
up carrying a leftover station.
No harm that I could show. None of those 16 were data frames, and that is
the only kind mac80211 reads the link station for. Clearing it when there
is no wcid still looks worth doing.
Devin
next prev parent reply other threads:[~2026-08-20 16:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 13:57 [PATCH wireless-next v3 0/8] Adding NO_STA flag and reworking RX link resolution Benjamin Berg
2026-08-19 13:57 ` [PATCH wireless-next v3 1/8] wifi: iwlwifi: use link_sta internally to the driver Benjamin Berg
2026-08-19 13:57 ` [PATCH wireless-next v3 2/8] wifi: mac80211: change public RX API to use link stations Benjamin Berg
2026-08-20 16:12 ` Devin Wittmayer [this message]
2026-08-20 17:56 ` Jeff Johnson
2026-08-20 23:15 ` Devin Wittmayer
2026-08-19 13:57 ` [PATCH wireless-next v3 3/8] wifi: mac80211: refactor RX link_id and station handling Benjamin Berg
2026-08-19 13:57 ` [PATCH wireless-next v3 4/8] wifi: mac80211: rework RX packet handling Benjamin Berg
2026-08-19 13:57 ` [PATCH wireless-next v3 5/8] wifi: cfg80211: add attribute for TX/RX denoting there is no station Benjamin Berg
2026-08-20 18:12 ` Jeff Johnson
2026-08-19 13:57 ` [PATCH wireless-next v3 6/8] wifi: mac80211: report to cfg80211 when no STA is known for a frame Benjamin Berg
2026-08-19 13:57 ` [PATCH wireless-next v3 7/8] wifi: mac80211: pass station to ieee80211_tx_skb_tid Benjamin Berg
2026-08-19 13:57 ` [PATCH wireless-next v3 8/8] uwifi: mac80211: pass error station if non-STA transmit was requested Benjamin Berg
2026-08-20 17:40 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820161207.125743-1-lucid_duck@justthetip.ca \
--to=lucid_duck@justthetip.ca \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=benjamin.berg@intel.com \
--cc=benjamin@sipsolutions.net \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=nbd@nbd.name \
--cc=pkshih@realtek.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox