Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Shengzhuo Wei" <me@cherr.cc>
To: "Christian Lamparter" <chunkeey@googlemail.com>,
	 "Michael Wu" <flamingice@sourmilk.net>,
	 "John W. Linville" <linville@tuxdriver.com>,
	 "David S. Miller" <davem@davemloft.net>
Cc: <linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	 <stable@vger.kernel.org>, "Shengzhuo Wei" <me@cherr.cc>
Subject: [PATCH 0/2] wifi: p54: validate PDA entry data lengths in eeprom parser
Date: Thu, 27 Aug 2026 01:07:38 +0800	[thread overview]
Message-ID: <20260827-p54-pda-validation-v1-0-bdc2b0675056@cherr.cc> (raw)

p54_parse_eeprom() walks the device-supplied PDA entries but some
handlers read from entry->data without first checking that the entry
actually carries the bytes they read. This series adds the missing
length validations for the two worst offenders: the PA calibration
curve data (a ~191 KB over-read) and the interface-list records.

This continues the EEPROM trust-boundary hardening of
da1b9a55ff11 and ebd6d37fa94b, which validated the readback path but
not the parser that consumes the received data.

Both over-reads were verified with KASAN reproducers of the respective
loops, and both fixes confirmed to silence them.

---
Shengzhuo Wei (2):
      wifi: p54: validate curve data length in p54_parse_eeprom()
      wifi: p54: require a full exp_if record in PDR_INTERFACE_LIST

 drivers/net/wireless/intersil/p54/eeprom.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)
---
base-commit: 66fb95a521110da673090294561844c9f76ebe64
change-id: 20260826-p54-pda-validation-7b2e91f4c6a3

Best regards,
-- 
Shengzhuo Wei <me@cherr.cc>

             reply	other threads:[~2026-08-26 17:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 17:07 Shengzhuo Wei [this message]
2026-08-26 17:07 ` [PATCH 1/2] wifi: p54: validate curve data length in p54_parse_eeprom() Shengzhuo Wei
2026-08-30 13:16   ` Christian Lamparter
2026-08-26 17:07 ` [PATCH 2/2] wifi: p54: require a full exp_if record in PDR_INTERFACE_LIST Shengzhuo Wei
2026-08-30 13:18   ` Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260827-p54-pda-validation-v1-0-bdc2b0675056@cherr.cc \
    --to=me@cherr.cc \
    --cc=chunkeey@googlemail.com \
    --cc=davem@davemloft.net \
    --cc=flamingice@sourmilk.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox