From: Lachlan Hodges <lachlan.hodges@morsemicro.com>
To: lachlan.hodges@morsemicro.com, dan.callaghan@morsemicro.com
Cc: linux-wireless@vger.kernel.org, arien.judge@morsemicro.com
Subject: [PATCH wireless-next 3/8] wifi: mm81x: do not drop PS filtered frames in AP mode
Date: Thu, 27 Aug 2026 15:49:12 +1000 [thread overview]
Message-ID: <20260827054917.255584-4-lachlan.hodges@morsemicro.com> (raw)
In-Reply-To: <20260827054917.255584-1-lachlan.hodges@morsemicro.com>
When the firmware reports a frame as filtered because the station has
entered power save, the AP-mode path dropped the frame and returned
"handled". In AP mode mac80211 owns the per-station power-save
re-buffering, so the frame must instead be reported with
IEEE80211_TX_STAT_TX_FILTERED and left for mac80211 to re-queue once
the station wakes.
Return false for AP interfaces so the tx-status path flags the frame as
filtered rather than silently dropping it.
Assisted-by: Claude:claude-opus-5
Signed-off-by: Lachlan Hodges <lachlan.hodges@morsemicro.com>
---
drivers/net/wireless/morsemicro/mm81x/skbq.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/morsemicro/mm81x/skbq.c b/drivers/net/wireless/morsemicro/mm81x/skbq.c
index 25655bd56d14..3bf15e7c38d8 100644
--- a/drivers/net/wireless/morsemicro/mm81x/skbq.c
+++ b/drivers/net/wireless/morsemicro/mm81x/skbq.c
@@ -231,10 +231,9 @@ static bool mm81x_tx_h_is_ps_filtered(struct mm81x_skbq *mq,
WARN_ON_ONCE(!(le32_to_cpu(tx_sts->flags) &
MM81X_TX_STATUS_FLAGS_PS_FILTERED));
- if (vif->type == NL80211_IFTYPE_AP) {
- __mm81x_skbq_drop_pending_skb(mq, skb);
- return true;
- }
+ /* mac80211 buffers frames in AP mode */
+ if (vif->type == NL80211_IFTYPE_AP)
+ return false;
if (vif->type == NL80211_IFTYPE_STATION) {
mm81x_skbq_insert_pending(mq, skb, tx_sts->pkt_id);
--
2.43.0
next prev parent reply other threads:[~2026-08-27 5:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 5:49 [PATCH wireless-next 0/8] wifi: mm81x: mcast and tx bw improvements Lachlan Hodges
2026-08-27 5:49 ` [PATCH wireless-next 1/8] wifi: mm81x: move beacon work and init below the tx op Lachlan Hodges
2026-08-27 5:49 ` [PATCH wireless-next 2/8] wifi: mm81x: release buffered broadcast frames after DTIM Lachlan Hodges
2026-08-27 5:49 ` Lachlan Hodges [this message]
2026-08-27 5:49 ` [PATCH wireless-next 4/8] wifi: mm81x: implement .tx_frames_pending() mac op Lachlan Hodges
2026-08-27 5:49 ` [PATCH wireless-next 5/8] wifi: mm81x: factor out tx width selection Lachlan Hodges
2026-08-27 5:49 ` [PATCH wireless-next 6/8] wifi: mm81x: tx EAPOLs at primary width Lachlan Hodges
2026-08-27 5:49 ` [PATCH wireless-next 7/8] wifi: mm81x: clamp tx width to stas max supported width Lachlan Hodges
2026-08-27 5:49 ` [PATCH wireless-next 8/8] wifi: mm81x: tx multicast frames from AP at primary width Lachlan Hodges
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827054917.255584-4-lachlan.hodges@morsemicro.com \
--to=lachlan.hodges@morsemicro.com \
--cc=arien.judge@morsemicro.com \
--cc=dan.callaghan@morsemicro.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox