Linux wireless drivers development
 help / color / mirror / Atom feed
From: Devin Wittmayer <lucid_duck@justthetip.ca>
To: Klara Modin <klarasmodin@gmail.com>
Cc: linux-wireless@vger.kernel.org,
	linux-mediatek@lists.infradead.org, nbd@nbd.name,
	lorenzo@kernel.org, regressions@lists.linux.dev
Subject: Re: [PATCH wireless] wifi: mt76: mt792x: fix NULL dereference in ACPI SAR init during probe
Date: Fri, 28 Aug 2026 10:18:38 -0700	[thread overview]
Message-ID: <20260828171838.22038-1-lucid_duck@justthetip.ca> (raw)
In-Reply-To: <apGWXuPOSqZJ_ShO@parmesan.int.kasm.eu>

On 2026-08-28 15:27:10 +0000, Klara Modin wrote:
> Wouldn't the Intel 11th generation have come with the Intel AX201 or
> AX210 originally?

It would, and thanks for the correction. This board's firmware carries
Intel's wireless power methods and none of MediaTek's four. I put an
MT7927 in it recently and the MediaTek ones did not appear, so they do
not come with the card.

> I don't think so (if this is the MTGS table above?), but I don't really
> know how to parse the table contents.

That is the right table, and nothing in it is padded. Yours is fine.

> so the transmit power limits actually look like they are too high for
> some bands, especially 5735-5835, but maybe it will limit to the AP
> transmit power and be fine? However, according to `iw list` the channels
> in 5735-5835 do not have the "no IR" flag, so in AP mode the card could
> potentially transmit ~8 times the allowed power (I would rather not test
> this)?

Every line reads the same because the driver writes the same number into
all of them:

	/* not used by fw */
	rule->power_rule.max_antenna_gain = DBI_TO_MBI(6);
	rule->power_rule.max_eirp = DBM_TO_MBM(22);

It is a placeholder rather than anything the card sent up, which is why
the same twenty-two turns up under every country code and not only
yours. So it is not evidence of what the radio will do in that band, in
either direction. The card has a power table of its own, separate from
this one, and debugfs shows it as txpower_sku.

> The 5710-5735 range is also not covered, which results in 5 GHz channel
> 144 being disabled (visible in `iw list`).

That hole is in what the card replied with. The driver copies the ranges
across untouched, so 144 goes with it.

Devin

      reply	other threads:[~2026-08-28 17:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 18:17 [PATCH wireless] wifi: mt76: mt792x: fix NULL dereference in ACPI SAR init during probe Devin Wittmayer
2026-08-25 18:27 ` Klara Modin
2026-08-28  1:17   ` Devin Wittmayer
2026-08-28 15:27     ` Klara Modin
2026-08-28 17:18       ` Devin Wittmayer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260828171838.22038-1-lucid_duck@justthetip.ca \
    --to=lucid_duck@justthetip.ca \
    --cc=klarasmodin@gmail.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox