From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wil6210: Remove %pK and %p
Date: Fri, 18 Sep 2026 18:58:16 +0200 [thread overview]
Message-ID: <20260918165816.n5Kt2YkG@linutronix.de> (raw)
In-Reply-To: <35e7ac7d-534a-4001-b076-56ca3e12bdb3@oss.qualcomm.com>
On 2026-09-18 08:25:32 [-0700], Jeff Johnson wrote:
> > Remove the %p and %pK line from wil_print_.*() so it does not end in
> > debugfs' output (debugfs is not ABI so removing does not break
> > anything).
> > Replace the skb pointer with yes/ no.
>
> NAK. debugfs may not be ABI, but it is a human interface, and you should not
> assume that a human debugger doesn't need the information.
>
> I'm ok with replacing %pK => %p but not ok with removing existing %p[K]
I didn't expect that you need the VA and the skb pointer. If so, let me
update accordingly.
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
next prev parent reply other threads:[~2026-09-18 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 10:56 [PATCH] wil6210: Remove %pK and %p Sebastian Andrzej Siewior
2026-09-18 15:25 ` Jeff Johnson
2026-09-18 16:58 ` Sebastian Andrzej Siewior [this message]
2026-09-18 20:11 ` [PATCH v2] wil6210: Replace %pK with %p Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918165816.n5Kt2YkG@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox