From: Jiale Yao <yaojiale02@163.com>
To: Jeff Johnson <jjohnson@kernel.org>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Michal Kazior <michal.kazior@tieto.com>,
Shashidhar Lakkavalli <slakkavalli@datto.com>,
Bhagavathi Perumal S <bperumal@codeaurora.org>,
Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
Govindaraj Saminathan <quic_gsamin@quicinc.com>,
Sriram R <quic_srirrama@quicinc.com>,
Carl Huang <quic_cjhuang@quicinc.com>,
Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>,
Wen Gong <quic_wgong@quicinc.com>,
Ramya Gnanasekar <quic_rgnanase@quicinc.com>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
linux-kernel@vger.kernel.org, ath11k@lists.infradead.org,
ath12k@lists.infradead.org
Cc: Jiale Yao <yaojiale02@163.com>
Subject: [PATCH v2 0/5] wifi: ath: avoid IDR mutation while iterating
Date: Sat, 3 Oct 2026 17:20:57 +0800 [thread overview]
Message-ID: <20261003092104.520135-1-yaojiale02@163.com> (raw)
The ath10k, ath11k, and ath12k cleanup paths walk an IDR while removing
the current entry. idr_for_each() retains radix-tree iterator state across
the callback, so that removal can invalidate the walk.
Use idr_for_each_entry() in each cleanup path. It performs a fresh
idr_get_next() lookup for every iteration, allowing the current entry to
be removed safely before its skb is released. Keeping the existing locked
removal helpers also ensures that a concurrent TX completion cannot find
an IDR entry which points to an already freed skb.
Changes in v2:
- Rework the ath11k and ath12k pending management TX cleanup patches to
remove each IDR entry before freeing its skb, as pointed out by
Rameshkumar and Jeff.
- Use idr_for_each_entry() for the pending cleanup callers instead of
leaving freed skb pointers in the IDR until idr_destroy().
Jiale Yao (5):
wifi: ath10k: avoid IDR mutation during TX cleanup
wifi: ath11k: avoid IDR mutation during pending mgmt TX cleanup
wifi: ath11k: avoid IDR mutation during vif mgmt TX cleanup
wifi: ath12k: avoid IDR mutation during pending mgmt TX cleanup
wifi: ath12k: avoid IDR mutation during vif mgmt TX cleanup
drivers/net/wireless/ath/ath10k/htt_tx.c | 7 ++++-
drivers/net/wireless/ath/ath11k/core.c | 3 +--
drivers/net/wireless/ath/ath11k/mac.c | 33 ++++++++++++------------
drivers/net/wireless/ath/ath11k/mac.h | 2 +-
drivers/net/wireless/ath/ath12k/core.c | 3 +--
drivers/net/wireless/ath/ath12k/mac.c | 33 ++++++++++++------------
drivers/net/wireless/ath/ath12k/mac.h | 2 +-
7 files changed, 44 insertions(+), 39 deletions(-)
--
2.34.1
next reply other threads:[~2026-10-03 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 9:20 Jiale Yao [this message]
2026-10-03 9:20 ` [PATCH v2 1/5] wifi: ath10k: avoid IDR mutation during TX cleanup Jiale Yao
2026-10-03 9:20 ` [PATCH v2 2/5] wifi: ath11k: avoid IDR mutation during pending mgmt " Jiale Yao
2026-10-03 9:21 ` [PATCH v2 3/5] wifi: ath11k: avoid IDR mutation during vif " Jiale Yao
2026-10-03 9:21 ` [PATCH v2 4/5] wifi: ath12k: avoid IDR mutation during pending " Jiale Yao
2026-10-03 9:21 ` [PATCH v2 5/5] wifi: ath12k: avoid IDR mutation during vif " Jiale Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003092104.520135-1-yaojiale02@163.com \
--to=yaojiale02@163.com \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=bperumal@codeaurora.org \
--cc=jjohnson@kernel.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=quic_cjhuang@quicinc.com \
--cc=quic_gsamin@quicinc.com \
--cc=quic_periyasa@quicinc.com \
--cc=quic_rgnanase@quicinc.com \
--cc=quic_srirrama@quicinc.com \
--cc=quic_vthiagar@quicinc.com \
--cc=quic_wgong@quicinc.com \
--cc=slakkavalli@datto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox