From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 881F84AC153 for ; Mon, 5 Oct 2026 14:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791210935; cv=none; b=oTe5VXNNpb5+DxaxwcNU5wDIqhqLLzy5YQT6vvXOsdkOaJfBBFvbzvh3XhWuSYVTttfRhV6QguWrx5i0etkwZlVUvIF2ZrGRFhVujoYFS9cZgl0/U7Xt2/116lOgCivUgPNWOn31pzS0jhoIvwYpfsjhQzOeFwKydCkBJUchVo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791210935; c=relaxed/simple; bh=ZsZHkcJx9ATC2tiTAwMr97NELUFCoYknk9e4btsEzKw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IJp8vEp51ks4rLssvx7Zysn/ltoW4iEVIniKulPZ/Xnd1S76kxv4WR6b+5yN8oRKP0ncac9JIfxUve/J0Gp62IOQB39EUo+nhpT6R1D9/Okpba40x3KEFbJ9/VA1nvySSXhX48E4M1P/Eh7kjNZmgPGxriyXQX6DoRqg4kUFF9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mUHkZ3c9; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mUHkZ3c9" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4a1688d7769so12377285e9.0 for ; Mon, 05 Oct 2026 07:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791210926; x=1791815726; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gJBmC6lInBWlZ8zhcwEQA8KotxGA62ubikb5bUiBrQw=; b=mUHkZ3c9/Mn0cQRvSerSwvOmfMsgHic8DwideBM2HEfkG8BP55kE9ljzk2/1Htsj2M afLSTmuS01BmLbyrs5Jlj/WDX1Wek7pisqHlub2S2s0fpc5+U/+lasc8wCIJUjrQv5xE 7QbAvineLMWDrluqHOLmQwqB3XtVIYf+d22y62Vt/dvCPQeMcTCYOVjdAN6qJMa0eo6O z6VDx26RQku84yEgTh4UYNTkTpFh4oMyJy5kRU9/No5g6s5IsctqwJ83hvleVmckWOdN ULvo9uKZoULf/dOM4Ag6F6KyxbRRHjVJ7GxuLR1BX3tfoAGacSJ3cEIR24OPtY4YerV7 DX/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791210926; x=1791815726; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gJBmC6lInBWlZ8zhcwEQA8KotxGA62ubikb5bUiBrQw=; b=f/Vgj4/aiPLQ7T8eecUkgInW973mLnFl5eACpTnH/s9QJ3mX5Wmr/CitH340Au64F6 657czVVGQK+W9cUX32XG9J1mPEwrLSiNV1lFxGis2ZgaQaFWHKsWbBD5PA8Grk5vEJlc 33A2XmUwfEUHCKgNblcLA7pGJ+POh548UxULbElTekscneBo1pkDhEuyuQ4R1fRMVRZa pgWFoZq93kkPj8zbIXbhwAt4Ytv2fuw1ncfcaBcdPdFvSsELisKBpTsOcekoo4vyZY1y QZ4kVHdV1FjphSq8sVKqq4giSC5L6bl+3kqwcdkqy4evt1cuL2QL/1FgRwlfKf6VFcSk bC0g== X-Forwarded-Encrypted: i=1; AKwUvBydqeh4U2ldGeaGhX/AazJQQR91Gz5+0/UYICMNSEN446Zl2D/Gjl5o5jGkn3shcgcrrvaqqXgFkfjbq2RvXQ==@vger.kernel.org X-Gm-Message-State: AFuF++lPARuD2HCFD/iWWNmNwBT7msa//2OykLDRlYCAgJv/gLJzRsqf q700Vcz5odw8JCH4F08s727XZYcJYGKr1WSnQ4UjuQbp8i7aWEdxx/d7 X-Gm-Gg: AYBFou25P5UX4xITcbpypswONW55k+/BI/xHXEPXxDR+Bj8L0cqS8riaJ0C9n8XZYLZ 82fkR+8GmCNNkN/XCsRDRmZibK6fgX/2TIfJ5u+A5VDgmy/dgLsTw4MrElnnCNEz1ADNncDsYAX eN9i05f0kv5Kn9R1N+o2R40H/IcRZpVr4p2XD3bq9jXg3pRvfghSf5gbQvU6bTdo1otiErOX69z 0QQy21Ds4pazA8ZwPjPzfiZ9UDLNpIOrPWv7KUyQvZxshf9xZhaf6vC+UTIzu5aOmEwti+Wbg8d 6iADOPjo7EAL+FNUfPfzsFoimrSzfO+WMDkK7T7KBNRKfm+rX+K/XrBcaQMXWlm4S0AzsmrBA0L oQo95TaxUh65jFqEL/scCI2wAmUIgLCQPtCFQBZbXLbb9VveSrKP7tMYM463Uz0Cyi4gJSAYJzh 0iHgcqYi1E5+rpVB7NUFhgWXyAelQzjmkBKEwmQpk0FPa8hsNcXw7vzF9M9EehHcF3Qt89OuK8W gh7 X-Received: by 2002:a05:600c:4ed0:b0:4a1:77dd:8e6a with SMTP id 5b1f17b1804b1-4a177dd9252mr4744075e9.6.1791210926245; Mon, 05 Oct 2026 07:35:26 -0700 (PDT) Received: from deb05.proceq.com ([213.160.61.66]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a027725c6asm396901835e9.8.2026.10.05.07.35.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2026 07:35:25 -0700 (PDT) From: Mehmet Fide To: Ping-Ke Shih Cc: Luka Gejak , Bitterblue Smith , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, mehmet.fide@screeningeagle.com Subject: [PATCH rtw-next v3 1/2] wifi: rtw88: download the beacon the reserved page was built with Date: Mon, 5 Oct 2026 16:35:22 +0200 Message-ID: <20261005143523.130287-2-mehmet.fide@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261005143523.130287-1-mehmet.fide@gmail.com> References: <20261005143523.130287-1-mehmet.fide@gmail.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mehmet Fide rtw_fw_download_rsvd_page() downloads the beacon twice: once as part of the reserved page and once more on its own, so that the firmware ends up with a TX descriptor that describes the beacon rather than the whole page. The second download fetched a new beacon from mac80211 instead of downloading the one the page already holds. Besides the extra work, every beacon fetch advances the DTIM count and, while a channel switch is announced, the CSA countdown; doing it twice per update lets a countdown that starts at 2 reach 0, which mac80211 warns about. Hand the beacon skb out of the page build and download that. The hw scan, which downloads the beacon without a page build, keeps fetching its own. Signed-off-by: Mehmet Fide Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/fw.c | 34 +++++++++++++++---------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c index 945fedcd375b..3cd17a3bb494 100644 --- a/drivers/net/wireless/realtek/rtw88/fw.c +++ b/drivers/net/wireless/realtek/rtw88/fw.c @@ -1622,7 +1622,8 @@ static int __rtw_build_rsvd_page_from_vifs(struct rtw_dev *rtwdev) return 0; } -static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size) +static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size, + struct sk_buff **beacon) { const struct rtw_chip_info *chip = rtwdev->chip; struct ieee80211_hw *hw = rtwdev->hw; @@ -1702,13 +1703,15 @@ static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size) list_for_each_entry(rsvd_pkt, &rtwdev->rsvd_page_list, build_list) { rtw_rsvd_page_list_to_buf(rtwdev, page_size, page_margin, page, buf, rsvd_pkt); - if (page == 0) + if (page == 0) { page += rtw_len_to_page(rsvd_pkt->skb->len + tx_desc_sz, page_size); - else + /* the caller downloads it once more on its own */ + *beacon = rsvd_pkt->skb; + } else { page += rtw_len_to_page(rsvd_pkt->skb->len, page_size); - - kfree_skb(rsvd_pkt->skb); + kfree_skb(rsvd_pkt->skb); + } rsvd_pkt->skb = NULL; } @@ -1723,11 +1726,12 @@ static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size) return NULL; } -static int rtw_download_beacon(struct rtw_dev *rtwdev) +/* the beacon the page was built with, or a fresh one for the hw scan */ +static int rtw_download_beacon(struct rtw_dev *rtwdev, struct sk_buff *beacon) { struct ieee80211_hw *hw = rtwdev->hw; struct rtw_rsvd_page *rsvd_pkt; - struct sk_buff *skb; + struct sk_buff *skb = beacon; int ret = 0; rsvd_pkt = list_first_entry_or_null(&rtwdev->rsvd_page_list, @@ -1744,7 +1748,8 @@ static int rtw_download_beacon(struct rtw_dev *rtwdev) return -EINVAL; } - skb = rtw_get_rsvd_page_skb(hw, rsvd_pkt); + if (!skb) + skb = rtw_get_rsvd_page_skb(hw, rsvd_pkt); if (!skb) { rtw_err(rtwdev, "failed to get beacon skb\n"); return -ENOMEM; @@ -1754,18 +1759,20 @@ static int rtw_download_beacon(struct rtw_dev *rtwdev) if (ret) rtw_err(rtwdev, "failed to download drv rsvd page\n"); - dev_kfree_skb(skb); + if (!beacon) + dev_kfree_skb(skb); return ret; } int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev) { - u8 *buf; + struct sk_buff *beacon = NULL; u32 size; + u8 *buf; int ret; - buf = rtw_build_rsvd_page(rtwdev, &size); + buf = rtw_build_rsvd_page(rtwdev, &size, &beacon); if (!buf) { rtw_err(rtwdev, "failed to build rsvd page pkt\n"); return -ENOMEM; @@ -1782,13 +1789,14 @@ int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev) * the beacon again to replace the TX desc header, and we will get * a correct tx_desc for the beacon in the rsvd page. */ - ret = rtw_download_beacon(rtwdev); + ret = rtw_download_beacon(rtwdev, beacon); if (ret) { rtw_err(rtwdev, "failed to download beacon\n"); goto free; } free: + dev_kfree_skb(beacon); kfree(buf); return ret; @@ -2345,7 +2353,7 @@ int rtw_hw_scan_offload(struct rtw_dev *rtwdev, struct ieee80211_vif *vif, rtw_fw_set_scan_offload(rtwdev, &cs_option, rtwvif, &chan_list); out: if (rtwdev->ap_active) { - ret = rtw_download_beacon(rtwdev); + ret = rtw_download_beacon(rtwdev, NULL); if (ret) rtw_err(rtwdev, "HW scan download beacon failed\n"); } -- 2.55.0