From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61280385D9E for ; Mon, 12 Oct 2026 01:17:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791767856; cv=none; b=IUTaCePCQvWSdZ/ZuskaRciXq5zwMtjUhQc3JqTTBYWtDlYRVh21XKfiQbFwmivhIAnP34CJbO9h6KTZjfXbflPYlfloA2BiuqnOaK6D7iBOcn6JjekgHzI5ES0E51/Qtp39Qm2Gj/8UZXQWG+dPxUuz9NYQJBaOTuUObMRbCG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791767856; c=relaxed/simple; bh=hQ0V4emjN35pL22c0loNCh7/yoeuZXj8fb7w+F5wmuw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g9I5/KcMBAQWJCmKJUtoTHt/9GmYLr3EAOideUfJU6MfZp3ivOEAPPdjlDG8D6HAh0raYK+SDdIOuFsLAfT21nZz5mlWSlExSKkYFubIMefz/5zLm4/kWJ1gzAPFgos3Im9fBK2Qxyl+4/5NMoyf6sEWlwvb1ieMGa0tRaFKllw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dtHVgD8l; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dtHVgD8l" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3ab98332238so547500a91.3 for ; Sun, 11 Oct 2026 18:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791767855; x=1792372655; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XLEFCbx9qwaV8Sh994v6fbEqFw9fgRzVy0l3bJClDuU=; b=dtHVgD8lCmdOgapM3trbUYsr6AY4zJkieaXFMVY8oX4F+cdBGUIc6IVFQs7GUBMl84 U3yahS/xinMNsjVZXLUQT5Fx7rVc2ls8nHAS2W+igZVlhicfOfqgMur0OepwwbXftHBZ i9rK2Ip9hdgEuGZ4CNWufNsbKF8dT7SMeD/k/aIsX42WJwHjKy7Sb7OZCTO+MRdNBkIr lNZkJR1wYaepW6iXrB0VF1p+2qlV2MVIJ5IB8gtdsLqR9Zw8LEw8ZqQ3Dr3Vm9XQglXb WPLmwVMM2icWqb1lZIlV/l99ZzmcpA2hEAZKRTq18rAT7zrz2yGNfkIkN5QZRvVSrNw8 tQ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791767855; x=1792372655; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XLEFCbx9qwaV8Sh994v6fbEqFw9fgRzVy0l3bJClDuU=; b=NPA+UxgOF94uidgTaUD3Idb8wJDVRKCZdvsf3gchwaw1DHsS/K03NgSHEehm+uFsgp Qai/HAJ3yT7hItaQIyrNOENcH3BtL7++G//EZuhBRtdiA5ponGRo0UEfHrQtdbYxMdsH /69/sbQQjv+kpiz8lRXKAhjerl9O+khizE1CziZFsE9l7zVZNIKoO9EoBXN42pkd79Wl lG/02qBNZr1lMfyTjLyulKMNRcGuudwUUtAoKYYGPtHop9HihX4x3DEGUOfdTU3Gt+vh cn0gd9+4fE/8ZeB3rSxgOJu2dcGli96uzdI/m8LVCdgPowo0BEpb7W5PY9HfIPPoEN9P cyew== X-Forwarded-Encrypted: i=1; AKwUvBw8ybI+gV3YDM1l9U56AvoniSoVUOQM3crAit/L4UM7ZGTecSDE8XDcTjg9kCodKt55Yv/EdBxba84FHIp5AA==@vger.kernel.org X-Gm-Message-State: AFq9FYJUT/uwxFvS5I1KRhgEpBw69IHhsn2w70Ti6naZzeGL7sXK6AGr kS352k6w2dptfE86bE3RdxDTnqyBEY+zPlxmrVHG5zqshmgoBy6LhkUMaI6dnRKt X-Gm-Gg: AYBFou2rT1xboc3RdOetHyRjfbf9f4wi4WVdohCbeEDQOkopaih1jmNhGkMw9Ezoupw YCr4z6B+Ati72GV8IZRYr+mRce01g6jwQ1VYcapBEzohW0nmTFXmCL1McCFBgCPvjmq9KRcfdKn 89TWNw1/TX5tjQ90d43sb2KnEnkNvkgDZNxvCzCpJMeFJTCaBoaMLfRs7uEB4VgVV3GvLuwUtud DUOPgA1ILqC8oOsN2WImfYNRDqfSX5kx3OpbA6BT3h4swCHes3BxJwlp2Fam0HJdvruQWBOsHZv VyVJaA1heGsBtDYQA9RMItpOwBoGVZYmASCn+jI9H1CcdcXKsvlvad8i/70g86nruYGP+U6xOCp 0ktxG6sICmUN7hzaG9He+YHwhs3PLuagcvbjkR/z29poUiu3UyXThSs/3WU3Y7B9XhGFic+9axU yzAZNFbOfOj2AQVPEEWy6bki+ZwWjuzXNhx2aCGqzJjvKbSDjb9hnzWG35YqEcYuzRCuN777VC8 k77Op2x+qqy9ghiJPZiQQCAcIHXtvnPvQnMOO2Xt4pTJ+TOIr6ypVi6QJajPat0toMp1z8xWQOK X-Received: by 2002:a17:90a:d44b:b0:3ab:365f:ebdd with SMTP id 98e67ed59e1d1-3ab3ad2029bmr6553771a91.37.1791767854603; Sun, 11 Oct 2026 18:17:34 -0700 (PDT) Received: from m-upc-A520M-HDV.lan (oki-109-236-14-10.jptransit.net. [109.236.14.10]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ab38dd5864sm13743307a91.8.2026.10.11.18.17.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2026 18:17:34 -0700 (PDT) Sender: Yuyang Huang From: Yuyang Huang To: Yuyang Huang Cc: Ajay Singh , Aleksandr Loktionov , Andrew Lunn , Claudiu Beznea , "David S. Miller" , David Ahern , Donald Hunter , Eric Dumazet , Ido Schimmel , Jacob Keller , Jakub Kicinski , Johannes Berg , Kees Cook , Kory Maincent , Kuniyuki Iwashima , Nicolas Dichtel , Nikolaos Gkarlis , Paolo Abeni , Sabrina Dubroca , Shuah Khan , Simon Horman , Stanislav Fomichev , Vadim Fedorenko , Willem de Bruijn , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v11 3/6] net: add a generation counter for dev->mc changes Date: Mon, 12 Oct 2026 10:17:04 +0900 Message-ID: <20261012011707.3378-4-sigefriedhyy@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261012011707.3378-1-sigefriedhyy@gmail.com> References: <20261012011707.3378-1-sigefriedhyy@gmail.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A multi-part RTM_GETMULTICAST dump of dev->mc resumes by position, so entries added or removed between two dump rounds can be skipped or repeated. The IPv4 and IPv6 dumps report that with NLM_F_DUMP_INTR by stamping cb->seq from a per netns generation counter combined with dev_base_seq, see inet_base_seq(). Add the equivalent for the device multicast lists: a per netns counter bumped whenever an entry is added to or removed from any dev->mc. The list helpers do not know which device a list belongs to, so give netdev_hw_addr_list an mc_dev pointer, set for dev->mc only, and bump the counter of dev_net(mc_dev) from the count helpers. That covers the dev_mc_* helpers, both lists of a sync, the hardware sync helpers drivers call from their rx mode callbacks or their own workers and the reconciliation after an asynchronous rx mode update. It is atomic since the writers only hold the address lock of their own device. Used by the following patch for the AF_PACKET multicast dump. Signed-off-by: Yuyang Huang Reviewed-by: Nicolas Dichtel --- include/linux/netdevice.h | 3 +++ include/net/net_namespace.h | 1 + net/core/dev_addr_lists.c | 15 +++++++++++++++ 3 files changed, 19 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 3d9e3a70ca5c9..6c837ea34748e 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -259,6 +259,9 @@ struct netdev_hw_addr_list { /* Auxiliary tree for faster lookup on addition and deletion */ struct rb_root tree; + + /* Set for dev->mc only, the device the list belongs to */ + struct net_device *mc_dev; }; #define netdev_hw_addr_list_count(l) ((l)->_count) diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index 46b4c67e2966f..c29a22ca178fa 100644 --- a/include/net/net_namespace.h +++ b/include/net/net_namespace.h @@ -71,6 +71,7 @@ struct net { spinlock_t rules_mod_lock; unsigned int dev_base_seq; /* protected by rtnl_mutex */ + atomic_t dev_mc_genid; /* dev->mc membership changes */ u32 ifindex; spinlock_t nsid_lock; diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c index d615192d1c3b1..3ab053cbf8b99 100644 --- a/net/core/dev_addr_lists.c +++ b/net/core/dev_addr_lists.c @@ -16,9 +16,19 @@ #include "dev.h" +/* RTM_GETMULTICAST dumps use the netns generation counter to detect + * changes of dev->mc between dump rounds. + */ +static void __hw_addr_changed(struct netdev_hw_addr_list *list) +{ + if (list->mc_dev) + atomic_inc(&dev_net(list->mc_dev)->dev_mc_genid); +} + static void __hw_addr_count_add(struct netdev_hw_addr_list *list, int value) { list->_count += value; + __hw_addr_changed(list); } static void __hw_addr_count_inc(struct netdev_hw_addr_list *list) @@ -33,7 +43,10 @@ static void __hw_addr_count_dec(struct netdev_hw_addr_list *list) static void __hw_addr_count_reset(struct netdev_hw_addr_list *list) { + if (!list->_count) + return; list->_count = 0; + __hw_addr_changed(list); } /* @@ -521,6 +534,7 @@ void __hw_addr_init(struct netdev_hw_addr_list *list) INIT_LIST_HEAD(&list->list); list->_count = 0; list->tree = RB_ROOT; + list->mc_dev = NULL; } EXPORT_SYMBOL(__hw_addr_init); @@ -1197,6 +1211,7 @@ EXPORT_SYMBOL(dev_mc_flush); void dev_mc_init(struct net_device *dev) { __hw_addr_init(&dev->mc); + dev->mc.mc_dev = dev; } EXPORT_SYMBOL(dev_mc_init); -- 2.43.0