Re: [PATCH rtw-next] wifi: rtw88: 8723d: add iface combination

[Carl Quist <equalizerjr@gmail.com>]

Hi Luka,

Thanks for the review, and for testing it on an RTL8723DU.

On Sat Oct 17, 2026 at 10:41 AM, Luka Gejak wrote:
> Where does the AP beacon fit in the reserved pages?
>
> This chip has 8 pages of 128 bytes, while rtl8822c has 16, so the 8822c
> never had to squeeze a beacon in next to the station pages.

You are right, I missed this. I went through rtw_build_rsvd_page() and
get the same numbers: the five station packets take 6 of the 8 pages,
which leaves 2 pages, so the beacon must stay at or below 216 bytes.

> Can the station pages be trimmed while an AP is present, or maybe this
> combination should only be used on the chips with the bigger page budget?

I think they can be trimmed for every station, not only while an AP is
present. Two of the five packets, RSVD_LPS_PG_DPK and RSVD_LPS_PG_INFO,
take 3 pages, but their locations are only read by rtw_fw_set_pg_info(),
which only runs in LPS_DEEP_MODE_PG. rtw_update_lps_deep_mode() never
picks that mode unless the chip sets BIT(LPS_DEEP_MODE_PG) in
lps_deep_mode_supported, and only 8822c does; 8723d has 0.

So for v2 I plan to add a patch before this one that only reserves those
two pages on chips with LPS PG. That leaves 5 pages for the beacon next
to a station on 8723d, i.e. up to 600 bytes, and changes nothing for
8822c.

Before sending v2 I will repeat your check on my RTL8723DE: grow the
beacon past 216 bytes with vendor_elements in hostapd and confirm there
is no "rsvd page over size" and the beacon is actually transmitted.

Ping-Ke, does that approach look acceptable to you, or would you prefer
to keep the combination limited to 8822c?

Best regards,
Carl